Re: [ovs-dev] [PATCH] ovs-ctl: Properly handle shell quoting inos-release.

2016-08-15 Thread Panu Matilainen
On 08/15/2016 03:40 AM, Ryan Moats wrote: Ben Pfaff wrote on 08/14/2016 07:38:08 PM: From: Ben Pfaff To: Ryan Moats/Omaha/IBM@IBMUS Cc: dev@openvswitch.org, Matthew Mulsow/Austin/IBM@IBMUS Date: 08/14/2016 07:38 PM Subject: Re: [ovs-dev] [PATCH] ovs-ctl: Properly

[ovs-dev] [PATCH] ovs-ctl: support populating system info from /etc/os-release

2016-08-10 Thread Panu Matilainen
-specific system-type.conf and system-version.conf. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1350550 Signed-off-by: Panu Matilainen <pmati...@redhat.com> --- utilities/ovs-ctl.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in

Re: [ovs-dev] [ovs-discuss] OVS DPDK VFIO error

2016-08-09 Thread Panu Matilainen
On 08/09/2016 03:14 PM, Kapil Adhikesavalu wrote: Hi Bhanu Prakash, I already check the BIOS, VT-d is enabled by default. From the dmesg, how can i find if VT-d is enabled, i see "IOMMU enabled", i don't understand the rest. [root@localhost ~]# dmesg | grep -e DMAR -e IOMMU [0.00]

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Panu Matilainen
On 04/30/2016 03:23 AM, Daniele Di Proietto wrote: I see that vhost-cuse is still handled separately. Is it possible to use the vhost pmd also for vhost-cuse? Otherwise we still basically have to handle differently three cases: NIC PMD, vhost user pmd, vhost cuse. Maybe it's time to remove

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

2016-04-15 Thread Panu Matilainen
On 04/13/2016 07:21 PM, Traynor, Kevin wrote: -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu Matilainen Sent: Wednesday, April 13, 2016 8:50 AM To: Weglicki, MichalX <michalx.wegli...@intel.com>; dev@openvswitch.org Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

2016-04-13 Thread Panu Matilainen
On 04/13/2016 11:38 AM, Panu Matilainen wrote: On 04/13/2016 11:33 AM, Panu Matilainen wrote: On 04/13/2016 11:16 AM, Weglicki, MichalX wrote: -Original Message- From: Panu Matilainen [mailto:pmati...@redhat.com] Sent: Wednesday, April 13, 2016 8:50 AM To: Weglicki, MichalX

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

2016-04-13 Thread Panu Matilainen
On 04/13/2016 11:33 AM, Panu Matilainen wrote: On 04/13/2016 11:16 AM, Weglicki, MichalX wrote: -Original Message- From: Panu Matilainen [mailto:pmati...@redhat.com] Sent: Wednesday, April 13, 2016 8:50 AM To: Weglicki, MichalX <michalx.wegli...@intel.com>; dev@openvswitch.org S

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

2016-04-13 Thread Panu Matilainen
On 04/13/2016 11:16 AM, Weglicki, MichalX wrote: -Original Message- From: Panu Matilainen [mailto:pmati...@redhat.com] Sent: Wednesday, April 13, 2016 8:50 AM To: Weglicki, MichalX <michalx.wegli...@intel.com>; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Update relevant art

Re: [ovs-dev] [PATCH] Update relevant artifacts to add support for DPDK 16.04.

2016-04-13 Thread Panu Matilainen
On 04/12/2016 05:05 PM, mweglicx wrote: [...] diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index e09b471..2295e53 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1740,31 +1740,31 @@ netdev_dpdk_get_features(const struct netdev *netdev_, link = dev->link;

Re: [ovs-dev] [PATCH v4] acinclude: Autodetect DPDK location when configuring OVS

2016-04-08 Thread Panu Matilainen
On 03/30/2016 06:26 PM, Bhanuprakash Bodireddy wrote: When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if DPDK library, headers are in standard compiler search paths. This patch fixes the problem by searching for

[ovs-dev] [PATCH] dpif-netdev: report numa node number on pmd thread create failure

2016-04-06 Thread Panu Matilainen
node than the cores. Report the NUMA node number to help diagnosing the issue. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1295952 Signed-off-by: Panu Matilainen <pmati...@redhat.com> --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib

Re: [ovs-dev] [PATCH v3] acinclude: Autodetect DPDK when configuring OVS

2016-03-30 Thread Panu Matilainen
On 03/25/2016 05:31 PM, Bhanuprakash Bodireddy wrote: When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if DPDK library, headers are in standard compiler search paths. This patch fixes the problem by searching for

Re: [ovs-dev] [PATCH v2] acinclude: Autodetect DPDK location when configuring OVS

2016-03-23 Thread Panu Matilainen
On 03/21/2016 04:12 PM, Bhanuprakash Bodireddy wrote: When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if the DPDK is installed in standard location i.e /usr/local/share/dpdk (or) /usr/share/dpdk This patch fixes the

Re: [ovs-dev] [PATCH] acinclude: Autodetect DPDK location when configuring OVS

2016-03-21 Thread Panu Matilainen
On 03/20/2016 10:38 PM, Bodireddy, Bhanuprakash wrote: Hello Panu, Thanks for the comments. I have follow up question on the auto discovery of DPDK install location. As the DPDK install location can vary with distros, do OVS configure script has to search for DPDK libraries in

Re: [ovs-dev] [PATCH] acinclude: Autodetect DPDK location when configuring OVS

2016-03-19 Thread Panu Matilainen
On 03/18/2016 01:11 PM, Bhanuprakash Bodireddy wrote: When using DPDK datapath, the OVS configure script requires the DPDK build directory passed on --with-dpdk. This can be avoided if the DPDK is installed in standard location i.e /usr/src. This patch fixes the problem by searching for DPDK

Re: [ovs-dev] [PATCH v2 00/23] RFC: rework code base for third-party linking

2016-03-04 Thread Panu Matilainen
On 03/03/2016 08:20 PM, b...@skyportsystems.com wrote: From: Ben Warren This patch set is a first stab at making a 'dev' distribution for OpenVswitch The goal is to provide shared libraries and header files so that third party applications can link in OVS rather than

Re: [ovs-dev] [PATCH] types: Fix defined but not used warning.

2016-02-22 Thread Panu Matilainen
On 02/19/2016 11:35 PM, William Tu wrote: warning: ‘OVS_BE128_MAX’ defined but not used [-Wunused-const-variable] Found using CentOS 6.6 with gcc 6.6.0. Signed-off-by: William Tu Just FWIW, this particular gcc 6 behavior is still under debate:

Re: [ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-28 Thread Panu Matilainen
On 01/27/2016 05:57 PM, Flavio Leitner wrote: On Thu, 14 Jan 2016 15:38:59 +0200 Panu Matilainen <pmati...@redhat.com> wrote: Requires DPDK >= 2.2 as that is the first version to have a standard install layout which we can discover without help from user. Signed-off-by: Panu Matilain

[ovs-dev] [PATCH] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-28 Thread Panu Matilainen
Requires DPDK >= 2.2 as that is the first version to have a standard install layout which we can discover without help from user. Additionally document the option in INSTALL.Fedora.md. Signed-off-by: Panu Matilainen <pmati...@redhat.com> --- INSTALL.Fedora.md | 3

Re: [ovs-dev] [PATCH v4 4/4] netdev-dpdk: Allow arbitrary eal arguments

2016-01-18 Thread Panu Matilainen
On 01/15/2016 10:02 PM, Aaron Conole wrote: A previous change moved some commonly used arguments from commandline to the database. This change allows arbitrary eal arguments to be provided via a new db entry 'other_config:dpdk-extra' which will tokenize the string and add it to the argument

Re: [ovs-dev] [PATCH v3 2/3] netdev-dpdk: Convert initialization from cmdline to db

2016-01-15 Thread Panu Matilainen
On 01/13/2016 11:17 PM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk

Re: [ovs-dev] [PATCH 2/2] openvswitch: make auto-attach logic disable-able

2016-01-14 Thread Panu Matilainen
On 01/13/2016 11:50 PM, Ben Pfaff wrote: Ben Pfaff wrote: How much does this commit trim from the binary size? Alexandru Ardelean wrote: Roughly a 34k decrease in binary size, decrease being in libofproto and libopenvswitch libs Quite a small decrease, so more --disable- flags would be

[ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-14 Thread Panu Matilainen
Requires DPDK >= 2.2 as that is the first version to have a standard install layout which we can discover without help from user. Signed-off-by: Panu Matilainen <pmati...@redhat.com> --- As a follow-up to this discussion (oh my, where did the time go...): http://openvswitch.org/pipe

Re: [ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-14 Thread Panu Matilainen
On 01/14/2016 06:22 PM, Aaron Conole wrote: Panu Matilainen <pmati...@redhat.com> writes: Requires DPDK >= 2.2 as that is the first version to have a standard install layout which we can discover without help from user. Signed-off-by: Panu Matilainen <pmati...@redhat.com> ---

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: Convert initialization from cmdline to db

2016-01-07 Thread Panu Matilainen
On 01/04/2016 11:46 PM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk

Re: [ovs-dev] [ovs-discuss] [announce] driverctl: utility for persistent alternative driver binding

2015-12-08 Thread Panu Matilainen
On 12/04/2015 05:44 PM, Gray, Mark D wrote: I welcome this initiative, one question below: -Original Message- From: discuss [mailto:discuss-boun...@openvswitch.org] On Behalf Of Panu Matilainen Sent: Friday, December 4, 2015 10:54 AM To: d...@dpdk.org; us...@dpdk.org; dev

[ovs-dev] [announce] driverctl: utility for persistent alternative driver binding

2015-12-04 Thread Panu Matilainen
Hi all, While this is not directly related to DPDK or OVS, it is potentially useful for users of both, so excuse me for cross-posting. Quoting from the project README (for the full text see http://laiskiainen.org/git/?p=driverctl.git;a=blob_plain;f=README) > driverctl is a tool for

Re: [ovs-dev] [RFC 1/2] dpdk: Convert initialization from cmdline to db

2015-12-04 Thread Panu Matilainen
On 12/03/2015 06:23 AM, Aaron Conole wrote: Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk

[ovs-dev] [PATCH] rhel: Add support DPDK port creation via network scripts

2015-12-01 Thread Panu Matilainen
Add support for creating a userspace bridge and the four DPDK port types via network scripts + basic documentation. Signed-off-by: Panu Matilainen <pmati...@redhat.com> --- rhel/README.RHEL | 43 +++ rhel/etc_sysconfig_network-scripts_

Re: [ovs-dev] OVS with DPDK Meetup notes

2015-12-01 Thread Panu Matilainen
On 11/26/2015 07:56 PM, Traynor, Kevin wrote: Hi All, Just wanted to post some summary notes on the recent OVS with DPDK Meetup we had after the OVS conference. Thanks to everyone for the often lively discussion. I've collated and condensed Maryam's notes (Thank you Maryam) with my own.

Re: [ovs-dev] OVS+DPDK rpm

2015-11-26 Thread Panu Matilainen
On 11/25/2015 08:27 PM, Aaron Conole wrote: Flavio, Thanks for these questions. Flavio Leitner writes: Hi, In order to build the Fedora RPM with DPDK some changes to the spec file are required. However, I was told that not all users want to build with DPDK or even have

[ovs-dev] [PATCH] rpms: %exclude has side-effects, remove the files from buildroot instead

2015-11-25 Thread Panu Matilainen
/show_bug.cgi?id=1281913 Signed-off-by: Panu Matilainen <pmati...@redhat.com> --- rhel/openvswitch-fedora.spec.in | 25 - rhel/openvswitch.spec.in| 12 +--- 2 files changed, 17 insertions(+), 20 deletions(-) diff --git a/rhel/openvswitch-fedora.spec.in

Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-06-24 Thread Panu Matilainen
On 06/24/2015 05:06 AM, Pravin Shelar wrote: On Tue, Jun 23, 2015 at 2:51 PM, Jesse Gross je...@nicira.com wrote: On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar pshe...@nicira.com wrote: On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto diproiet...@vmware.com wrote: On 18/06/2015 23:57,

Re: [ovs-dev] [PATCH v5] netdev-dpdk: add dpdk vhost-user ports

2015-05-19 Thread Panu Matilainen
callbacks to minimise code duplication. - Fixed indentation line-wrap. - Simplified and corrected the processing of vhost ovs-vswitchd flags. v5: - Removed unnecessary strdup() - Fixed spacing Signed-off-by: Ciara Loftus ciara.lof...@intel.com Looks good to me, thanks! Acked-by: Panu Matilainen

Re: [ovs-dev] [PATCH v4] netdev-dpdk: add dpdk vhost-user ports

2015-05-18 Thread Panu Matilainen
On 05/13/2015 04:15 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. A new dpdkvhostuser port will create a unix domain socket which when provided to QEMU is used to facilitate communication between the virtio-net device on the

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add dpdk vhost-user ports

2015-05-13 Thread Panu Matilainen
On 05/11/2015 01:56 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. A new dpdkvhostuser port will create a unix domain socket which when provided to QEMU is used to facilitate communication between the virtio-net device on the

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add dpdk vhost-user ports

2015-05-08 Thread Panu Matilainen
On 05/07/2015 08:38 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. A new dpdkvhostuser port will create a unix domain socket which when provided to QEMU is used to facilitate communication between the virtio-net device on the

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-27 Thread Panu Matilainen
On 04/27/2015 11:04 PM, Pravin Shelar wrote: On Fri, Apr 24, 2015 at 1:44 AM, Panu Matilainen pmati...@redhat.com wrote: On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: Hi all, Just a quick poll: are the resolutions to review comments in this patch acceptable to everyone? If I've missed

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Panu Matilainen
details of vhost user support limitations to INSTALL.DPDK.md - refactor travis/build.sh to reflect these changes v3: -correct minor typos in commit message Signed-off-by: Mark Kavanagh mark.b.kavan...@intel.com Signed-off-by: Panu Matilainen pmati...@redhat.com It feels a bit strange to have

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Panu Matilainen
Hi, A few comments inline... On 04/21/2015 01:10 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. It adds to the existing infrastructure of vhost-cuse, however disables vhost-cuse ports as the default port type, in favour of

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Panu Matilainen
On 04/24/2015 04:01 PM, Flavio Leitner wrote: On Fri, 24 Apr 2015 14:17:17 +0300 Panu Matilainen pmati...@redhat.com wrote: Hi, A few comments inline... On 04/21/2015 01:10 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-21 Thread Panu Matilainen
On 04/21/2015 12:50 AM, Pravin Shelar wrote: On Wed, Apr 15, 2015 at 12:03 AM, Panu Matilainen pmati...@redhat.com wrote: On 04/14/2015 11:31 PM, Pravin Shelar wrote: On Thu, Mar 19, 2015 at 11:48 AM, Ciara Loftus ciara.lof...@intel.com wrote: This patch adds support for a new port type

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-15 Thread Panu Matilainen
On 04/14/2015 11:31 PM, Pravin Shelar wrote: On Thu, Mar 19, 2015 at 11:48 AM, Ciara Loftus ciara.lof...@intel.com wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. It adds to the existing infrastructure of vhost-cuse, however disables vhost-cuse

Re: [ovs-dev] [PATCH] DPDK: add support for v2.0.0

2015-04-09 Thread Panu Matilainen
Kavanagh mark.b.kavan...@intel.com Signed-off-by: Panu Matilainen pmati...@redhat.com --- .travis/build.sh |6 +++--- INSTALL.DPDK.md | 10 +++--- lib/netdev-dpdk.c |3 +-- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/.travis/build.sh b/.travis/build.sh index

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix build with unified RSS offload types in DPDK 2.0

2015-03-06 Thread Panu Matilainen
On 03/06/2015 12:04 PM, Kavanagh, Mark B wrote: On Thu, Mar 5, 2015 at 1:29 AM, Panu Matilainen pmati...@redhat.com wrote: RSS offload types were unified and simplified in DPDK 2.0, easily handled with an ifdef though. OVS does not support DPDK 2.0 yet. Is there any reason to introduce

[ovs-dev] [PATCH] netdev-dpdk: Fix build with unified RSS offload types in DPDK 2.0

2015-03-05 Thread Panu Matilainen
RSS offload types were unified and simplified in DPDK 2.0, easily handled with an ifdef though. Signed-off-by: Panu Matilainen pmati...@redhat.com --- lib/netdev-dpdk.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 1ba8310..b095826 100644

Re: [ovs-dev] [PATCHv3] lib: upgrade to DPDK v1.8.0

2015-02-17 Thread Panu Matilainen
On 02/17/2015 11:20 PM, Mark Kavanagh wrote: DPDK v1.8.0 makes significant changes to struct rte_mbuf, including removal of the 'pkt' and 'data' fields. The latter, formally a pointer, is now calculated via an offset from the start of the segment buffer. These fields are referenced by OVS when

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-14 Thread Panu Matilainen
On 01/14/2015 03:53 PM, Finucane, Stephen wrote: I dont remember the automake version I first encountered that, it was on another project which had already been using ustar for several years but then at some point during 2013 it started whining about large UIDs. Assuming said project was open

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-14 Thread Panu Matilainen
On 01/14/2015 01:15 PM, Finucane, Stephen wrote: Thanks for the followup. I hope that the Automake maintainers consider the issue. No reply after 1 week. How could we proceed here, as I'm still unable to run 'make dist' (without manual patching) in the interim? Based on my conversation

Re: [ovs-dev] [PATCH] configure.ac: Enable 'tar-ustar' by default

2015-01-14 Thread Panu Matilainen
On 01/14/2015 02:02 PM, Finucane, Stephen wrote: On 01/14/2015 01:15 PM, Finucane, Stephen wrote: Thanks for the followup. I hope that the Automake maintainers consider the issue. No reply after 1 week. How could we proceed here, as I'm still unable to run 'make dist' (without manual