Re: [ovs-dev] [PATCH 1/2] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-19 Thread Peter Amidon
in the resulting completions. > Thusly, we need to trim the colon-word and equal-word prefixes from reply. > Signed-off-by: Alex Wang This looks good to me now. Thanks, Peter Amidon ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] bashcomp: Install and package completion scripts.

2015-03-19 Thread Peter Amidon
how to manually install the scripts into /etc/bash_completion.d. Should we also change it to make it clear that the scripts will be installed by default, with an explanation of how to manually use them in other cases? Thanks, Peter Amidon ___ dev mail

Re: [ovs-dev] [RFC 1/2] ovs-vsctl-bashcomp: Avoid setting the COMP_WORDBREAKS.

2015-03-18 Thread Peter Amidon
can use it in test mode as well? _ovs_vsctl_trim_compreply currently uses a very different method of trimming from that used in test mode... Thanks, Peter Amidon ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [completion 2/3] ovs-vsctl-bashcomp: Add bash command-line completion for ovs-vsctl.

2015-03-10 Thread Peter Amidon
On Mon, 09 Mar 2015 21:31:11 -0700: Alex Wang wrote: > I'm personally fine with just using the 'ARG' here. > The precise command format should be: >add-aa-mapping bridge NEW-ISID NEW-VLAN >del-aa-mapping bridge ISID VLAN > You could refer to 'AutoAttach TABLE' in ovs-v

Re: [ovs-dev] [completion 2/3] ovs-vsctl-bashcomp: Add bash command-line completion for ovs-vsctl.

2015-03-09 Thread Peter Amidon
x27;arguments' member of 'struct vsctl_command_syntax'. > Thanks, > Alex Wang, On Mon, Mar 9, 2015 at 3:54 PM, Ben Pfaff wrote: >> On Mon, Mar 09, 2015 at 10:00:29AM -0700, Alex Wang wrote: >> > From: Peter Amidon >> > >> > This patch adds bas

Re: [ovs-dev] [RFC 3/3] ovs-vsctl-bashcomp: Documentation and unit tests.

2015-03-06 Thread Peter Amidon
On Thu, 05 Mar 2015 21:58:38 -0800: Ben Pfaff wrote: > Without digging into it, it's not obvious to me why you need to know the > bash prompt. Can you just set a known prompt instead? In a few cases the script has to print some output to the user (e.g. if the user attempts to complete while

Re: [ovs-dev] [RFC 2/3] ovs-vsctl-bashcomp: Add bash command-line completion for ovs-vsctl.

2015-03-04 Thread Peter Amidon
These changes all look good to me, I really like the unit32_t-as-a-stack idea. ---Peter On Tue, 03 Mar 2015 21:41:11 -0800: Ben Pfaff wrote: On Mon, Feb 23, 2015 at 08:48:59AM -0800, Alex Wang wrote: >> From: Peter Amidon >> >> This patch adds bash command-line