2016-06-23 (15:59 -0700) ~ Ben Pfaff
> On Thu, Jun 09, 2016 at 11:52:49AM +0200, Quentin Monnet wrote:
>> Signed-off-by: David Marchand
>> Signed-off-by: Liu Xiaofeng
>> Signed-off-by: Quentin Monnet
>
> Who is the author, and what are the roles of the others in t
Hi Ryan,
> > Other UNIX-like systems only use _SC_NPROCESSORS_ONLN.
>
> After double checking, I'm not *entirely* sure that's true, but it can
> be updated in a follow-on patch
>
I meant “Other UNIX-like systems only use _SC_NPROCESSORS_ONLN *with
this commit*”, I did not mean that there was no o
. Other UNIX-like
systems only use _SC_NPROCESSORS_ONLN.
Signed-off-by: David Marchand
Signed-off-by: Liu Xiaofeng
Signed-off-by: Quentin Monnet
---
v4:
sched_getaffinity() is specific to Linux, do not use it for other systems
v3:
Add `CPU_FREE(set);`, at the correct location
v2:
Add `CPU_FREE(set
Marchand
Signed-off-by: Liu Xiaofeng
Signed-off-by: Quentin Monnet
---
Thank you Ryan for the feedback. Also, sorry for the noise with v2.
v3:
Add `CPU_FREE(set);`, at the correct location
v2:
Add `CPU_FREE(set);`
Tests: on a VM with 3 cores:
- OVS master:
# taskset -c 1 ovs-vswitchd
Marchand
Signed-off-by: Liu Xiaofeng
Signed-off-by: Quentin Monnet
---
v2:
Add `CPU_FREE(set);`
Tests: on a VM with 3 cores:
- OVS master:
# taskset -c 1 ovs-vswitchd --pidfile
2016-06-02T11:05:47Z|1|ovs_numa|INFO|Discovered 3 CPU cores on NUMA node 0
2016-06-02T11:05:47Z|2|ovs_numa
Hi all,
Does anyone have some feedback about this patch, please?
Best regards,
Quentin
2016-05-20 (11:20 +0200) ~ Quentin Monnet
> From: David Marchand
>
> Relying on /proc/cpuinfo to count the number of available cores is not
> the best option:
>
> - The code is x86-sp
@kaust.edu.sa
> diff --git a/lib/stp.c b/lib/stp.c
> index 0f92ed1..ecef012 100644
> […]
This patch does address the issue of my previous email (
http://openvswitch.org/pipermail/dev/2016-May/071381.html ). Thanks!
Test-by: Quentin Monnet
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
only after
`mutex` is initialized (and thus cannot be called at all if STP has not
been enabled).
Signed-off-by: Ding Zhi
Signed-off-by: Liu Xiaofeng
Signed-off-by: Quentin Monnet
---
lib/stp.c | 3 ++-
lib/stp.h | 1 -
vswitchd/bridge.c | 1 -
3 files changed, 2 insertions(+), 3
Marchand
Signed-off-by: Liu Xiaofeng
Signed-off-by: Quentin Monnet
---
lib/ovs-thread.c | 75 +---
1 file changed, 12 insertions(+), 63 deletions(-)
diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c
index 3c065cf15fb7..f084ed1f72ad 100644
2016-03-02 15:56 GMT+01:00 Quentin Monnet :
> Proposal: add an option to ovs-ofctl utility so as to obtain colorized
> output
> in tty, for easier reading. Currently, only the dump-flows command supports
> colors.
>
> A new `--color` option has been added to ovs-ofctl so as to
Signed-off-by: Quentin Monnet
---
NEWS | 1 +
1 file changed, 1 insertion(+)
diff --git a/NEWS b/NEWS
index a968f4f92340..cb37eb6a0343 100644
--- a/NEWS
+++ b/NEWS
@@ -17,6 +17,7 @@ Post-v2.5.0
- ovs-ofctl:
* queue-get-config command now allows a queue ID to be specified
variable OVS_COLORS (used for user-defined
colors) has been documented as well.
Signed-off-by: Quentin Monnet
---
lib/colors.man | 60
manpages.mk | 2 ++
utilities/ovs-ofctl.8.in | 1 +
3 files changed, 63 insertions
Add color output for flow match conditions for ovs-ofctl dump-flows
command utility, by inserting color markers in the functions responsible
for printing those match condictions.
Signed-off-by: Quentin Monnet
---
lib/flow.c | 3 +-
lib/match.c | 126
This commit adds colors to the “left part” of printed flows (to flow
properties that are always present: `cookie`, `table`, timeouts, etc.).
Signed-off-by: Quentin Monnet
---
lib/ofp-print.c | 32 +---
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a
Add color output for flow actions for ovs-ofctl dump-flows command
utility, by inserting color markers in the functions responsible for
printing those actions.
Signed-off-by: Quentin Monnet
---
lib/bundle.c | 13 ++--
lib/learn.c | 49 +++-
lib/multipath.c | 9 ++-
lib
is used instead.
As an example, setting OVS_COLORS to the following string is equivalent
to using the default values:
OVS_COLORS="ac:01;31:dr=34:le=31:pm=36:pr=35:sp=33:vl=32"
Signed-off-by: Quentin Monnet
---
lib/automake.mk | 2 +
lib/colors.c
:
ovs-ofctl dump-flows br0 --color=never
ovs-ofctl dump-flows br0
The result of this option is stored into a variable which is to be
forwarded (in next commits) as a function argument until it reaches the
functions that print the elements of the flows.
Signed-off-by: Quentin Monnet
---
lib
another one yet, so there is still
the issue of the `--color` option that is unused in the first two patches
(meanwhile, it makes reviewing the code easier). Should I squash the first
three patches?
Quentin Monnet (7):
ovs-ofctl: add option for color output to dump-flows command
ovs-ofctl
2016-02-24 1:01 GMT+01:00 Ben Pfaff :
> On Mon, Feb 15, 2016 at 04:22:07PM +0100, Quentin Monnet wrote:
> > Add color output for flow actions for ovs-ofctl dump-flows command
> > utility
> >
> > Signed-off-by: Quentin Monnet
>
> At a skim, I'm OK with the
2016-02-15 16:19 GMT+01:00 Quentin Monnet :
> Proposal: add an option to ovs-ofctl utility so as to obtain colorized
> output
> in tty, for easier reading. Currently, only the dump-flows command supports
> colors.
>
> A new `--color` option has been added to ovs-ofctl so as to
implemented, to be completed if colors are
to be provided for other commands / tools).
Signed-off-by: Quentin Monnet
---
lib/dpif-netdev.c | 2 +-
lib/flow.c | 7 +-
lib/flow.h | 3 +-
lib/match.c | 288
This commit adds colors to the “left part” of printed flows (to flow
properties that are always present: `cookie`, `table`, timeouts, etc.).
It uses the functions previously defined in dynamic-string.{c,h} to
insert color markers around the names of the properties.
Signed-off-by: Quentin Monnet
implemented, to be completed if colors are
to be provided for other commands / tools).
Signed-off-by: Quentin Monnet
---
lib/bundle.c | 19 +-
lib/bundle.h | 3 +-
lib/learn.c | 59 --
lib/learn.h | 3 +-
lib/multipath.c
is used instead.
As an example, setting OVS_COLORS to the following string is equivalent
to using the default values:
OVS_COLORS="ac:01;31:dr=34:le=31:pm=36:pr=35:sp=33:vl=32"
Signed-off-by: Quentin Monnet
---
lib/automake.mk | 2 +
lib/colors.c
Define three functions, respectively used for:
* printing a new color marker before text to colorize
* printing end color marker
* wrapping the two previous functions into a substitute to
ds_put_format(), with colors
Signed-off-by: Quentin Monnet
---
lib/dynamic-string.c | 32
:
ovs-ofctl dump-flows br0 --color=never
ovs-ofctl dump-flows br0
The result of this option is stored into a variable which is to be
forwarded (in next commits) as a function argument until it reaches the
functions that print the elements of the flows.
Signed-off-by: Quentin Monnet
more details. This version also splits the two patches of v1 into several
smaller patches so as to ease comprehension and review.
Quentin Monnet (6):
ovs-ofctl: add option for color output to dump-flows command
ovs-ofctl: declare / set up colors for command output
dynamic-string: define
2016-02-02 19:14 GMT+01:00 Ben Pfaff :
> On Tue, Feb 02, 2016 at 09:31:22AM +0100, Quentin Monnet wrote:
> > 2016-02-01 18:14 GMT+01:00 Ben Pfaff :
> >
> > > On Mon, Feb 01, 2016 at 04:40:44PM -0800, Quentin Monnet wrote:
> > > > Proposal: add an option
2016-02-01 18:14 GMT+01:00 Ben Pfaff :
> On Mon, Feb 01, 2016 at 04:40:44PM -0800, Quentin Monnet wrote:
> > Proposal: add an option to ovs-ofctl utility so as to obtain colorized
> output
> > in tty, for easier reading. Currently, only the dump-flows command
> supports
>
Add color output for flow match conditions and flow actions for
ovs-ofctl dump-flows command utility. More fields get colorized, but the
functioning of the `--color` option is left unchanged.
Signed-off-by: Quentin Monnet
---
lib/bundle.c | 18 +-
lib/bundle.h
the “left part” of printed flows (to flow
properties that are always present: `cookie`, `table`, timeouts, etc.).
Signed-off-by: Quentin Monnet
---
lib/dynamic-string.c | 32 +++
lib/dynamic-string.h | 17
lib/learning-switch.c | 2 +-
lib/ofp-print.c
`always`
(force colors), `never` (no colors) or `auto` (use colors only if output
is a tty). If provided without any value, it is the same as `auto`. If
the option is not provided at all, colors are disabled by default.
Quentin Monnet (2):
ovs-ofctl: add color output to dump-flows command
ovs-ofctl
32 matches
Mail list logo
