Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroyed

On Mon, Sep 25, 2017 at 5:01 AM, Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel Angel Ajo > > (Somehow I thought I had acked this, but apparently I only checked it was > ok and never responded) You had acked a previous version of the patch. I

[ovs-dev] 2.7.3 release?

There's some important changes in branch-2.7. Can we do a 2.7.3 release soon? Does anyone have anything they need addressed first? Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

;lrp_networks.ea_s, >>>>>>>>>>>> + out_ports[i]->json_key); >>>>>>>>>>>> + >>>>>>>>>>>> +/* Add flow in table 6 to determin the right output port >>>>>>>>>>>> +

Re: [ovs-dev] [PATCH] ovn-northd: add chassis nonull check

master and branch-2.8. It looks like the patch was sent with a regular mail client, which corrupted the patch. Since it was small i was able to apply it manually. In the future, please post patches using "git send-email". Thanks, -- Russell Bryant ___

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

On Tue, Sep 19, 2017 at 9:38 AM, Russell Bryant <russ...@ovn.org> wrote: > On Mon, Sep 18, 2017 at 7:31 PM, Han Zhou <zhou...@gmail.com> wrote: >> Thanks Russell for the quick work! >> >> On Mon, Sep 18, 2017 at 8:24 AM, Russell Bryant <russ...@ovn.

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

On Mon, Sep 18, 2017 at 7:31 PM, Han Zhou <zhou...@gmail.com> wrote: > Thanks Russell for the quick work! > > On Mon, Sep 18, 2017 at 8:24 AM, Russell Bryant <russ...@ovn.org> wrote: > >> @@ -301,6 +305,22 @@ consider_logical_flow(struct controll

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

On Mon, Sep 18, 2017 at 11:24 AM, Russell Bryant <russ...@ovn.org> wrote: > Discard some OpenFlow flows that will never match. This includes > flows that match on a non-local inport in the ingress pipeline or a > non-local outport in the egress pipeline of a logical switch. &

[ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

. Signed-off-by: Russell Bryant <russ...@ovn.org> Tested-by: Miguel Angel Ajo Pelayo <majop...@redhat.com> --- ovn/controller/binding.c| 29 + ovn/controller/binding.h| 2 +- ovn/controller/lflow.c | 33 ++

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Avoid recomputing when there are in-flight msgs.

On Thu, Sep 14, 2017 at 3:45 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Sep 14, 2017 at 03:06:46PM -0400, Russell Bryant wrote: >> On Mon, May 1, 2017 at 5:42 PM, Ben Pfaff <b...@ovn.org> wrote: >> > On Fri, Apr 21, 2017 at 06:55:27PM -0700, Han Zhou wrote: >&

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Avoid recomputing when there are in-flight msgs.

hou <zhou...@gmail.com> > > Wow, that's a huge performance improvement, really amazing. Thank you > for implementing this! I applied it to master. This patch made it into OVS 2.8. It makes such a big difference to performance that I wonder if it's worth backporting to OV

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

gt; Thanks >> >> >> *Takashi YAMAMOTO <yamam...@ovn.org <yamam...@ovn.org>>* >> >> 2017/09/08 20:54 >> >> 收件人：Russell Bryant <russ...@ovn.org>, >> 抄送：wang.qia...@zte.com.cn, ovs dev <d...@openvs

Re: [ovs-dev] [PATCH] ovsdb-server.1: Fix mention of wrong option.

On Sat, Sep 9, 2017 at 5:28 PM, Ben Pfaff <b...@ovn.org> wrote: > On Sat, Sep 09, 2017 at 05:10:48PM -0400, Russell Bryant wrote: >> The man page referenced a "--no-sync" option. The correct option is >> "--active". >> >> Signed-off-by: Russel

[ovs-dev] [PATCH] ovsdb-server.1: Fix mention of wrong option.

The man page referenced a "--no-sync" option. The correct option is "--active". Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovsdb/ovsdb-server.1.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-server.1.in b/ovsdb/ovsdb-s

Re: [ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

> > On Wed, Sep 6, 2017 at 11:16 PM, Russell Bryant <russ...@ovn.org> wrote: >> >> On Tue, Sep 5, 2017 at 3:45 PM, Lance Richardson <lrich...@redhat.com> >> wrote: >> >> From: "Russell Bryant" <russ...@ovn.org> >> >> To:

Re: [ovs-dev] [PATCH] doc: Fix typo in ovn-sandbox tutorial

On Wed, Sep 6, 2017 at 10:18 AM, Mark Michelson wrote: > On Wed, Sep 6, 2017 at 8:51 AM Jakub Sitnicki wrote: > >> ovn-trace example refers to a non-existent output port. Correct it. >> >> Fixes: 46a2dc58781a ("Document OVN support in ovs-sandbox.") >>

Re: [ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

On Tue, Sep 5, 2017 at 3:45 PM, Lance Richardson <lrich...@redhat.com> wrote: >> From: "Russell Bryant" <russ...@ovn.org> >> To: d...@openvswitch.org >> Cc: lrich...@redhat.com, "Russell Bryant" <russ...@ovn.org> >> Sent: Friday, Sep

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

he...@gmail.com>>* > > 2017/08/25 10:12 > > 收件人：wang.qia...@zte.com.cn, > 抄送：ovs dev <d...@openvswitch.org>, Russell Bryant < > russ...@ovn.org>, xurong00037997 <xu.r...@zte.com.cn>, > zhou.huij...@zte.com.cn > 主题：

Re: [ovs-dev] [PATCH 1/2] windows, python: create a different event for sockets

Acked-by: Russell Bryant <russ...@ovn.org> On Tue, Aug 29, 2017 at 5:09 AM, <aserd...@ovn.org> wrote: > CC: Russell Bryant <russ...@ovn.org>; Lance Richardson <lrich...@redhat.com> > > Can you please take a look? > > Tested-by: Alin Gabriel Serdean <as

Re: [ovs-dev] [PATCH 1/2] .gitignore: Ignore generated file cxxtest.cc.

On Sun, Sep 3, 2017 at 1:33 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Sep 01, 2017 at 09:14:09PM -0400, Russell Bryant wrote: >> Signed-off-by: Russell Bryant <russ...@ovn.org> > > Acked-by: Ben Pfaff <b...@ovn.org> Thanks, I applied this to master an

[ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

s patch extends the "requested-chassis" option to support both the Chassis name or the hostname as a value. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 5 +++-- ovn/ovn-nb.xml | 11 ++- ovn/ovn-sb.xml |

[ovs-dev] [PATCH 1/2] .gitignore: Ignore generated file cxxtest.cc.

Signed-off-by: Russell Bryant <russ...@ovn.org> --- include/openvswitch/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/.gitignore b/include/openvswitch/.gitignore index a948ed453..1e60d40ba 100644 --- a/include/openvswitch/.gitignore +++ b/include/openv

Re: [ovs-dev] [branch-2.8 2/2] NEWS: Mention ct() API change that will arrive in the next major release.

On Thu, Aug 31, 2017 at 4:04 PM, Justin Pettit <jpet...@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- > NEWS | 5 + > 1 file changed, 5 insertions(+) Acked-by: Russell Bryant <russ...@ovn.org>

Re: [ovs-dev] [branch-2.8 1/2] Revert "ofproto-dpif: Mark packets as "untracked" after call to ct()."

proto-dpif-xlate.c | 21 ++--- > tests/ofproto-dpif.at| 10 +- > tests/system-traffic.at | 4 ++-- > utilities/ovs-ofctl.8.in | 10 -- > 6 files changed, 39 insertions(+), 37 deletions(-) Acked-by: Russell Bryant <russ...@ovn.or

Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist

@redhat.com> >> Tested-by: Jean-Tsung Hsiao <jhs...@redhat.com> >> --- > > Acked-by: Flavio Leitner <f...@sysclose.org> Thanks, applied to master and branch-2.8. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.7] Revert "ofproto-dpif-xlate: Fixes for propagating state of conntrack."

se. > > Signed-off-by: Justin Pettit <jpet...@ovn.org> > Reported-by: Russell Bryant <russ...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovn: Support for taas(tap-as-a-service) function

+ table="Logical_switch_Port"/> that indicates where the > + cloned flows come to. > + > + > > > I'm having a hard time understanding this schema. Could you expand on why both a "mirror" and "taas" port type was needed? I was hoping for only a single new port type, "mirror" for example, with options to specify what port it is receiving a mirror of traffic for. Does something like that not express everything needed here? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovn: Check for known logical switch port types.

sbrec_port_binding_set_options(op->sb, ); > smap_destroy(); > +if (!ovn_is_known_nb_lsp_type(op->nbsp->type)) { > +VLOG_WARN("Unknown port type '%s' set on logical switch > '%s'. " > +

Re: [ovs-dev] [PATCH v2] ovn: Fix BFD error config on gateway

t; +as hv1 ovs-appctl netdev-dummy/receive hv1-vif1 $packet >> + >> +# Send ARP reply from outside1 back to the router >> +# XXX: note, we could avoid this if we plug this port into a netns >> +# and setup the IP address into

Re: [ovs-dev] [PATCH] windows, python: set the reset event to automatic

On Tue, Aug 22, 2017 at 8:41 AM, Alin Balutoiu <abalut...@cloudbasesolutions.com> wrote: > Comments answered inline. > > Thanks, > Alin Balutoiu. > >> -Original Message----- >> From: Russell Bryant [mailto:russ...@ovn.org] >> Sent: Tuesday, August 22, 20

Re: [ovs-dev] [PATCH] windows, python: Fix event type returned from poller

call will raise an exception if WAIT_FAILED is returned. This case is > treated by > the try/except block around the WaitForMultipleObjects function. > > Thanks, > Alin Balutoiu. > >> -Original Message- >> From: Russell Bryant [mailto:russ...@ovn.org] >> Sent: Tu

Re: [ovs-dev] [PATCH] windows, python: set the reset event to automatic

gt; # server handle we have to issue a disconnect before closing > -- > 2.10.0.windows.1 > _______ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] windows, python: Remove code duplication in send/recv functions

gt; python/ovs/stream.py | 78 > > 1 file changed, 36 insertions(+), 42 deletions(-) Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list d...@openvswitch.org htt

Re: [ovs-dev] [PATCH] windows, python: Fix event type returned from poller

[retval] in self.wlist: > +revent = POLLOUT > +else: > +revent = POLLERR > + > +return [(events[retval], revent)] > else: > if timeout == -1: > # epoll uses -1 for infinite timeout, se

Re: [ovs-dev] [PATCH] ovn: support requested-chassis option for logical switch ports

ce Richardson <lrich...@redhat.com> > > This seems reasonable to me. > > Do you think you could add a little more information to the > documentation, about the intended use of this feature? It's nice to > have that kind of information at hand to help readers to understand the >

Re: [ovs-dev] [PATCH] ovn: support requested-chassis option for logical switch ports

> process of migrating. > > This would also allow (with some additional work) RBAC to be applied > to the Port_Binding table for additional security. > > Signed-off-by: Lance Richardson <lrich...@redhat.com> Acked-by: Russell Bryant <russ...@ovn.org> but since I talked to yo

Re: [ovs-dev] [PATCH v2 2/2] python: Force file system encoding on cmdline args

gt; v2: No changes. > --- > tests/test-ovsdb.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks for the fixes! I've applied these to master, branch-2.8, and branch-2.7. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] pwclient XML errors and form feeds

On Tue, Aug 15, 2017 at 9:15 AM, Aaron Conole wrote: > Hi Mark, > > Mark Michelson writes: > >> Earlier today on IRC I brought up an error I had while attempting to use >> pwclient to get a patch from patchwork. Here [1] is the pastebin I linked >> to. At

Re: [ovs-dev] [PATCH v2] ovn: Support for taas(tap-as-a-service) function

e */ > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_PRE_LB, 65534, > + "flags.cloned_flow == 1", "drop;"); > + ovn_lflow_add(lflows, od, S_SWITCH_OUT_PRE_ACL, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_PRE_STATEFUL, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_LB, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_ACL, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_QOS_MARK, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_STATEFUL, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_PORT_SEC_IP, 65534, > + "flags.cloned_flow == 1", "drop;"); > +ovn_lflow_add(lflows, od, S_SWITCH_OUT_PORT_SEC_L2, 65534, > + "flags.cloned_flow == 1", "drop;"); > +} > +ds_destroy(); > +ds_destroy(); > +} > +static void > build_lswitch_flows(struct hmap *datapaths, struct hmap *ports, > struct hmap *lflows, struct hmap *mcgroups) > { > @@ -3502,6 +3830,7 @@ build_lswitch_flows(struct hmap *datapaths, struct > hmap *ports, > build_qos(od, lflows); > build_lb(od, lflows); > build_stateful(od, lflows); > +build_mirror_flows(od, ports, lflows); > } > > /* Logical switch ingress table 0: Admission control framework > (priority > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml > index 31303a8..5fdd045 100644 > --- a/ovn/ovn-nb.xml > +++ b/ovn/ovn-nb.xml > @@ -301,6 +301,20 @@ > > A port to a logical switch on a VTEP gateway. > > + > + mirror > + > +A port indicate the inport of mirrored flows. The user need > to > +create this port in the logical_switch. This port should one > to > +one correspondence with the the tap_flows > + > + > + taas > + > +A port indicate the outport of mirrored flows. The user need > to > +create this port in logical_switch. This port should one to > +one correspondence with the the tap_service. > + > > > > @@ -445,6 +459,61 @@ >interface, in bits. > > > + > + > + > + These options apply when is > + mirror. > + > + > + > + Required. The of the + table="Logical_switch_Port"/> that indicates where the > + cloned flows come from. > + > + > + > + Required. The of the + table="Logical_switch_Port"/> with type taas. > + > + > + > + > +This option indicates whitch direction(from-port/to-port/all) > of > +packet will be cloned to the taas-port. The directions are > defined > +as follow: > + > + > +from-port > + > + The packets from this port will be cloned to specified > mirror > + port. > + > +to-port > + > + The packets to this port will be cloned to specified mirror > + port. > + > +both > + > + The packets both from and to this port will be cloned to > + specified mirror port. > + > + > + > + > + > + > + > + These options apply when is > taas. > + > + > + > + Required. The of the + table="Logical_switch_Port"/> that indicates where the > + cloned flows come to. > + > + > > > > -- > 1.8.3.1 > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Mark packets as "untracked" after call to ct().

>> table=1,priority=1,action=drop >> >> @@ -2295,7 +2295,7 @@ dnl Egress pipeline >> dnl - Allow all connections from LOCAL port (commit and skip to output) >> dnl - Allow other established connections to go through conntracker using >> dnl output port as a connection t

Re: [ovs-dev] [PATCH] sandbox: Add ports to br-int in ovn-setup.

On Thu, Aug 10, 2017 at 4:43 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Aug 10, 2017 at 04:20:23PM -0400, Russell Bryant wrote: >> ovs-sandbox comes with a script to quickly set up a simple >> OVN configuration, ovn-setup.sh. This script set up config in the OVN &

[ovs-dev] [PATCH] sandbox: Add ports to br-int in ovn-setup.

show" output as well, to follow the existing "ovn-nbctl show" output. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tutorial/ovn-setup.sh | 8 1 file changed, 8 insertions(+) diff --git a/tutorial/ovn-setup.sh b/tutorial/ovn-setup.sh index dc4c813b1..943ca58ed

Re: [ovs-dev] [PATCH] redhat: add vfio udev rules

On Wed, Aug 9, 2017 at 4:36 PM, Aaron Conole wrote: > This commit builds on the non-root ovs work and adds a udev rule which will > automatically set the group permissions of vfio devices. > > Signed-off-by: Aaron Conole > --- > Systemd folks say that this

Re: [ovs-dev] [PATCH v2] python: make python idl unicode-tolerant

On Wed, Aug 9, 2017 at 3:38 PM, Lance Richardson wrote: > Ensure that JSON is utf-8 encoded and that bytes sent/received on > the stream sockets are in utf-8 form. Add a test case to verify > that unicode data can be sent/received successfully using Python > IDL module. > >

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

On Wed, Aug 9, 2017 at 3:32 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Aug 09, 2017 at 03:27:32PM -0400, Russell Bryant wrote: >> On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson <lrich...@redhat.com> wrote: >> > Ensure that JSON is utf-8 encoded and that bytes se

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote: > Ensure that JSON is utf-8 encoded and that bytes sent/received on > the stream sockets are in utf-8 form. Add a test case to verify > that unicode column data can be sent/received successfully using > Python module. >

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

On Wed, Aug 9, 2017 at 5:01 AM, Miguel Angel Ajo Pelayo wrote: > Nice idea, I have btw some comments/thoughts/questions regarding this: > > 1) Does OVSDB have any heartbeat protocol? (to detect that one northd has > died even during inactive periods). Yes, it does. By

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

On Tue, Aug 8, 2017 at 8:04 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Jul 31, 2017 at 04:53:03PM -0400, Russell Bryant wrote: >> I wanted to share the idea before I code it to see if it makes sense. >> I imagine the patch would be small, though. >> >> We cu

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

\ >> \ >> /* Logical mirror switch egress stages. */\ >> PIPELINE_STAGE(MSWITCH, OUT, FLOW_FILTER, 0, "lms_out_flow_filter")\ >> PIPELINE_STAGE(MSWITCH, OUT, DELIV

Re: [ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: > After this commit, users may start a dpdk-enabled ovs setup as a > non-root user. This is accomplished by exporting the $HOME directory, > which dpdk uses to fill in it's semi-persistent RTE configuration. > > This change

Re: [ovs-dev] [PATCH v4 1/5] redhat: allow arbitrary user:group

On Fri, Aug 4, 2017 at 2:31 PM, Russell Bryant <russ...@ovn.org> wrote: > On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole <acon...@redhat.com> wrote: >> Under rpm based distributions, the only user:group that the rhel daemons run >> as is 'root:root'. This is fin

Re: [ovs-dev] [PATCH v4 1/5] redhat: allow arbitrary user:group

On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: > Under rpm based distributions, the only user:group that the rhel daemons run > as is 'root:root'. This is fine as a default, but as part of a security > procedure, users may want to run as an alternate uid/gid. This

Re: [ovs-dev] [PATCH] tests: fix wrapped comment

On Fri, Aug 4, 2017 at 10:15 AM, Lance Richardson wrote: > Add missing '#' to comment line. > > Signed-off-by: Lance Richardson > --- > It's odd that this doesn't result in failures in more environments, > but it does fail under Alpine Linux. Definitely

Re: [ovs-dev] [PATCH] tests: avoid non-posix options to wc

Port_Binding logical_port=cr-alice | wc --lines], > [0], [0 > +AT_CHECK([ovn-sbctl find Port_Binding logical_port=cr-alice | wc -l], [0], [0 > ]) > > OVN_CLEANUP([hv1],[hv2],[hv3]) > -- > 2.13.3 > > ______

Re: [ovs-dev] 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

: - a new port type of 'mirror' - when port type=mirror, an option to identify which port is being mirrored - (the new part) when port type=mirror, an option that may be used to specify traffic classification for the subset of traffic on a port to mirror, in "match" syntax Do you thi

Re: [ovs-dev] [PATCH] rhel: Use systemd Restart option for ovn-controllers.

oes not change the ovn-controller-vtep service type from >> "simple", however. >> >> Signed-off-by: Mark Michelson <mmich...@redhat.com> > > This looks reasonable to me but I prefer to let Russell apply it since > it's a Red Hat specific change. Thanks for the

Re: [ovs-dev] [PATCH] ovn: Support for taas(tap-as-a-service) function

On Thu, Aug 3, 2017 at 4:44 AM, wrote: > Taas was designed to provide tenants and service providers a means of > monitoring the traffic flowing in their Neutron provisioned virtual > networks. It is useful for network trouble-shooting, security and > analytics. The taas

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

On Tue, Aug 1, 2017 at 9:21 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Wed, Aug 2, 2017 at 1:18 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> On Tue, Aug 1, 2017 at 3:26 PM, Han Zhou <zhou...@gmail.com> wrote: >> > >> >

Re: [ovs-dev] RFC: publishing per-release roadmaps

that is subject to change if features miss the release schedule. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] RFC: Let's branch for 2.8 today

; > The primary argument in favor of branching quickly is to keep to a > regular release cadence. My understanding is that multiple downstream > projects rely on prompt Open vSwitch releases. (This is mainly based on > speaking to Russell Bryant at Red Hat; he can fill in the details if >

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

On Tue, Aug 1, 2017 at 3:26 PM, Han Zhou <zhou...@gmail.com> wrote: > > > On Tue, Aug 1, 2017 at 9:19 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> Add native support for active-standby HA in ovn-northd by having each >> instance attempt to acquire an O

Re: [ovs-dev] [PATCH] rhel: Fix typo in README.RHEL.rst

(-) Thanks, applied to master. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

Add native support for active-standby HA in ovn-northd by having each instance attempt to acquire an OVSDB lock. Only the instance of ovn-northd that currently holds the lock will make active changes to the OVN databases. Signed-off-by: Russell Bryant <russ...@ovn.org> ---

Re: [ovs-dev] How to tell which code is for userspace

rest is userspace (with the exception of the Windows datapath code). -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC] Basic active-active HA for ovn-northd

On Tue, Aug 1, 2017 at 8:06 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Tue, Aug 1, 2017 at 4:25 PM, Numan Siddique <nusid...@redhat.com> wrote: >> >> >> >> On Tue, Aug 1, 2017 at 5:00 AM, Han Zhou <zhou...@gmail.com> wrote: >

[ovs-dev] [RFC] Basic active-active HA for ovn-northd

an improvement over requiring something like Pacemaker? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/5] Automatically verify that OVS header files work OK in C++ also.

On Mon, Jul 31, 2017 at 4:33 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Jul 31, 2017 at 01:05:32PM -0700, Ben Pfaff wrote: >> On Mon, Jul 31, 2017 at 03:50:59PM -0400, Russell Bryant wrote: >> > On Sun, Jul 30, 2017 at 10:54 PM, Ben Pfaff <b...@ovn.org> wrote: &

Re: [ovs-dev] [PATCH 5/5] Add 'extern "C"' for all relevant public header files, plus a build check.

type-props.h | 8 > include/openvswitch/types.h | 8 > include/openvswitch/uuid.h | 8 > 21 files changed, 181 insertions(+) Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/5] Automatically verify that OVS header files work OK in C++ also.

) > + AC_REQUIRE([OVS_ENABLE_WERROR]) > + if test $enable_Werror = yes; then > + AC_LANG_PUSH([C++]) > + AC_COMPILE_IFELSE( > + [AC_LANG_PROGRAM([[#include > +]],)], > + [enable_cxx=:], > + [enable_cxx=false]) > + AC_LANG_POP([C++]) &g

Re: [ovs-dev] [PATCH 3/5] ofp-util: Avoid C++ keyword 'public' in name of struct member.

b/ofp-util.c | 26 +- > ofproto/connmgr.c | 14 +++--- > ofproto/fail-open.c| 2 +- > ofproto/ofproto-dpif-xlate.c | 14 +++--- > ofproto/ofproto-dpif.c | 8 > 7 files changed, 35 insertio

Re: [ovs-dev] [PATCH 2/5] util: Add C++ compatible definition of PADDED_MEMBERS.

On Sun, Jul 30, 2017 at 10:54 PM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > include/openvswitch/util.h | 12 > 1 file changed, 12 insertions(+) Acked-by: Russell Bryant <russ...@ovn.org> _

Re: [ovs-dev] [PATCH 1/5] ofp-actions: Add casts to placate C++ compilers.

- > 1 file changed, 6 insertions(+), 5 deletions(-) Acked-by: Russell Bryant <russ...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovn: Restrict encap modification to its creating chassis

On Thu, Jul 27, 2017 at 2:34 PM, Mark Michelson wrote: > This patch extends RBAC restrictiveness of the encap table in > the ovn southbound database by only allowing modification by the > chassis that created the encap. > > Signed-off-by: Mark Michelson

Re: [ovs-dev] [PATCH v2 3/3] ovn: Update ovn-nbctl manpage with DHCP lsp commands.

On Wed, Jul 26, 2017 at 5:28 PM, Mark Michelson wrote: > This adds the appropriate manpage entries for ovn-nbctl for > > lsp-set-dhcpv4-options > lsp-get-dhcpv4-options > lsp-set-dhcpv6-options > lsp-get-dhcpv4-options > > Signed-off-by: Mark Michelson >

Re: [ovs-dev] [PATCH v2] ovn: Restrict encap modification to its creating chassis

On Wed, Jul 26, 2017 at 5:05 PM, Mark Michelson wrote: > This patch extends RBAC restrictiveness of the encap table in > the ovn southbound database by only allowing modification by the > chassis that created the encap. > > Signed-off-by: Mark Michelson

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

On Tue, Jul 18, 2017 at 2:05 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil > > This change adds commands to set, get and delete gateway chassis > for logical router port. > > Signed-off-by: Venkata Anil Kommaddi > --- >

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On Wed, Jul 26, 2017 at 8:28 PM, Russell Bryant <russ...@ovn.org> wrote: > On Wed, Jul 26, 2017 at 5:45 PM, Joe Stringer <j...@ovn.org> wrote: >> On 26 July 2017 at 13:32, Russell Bryant <russ...@ovn.org> wrote: >>> On Wed, Jul 26, 2017 at 4:29 PM, Lance Richard

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On Wed, Jul 26, 2017 at 5:45 PM, Joe Stringer <j...@ovn.org> wrote: > On 26 July 2017 at 13:32, Russell Bryant <russ...@ovn.org> wrote: >> On Wed, Jul 26, 2017 at 4:29 PM, Lance Richardson <lrich...@redhat.com> >> wrote: >>>> From: "Russell Bryan

Re: [ovs-dev] [PATCH] ovn-northd: Optimize acl of localnet-port

On Sun, Jul 9, 2017 at 9:51 PM, wrote: > Localnet port is not an endpoint, and have no security requirements > to use localnet port at present. So, for performance consideration, we > could do not use ct for localnet port. > > The more specific discussion can be found

Re: [ovs-dev] [PATCH 4/4] checkpatch: Print commit hashes and names.

On Fri, Jul 14, 2017 at 6:57 AM, Ilya Maximets wrote: > It's better to see real commits instead of 'HEAD~n'. > > Signed-off-by: Ilya Maximets > --- > utilities/checkpatch.py | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-)

Re: [ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

On Wed, Jul 26, 2017 at 4:29 PM, Lance Richardson <lrich...@redhat.com> wrote: >> From: "Russell Bryant" <russ...@ovn.org> >> To: d...@openvswitch.org >> Sent: Thursday, 20 July, 2017 8:23:21 PM >> Subject: [ovs-dev] [PATCH] docs: Refer to

Re: [ovs-dev] [PATCH] ovn: Restrict encap modification to its creating chassis

ed this encap. >> + >> >> >> >> diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c >> index 5c3403266..669d47495 100644 >> --- a/ovn/utilities/ovn-sbctl.c >> +++ b/ovn/utilities/ovn-sbctl.c >> @@ -571,6 +571,7 @@ cmd_chassis_add(struct ctl_context *ctx) >> sbrec_encap_set_type(encaps[i], encap_type); >> sbrec_encap_set_ip(encaps[i], encap_ip); >> sbrec_encap_set_options(encaps[i], ); >> +sbrec_encap_set_name(encaps[i], ch_name); >> i++; >> } >> sset_destroy(_set); >> -- >> 2.13.3 >> >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > > Applied the patch, tried a few things, works as expected. LGTM! > > Acked-by: Lance Richardson <lrich...@redhat.com> > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovn-controller: avoid null ptr dereference

On Wed, Jul 26, 2017 at 3:47 PM, Lance Richardson wrote: > Avoid null pointer dereference in fdb_calculate_active_tunnels() > when integration bridge isn't present. This is easily encountered > by executing "make sandbox SANDBOXFLAGS=--ovn". > > Fixes: 3475695ea61c ("ovn:

[ovs-dev] Revisit OVN meeting schedule?

that rotate each week. I can work out a proposal here, but let's see what people think of #1 first. Please share your thoughts. Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson.

On Tue, Jul 25, 2017 at 3:40 PM, Russell Bryant <russ...@ovn.org> wrote: > Mark authored commit 747c31c9. > > Signed-off-by: Russell Bryant <russ...@ovn.org> I went ahead and applied this when applying another patch from Mark. _

Re: [ovs-dev] [PATCH] stream-ssl: Fix memory leak in error scenario

> non-existent certificate, private key, and CA cert files. > > This patch fixes the problem by freeing 'name' in the error label. > > Signed-off-by: Mark Michelson <mmich...@redhat.com> Thanks! I applied this to master. I also applied a patch adding your name to the A

[ovs-dev] [PATCH] AUTHORS.rst: Add Mark Michelson.

Mark authored commit 747c31c9. Signed-off-by: Russell Bryant <russ...@ovn.org> --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 177cef8fd..21a68c140 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -208,6 +208,7 @@ Mark D

Re: [ovs-dev] [PATCH] ovn-architecture: Remove outdated comment.

Thanks, applied to master. On Tue, Jul 25, 2017 at 8:45 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > Acked-by: Miguel Angel Ajo <majop...@redhat.com> > > On Mon, Jul 24, 2017 at 10:53 PM, Russell Bryant <russ...@ovn.org> wrote: >> >>

[ovs-dev] [PATCH] ovn-architecture: Remove outdated comment.

This outdated comment said that support for hardware gateways that support the vtep schema would come later. This was actually implemented a long time ago. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/ovn-architecture.7.xml | 3 +-- 1 file changed, 1 insertion(+), 2 del

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovs-vswitchd timeout to 5 minutes

med out. Terminating. >> >> The 5 minutes setting has been observed to work on a system where 400G >> of hugepages were allocated. >> >> Signed-off-by: Aaron Conole <acon...@redhat.com> > > LGTM > > Reviewed-by: Timothy Redaelli <tredae...@redhat.com

[ovs-dev] [PATCH] docs: Refer to correct package name for sphinx theme.

Update the log message emitted when the OVS sphinx theme is not found to reference the name of the package to be installed via pip: ovs-sphinx-theme. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [ovs-dev] [PATCH] rhel: Fix creation of symlink for ocf script

dora >> packager") >> > >> > Signed-off-by: Timothy Redaelli <tredae...@redhat.com> >> > --- >> >> LGTM >> > > LGTM. > Acked-by: Numan Siddique <nusid...@redhat.com> > > > >> >> Reviewed-b

Re: [ovs-dev] [PATCH 1/2] NEWS: Add OVN L3 Gateway HA.

Thanks for the review. I applied this to master. Patch 2 of this series needs a review, as well. On Wed, Jul 19, 2017 at 12:50 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > Acked-by: Miguel Angel Ajo <majop...@redhat.com> > > El 16 jul. 2017 9:56 p. m., &

Re: [ovs-dev] [PATCH] ovn-architecture: Add notes on L3 gateway HA.

Thanks for the review. I applied this to master. On Wed, Jul 19, 2017 at 4:13 AM, Miguel Angel Ajo Pelayo <majop...@redhat.com> wrote: > Sounds great, thank you! > > Acked-by: Miguel Angel Ajo <majop...@redhat.com> > > On Sun, Jul 16, 2017 at 10:09 PM, Russell Bry

Re: [ovs-dev] [PATCH v1 4/4] ovn: l3ha truncate log file in tests before action starts

th applying patch 3 as it is to make the test more reliable, can you expand on why you had to filter out packets? Why can't we have the test know exactly what packets to expect? -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v6 1/1] ovn: l3ha, CLI for logical router port gateway chassis

On Mon, Jul 17, 2017 at 8:01 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil > > This change adds commands to set, get and delete gateway chassis > for logical router port. > > Signed-off-by: Venkata Anil Kommaddi > --- >

[ovs-dev] [PATCH] ovn-architecture: Add notes on L3 gateway HA.

Add some comments to the ovn-architecture document that distributed gateway ports can also be made highly available. Provide a brief overview of the approach and point to the gateway HA design document for a more detailed discussion of the approach taken. Signed-off-by: Russell Bryant <r

[ovs-dev] [PATCH 2/2] docs: Note currently used L3 gateway HA approach.

with an additional patch to describe the current L3 gateway HA implementation in the ovn-architecture document. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Documentation/topics/high-availability.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/topic

[ovs-dev] [PATCH 1/2] NEWS: Add OVN L3 Gateway HA.

Signed-off-by: Russell Bryant <russ...@ovn.org> --- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index f2e453a61..d6926aa71 100644 --- a/NEWS +++ b/NEWS @@ -45,6 +45,9 @@ Post-v2.7.0 * "ovn-sbctl lflow-list" can now print OpenFlow flows

Re: [ovs-dev] Fix up to the ovn-northd sync

On Sun, Jul 16, 2017 at 1:17 PM, Russell Bryant <russ...@ovn.org> wrote: > On Sun, Jul 16, 2017 at 10:24 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> On Fri, Jul 14, 2017 at 10:08 PM Russell Bryant <russ...@ovn.org> wrote: >>> >>> On Th

Re: [ovs-dev] [PATCH v5 1/1] ovn: l3ha ensure no master bouncing when ovn-controller is restarted

On Fri, Jul 14, 2017 at 9:42 PM, Russell Bryant <russ...@ovn.org> wrote: > On Thu, Jul 13, 2017 at 9:13 AM, Miguel Angel Ajo <majop...@redhat.com> wrote: >> When ovn-controller is restarted, ovn-controller removes the old >> Chassis entry from the SBDB and a new one is i

<    1   2   3   4   5   6   7   8   9   10   >