Re: [ovs-dev] [PATCH] tests: make ovn logical router test case more reliable

2016-06-21 Thread Russell Bryant
plied it to master. -- Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v5 2/2] ovn: Apply ACL changes to existing connections.

2016-06-17 Thread Russell Bryant
09c8-d179-4915-9eb2-f53426ae16dd" && ip4 && tcp && tcp.dst == 22)), action=(ct_commit(ct_label=0/1); next;) table=1( ls_out_acl), priority= 2001, match=((!ct.est || (ct.est && ct_label[0] == 1)) && (outport == "0a7409c8-d179-4915-9eb2-f53426a

[ovs-dev] [PATCH v5 0/2] ovn: Apply ACL changes to existing connections.

2016-06-17 Thread Russell Bryant
t it is only setting 1 bit of ct_label. - This version now has all the changes requested by Justin Pettit, so is ready for his review. Russell Bryant (2): ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action. ovn: Apply ACL changes to existing connections. ovn/lib/actions.c

[ovs-dev] [PATCH v5 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-06-17 Thread Russell Bryant
s in: actions=ct(commit,zone=NXM_NX_REG5[0..15],exec(set_field:0x1->ct_label)) A future commit will make use of this feature. Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Ben Pfaff <b...@ovn.org> --- ovn/lib/actions.c | 130 +++

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-10 Thread Russell Bryant
On Fri, Jun 10, 2016 at 4:38 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Jun 09, 2016 at 04:07:13AM -0400, Russell Bryant wrote: > > I uploaded "2.6.0.dev1". This was to enable OpenStack CI to start > running > > tests using the version of the Python

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-10 Thread Russell Bryant
On Thu, Jun 9, 2016 at 11:04 PM, Joe Stringer <j...@ovn.org> wrote: > On 9 June 2016 at 08:50, Terry Wilson <twil...@redhat.com> wrote: > > On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant <russ...@ovn.org> wrote: > >> The real solution to making this less aw

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix flake8 errors.

2016-06-10 Thread Russell Bryant
On Fri, Jun 10, 2016 at 8:20 AM, Aaron Conole <acon...@bytheb.org> wrote: > Russell Bryant <russ...@ovn.org> writes: > > > On Thu, Jun 9, 2016 at 4:55 PM, Ben Pfaff <b...@ovn.org> wrote: > > > >> On Thu, Jun 09, 2016 at 09:22:10PM +0100, Russell

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-09 Thread Russell Bryant
On Thu, Jun 9, 2016 at 11:50 AM, Terry Wilson <twil...@redhat.com> wrote: > On Thu, Jun 9, 2016 at 3:07 AM, Russell Bryant <russ...@ovn.org> wrote: > > The real solution to making this less awkward would be to split the > Python > > library out of the OVS git t

Re: [ovs-dev] [PATCH] ovn-nb.xml: Fix typo.

2016-06-09 Thread Russell Bryant
On Thu, Jun 9, 2016 at 6:17 PM, Ben Pfaff <b...@ovn.org> wrote: > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswi

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix flake8 errors.

2016-06-09 Thread Russell Bryant
On Thu, Jun 9, 2016 at 4:55 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Jun 09, 2016 at 09:22:10PM +0100, Russell Bryant wrote: > > A previous commit added this file to be checked by flake8, but the file > > failed a number of checks done by the 'hacking' flake8

Re: [ovs-dev] [PATCH] Fix python 3 errors in ovs-bugtool.in

2016-06-09 Thread Russell Bryant
Aaron Rosen <aaronoro...@gmail.com> > Thanks for the patch, Aaron. I actually just pushed an equivalent patch to master a few minutes ago. -- Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix flake8 errors.

2016-06-09 Thread Russell Bryant
On Thu, Jun 9, 2016 at 4:35 PM, Kyle Mestery <mest...@mestery.com> wrote: > On Thu, Jun 9, 2016 at 3:22 PM, Russell Bryant <russ...@ovn.org> wrote: > > A previous commit added this file to be checked by flake8, but the file > > failed a number of checks done by

Re: [ovs-dev] [PATCH 8/8] automake: Add ovs-bugtool.in to flake8-check.

2016-06-09 Thread Russell Bryant
ame set of packages and versions. I have a really old patch that did that. I think it's worth resurrecting it to avoid any more of this problem. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovs-bugtool: Fix flake8 errors.

2016-06-09 Thread Russell Bryant
A previous commit added this file to be checked by flake8, but the file failed a number of checks done by the 'hacking' flake8 plugin. Fixes: b00bdc728e7a ("automake: Add ovs-bugtool.in to flake8-check.") Signed-off-by: Russell Bryant <russ...@ovn.org> --- utilities/bugtool/ovs

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

2016-06-09 Thread Russell Bryant
solution to making this less awkward would be to split the Python library out of the OVS git tree so that it can be released independently of OVS itself. That way a proper verison could be released that includes Python 3 support. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-06-07 Thread Russell Bryant
On Tue, Jun 7, 2016 at 12:44 AM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Jun 02, 2016 at 03:53:46PM -0400, Russell Bryant wrote: > > The automatic flake8 check that runs against Python code has some > > warnings enabled that come from the "hacking" flake8 plu

Re: [ovs-dev] [PATCH] netdev: Fix typo in comment.

2016-06-03 Thread Russell Bryant
On Fri, Jun 3, 2016 at 3:31 PM, Ben Pfaff <b...@ovn.org> wrote: > The name of the macro was wrong. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev ma

Re: [ovs-dev] [PATCH v2] ovn-northd.8.xml: fix sock path of NB and SB database.

2016-06-03 Thread Russell Bryant
48e4 ("Separating OVN NB and SB database processes") > Signed-off-by: Li Wei <l...@cn.fujitsu.com> > Thanks, I applied this patch to master. -- Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v4] ovn: Add software l2 gateway.

2016-06-02 Thread Russell Bryant
port also gets bound to a chassis while a localnet port does not. This binding is not done by ovn-controller. It is left as an administrative function. In the case of OpenStack, the Neutron plugin will do this. Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Ryan Moats &l

[ovs-dev] [PATCH v2] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-06-02 Thread Russell Bryant
The automatic flake8 check that runs against Python code has some warnings enabled that come from the "hacking" flake8 plugin. If it's not installed, the warnings just won't occur until it's run on a system with "hacking" installed. Signed-off-by: Russell Bryant <russ...@o

Re: [ovs-dev] [PATCH] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-05-31 Thread Russell Bryant
On Sat, May 28, 2016 at 1:12 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, May 27, 2016 at 05:09:02PM -0400, Russell Bryant wrote: > > The automatic flake8 check that runs against Python code has some > > warnings enabled that come from the "hacking" flake8 plu

[ovs-dev] [PATCH] INSTALL.md: Note use of "hacking" flake8 plugin.

2016-05-27 Thread Russell Bryant
The automatic flake8 check that runs against Python code has some warnings enabled that come from the "hacking" flake8 plugin. If it's not installed, the warnings just won't occur until it's run on a system with "hacking" installed. Signed-off-by: Russell Bryant <russ...@o

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Russell Bryant
On Fri, May 27, 2016 at 2:02 PM, Aaron Conole <acon...@redhat.com> wrote: > Russell Bryant <russ...@ovn.org> writes: > > > On Tue, May 24, 2016 at 4:35 PM, Aaron Conole <acon...@redhat.com> > wrote: > > > > > > Currently, there is some documenta

Re: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility

2016-05-27 Thread Russell Bryant
lities/ovs-pki.8 \ > utilities/ovs-sim \ > utilities/ovs-sim.1 \ > + utilities/ovs-tcpdump \ > + utilities/ovs-tcpdump.8 \ > utilities/ovs-tcpundump \ > utilities/ovs-tcpundump.1 \ > utilities/ovs-test \ > Can you add the

Re: [ovs-dev] [PATCH v4 2/2] ovn: Apply ACL changes to existing connections.

2016-05-25 Thread Russell Bryant
On Sun, May 22, 2016 at 2:35 AM, Justin Pettit <jpet...@ovn.org> wrote: > > > On May 21, 2016, at 6:35 AM, Russell Bryant <russ...@ovn.org> wrote: > > > > > > On Sat, May 21, 2016 at 2:13 AM, Han Zhou <zhou...@gmail.com> wrote: > > Russell, shall

Re: [ovs-dev] [PATCH v4 2/2] ovn: Apply ACL changes to existing connections.

2016-05-21 Thread Russell Bryant
ns he had. Justin had also requested a change so that we were explicitly setting a single bit of ct_label and not the whole field. There were some issues in that area in the past, but I think they're all resolved now. I should probably go ahead and fix that before posting another revision. -- Russe

Re: [ovs-dev] ovn: is it possible to add validation on acl match

2016-05-20 Thread Russell Bryant
nds good to me. We can watch events in our plugin for when ACL rows get updated and check to see if the error column was set. We can at least log an error on the OpenStack side in that case. It would be asynchronous from the OpenStack API call, so we wouldn't be able to return an error

Re: [ovs-dev] [PATCH 1/2] ovs-dev.py: PEP-8ify.

2016-05-18 Thread Russell Bryant
On Tue, May 17, 2016 at 11:21 PM, Ben Pfaff <b...@ovn.org> wrote: > Do you want to add this script to FLAKE8_PYFILES so that the pep8ness > doesn't accidentally get broken later? > > I didn't read the patches. The changes look fine to me other than the issue you pointed out.

Re: [ovs-dev] [PATCH] ovn: Fix link in tutorial

2016-04-21 Thread Russell Bryant
ur first patch to OVS, I also added your name to the AUTHORS file. Thanks again! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH RFC] ovn: distributed logical port for VM metadata access

2016-04-15 Thread Russell Bryant
f the commit message (include some bits that I > snipped) should go into documentation. > > I feel like this needs to be properly evaluated by someone who > understands OpenStack and Neutron better than me. Maybe Russell? neutron-ovn-metadata would be something we maintain in our Open

Re: [ovs-dev] [PATCH] ovn-tutorial: Update expected output from show commands

2016-04-15 Thread Russell Bryant
tions on the first patch and welcome to the project! From cb39d248b74f97c61109bfbdfc5fbe3e34ad8b55 Mon Sep 17 00:00:00 2001 From: Russell Bryant <russ...@ovn.org> Date: Fri, 15 Apr 2016 16:58:51 -0400 Subject: [PATCH] AUTHORS: Add Flavio Fernandes. Flavio authored commit b3ecab7e5b18756524852ee

Re: [ovs-dev] [PATCH] python: Update Python version checks.

2016-04-15 Thread Russell Bryant
On Fri, Apr 15, 2016 at 3:49 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > On Thu, Apr 14, 2016 at 11:09 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Apr 14, 2016 at 05:00:48PM -0400, Russell Bryant wrote: > >> Instead of checking the raw versio

Re: [ovs-dev] [PATCH v2] ovn-northd: Handle IPv4 addresses with prefixes in lport port security

2016-04-15 Thread Russell Bryant
Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1564414 > > Signed-off-by: Numan Siddique <nusid...@redhat.com> > > Thanks, applied to master. The portsecurity test case seems to be failing after this patch was applied. Numan, can you take a look? -- Russell Bryant __

Re: [ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

2016-04-15 Thread Russell Bryant
On Fri, Apr 15, 2016 at 9:51 AM, Na Zhu <na...@cn.ibm.com> wrote: > Hi Ben, > > How to fix the word-wrapped issue? > I've suggested this a couple of times already, but have you tried posting with git-send-email yet? https://git-scm.com/docs/git-send-email

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Warn if system-id is missing.

2016-04-14 Thread Russell Bryant
On Thu, Apr 14, 2016 at 12:50 AM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Apr 07, 2016 at 11:39:32AM -0400, Russell Bryant wrote: > > If 'system-id' is missing from the Open_vSwitch database, ovn-controller > > will not work. Log a warning if that hap

[ovs-dev] [PATCH] python: Update Python version checks.

2016-04-14 Thread Russell Bryant
Instead of checking the raw version, use the six.PY2 and six.PY3 helpers to determine if Python 2 or Python 3 are in use. In one case, the check was to determine if the Python version was >= 2.6. We now only support >= 2.7, so this check would always be true. Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH v2] ovn: Add software l2 gateway.

2016-04-14 Thread Russell Bryant
On Thu, Apr 14, 2016 at 1:05 AM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Apr 04, 2016 at 05:58:28AM -0700, Russell Bryant wrote: > > This patch implements one approach to using ovn-controller to implement > > a software l2 gateway between logical and physical networks.

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-04-12 Thread Russell Bryant
On Tuesday, April 12, 2016, Joe Stringer <j...@ovn.org> wrote: > On 12 April 2016 at 09:19, Russell Bryant <russ...@ovn.org <javascript:;>> > wrote: > > On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff <b...@ovn.org <javascript:;>> > wrote: > > >

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Russell Bryant
On Tue, Apr 12, 2016 at 2:17 PM, Han Zhou <zhou...@gmail.com> wrote: > > > On Tue, Apr 12, 2016 at 11:02 AM, Russell Bryant <russ...@ovn.org> wrote: > > > > On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel <emspi...@us.ibm.com> > wrote: > > > >

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Russell Bryant
On Tue, Apr 12, 2016 at 1:35 PM, Mickey Spiegel <emspi...@us.ibm.com> wrote: > One comment below. > > -"dev" <dev-boun...@openvswitch.org> wrote: - > > >To: Ben Pfaff <b...@ovn.org> > >From: Russell Bryant > >Sent by: "dev&q

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-12 Thread Russell Bryant
On Mon, Apr 11, 2016 at 12:08 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Apr 05, 2016 at 05:24:19PM -0400, Russell Bryant wrote: > > This feature was originally proposed here: > > > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > > >

Re: [ovs-dev] [PATCH 2/3] expr: Add address set support.

2016-04-12 Thread Russell Bryant
On Mon, Apr 11, 2016 at 11:50 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Apr 05, 2016 at 05:24:18PM -0400, Russell Bryant wrote: > > Update the OVN expression parser to support address sets. Previously, > > you could have a set of IP or MAC addresses in this form: >

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Introduce helpers for looking up datapaths.

2016-04-12 Thread Russell Bryant
mpiler is allowed to assume that > a pointer on which arithmetic is performed is nonnull). > > Signed-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] physical: Add local vars to make physical_run() easier to understand.

2016-04-12 Thread Russell Bryant
ff-by: Ben Pfaff <b...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] A proposal of ovn-scale-test tool

2016-04-12 Thread Russell Bryant
le to generate has been fantastic. I look forward to seeing the project continue! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-04-12 Thread Russell Bryant
On Mon, Apr 11, 2016 at 8:42 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Apr 01, 2016 at 11:20:20AM -0700, Russell Bryant wrote: > > Update the "ct_commit;" logical flow action to optionally take > > one or two parameters, setting the value of "ct_mark&quo

Re: [ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

2016-04-12 Thread Russell Bryant
f it will work with an IBM SMTP server. I do know that it will work with gmail as the SMTP server. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] ovn-controller: Add missing shash_destroy().

2016-04-11 Thread Russell Bryant
On Mon, Apr 11, 2016 at 11:28 AM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Apr 05, 2016 at 05:24:17PM -0400, Russell Bryant wrote: > > expr_symtab_destroy() destroys the contents of the symtab shash, but not > > the shash itself. Add a missing shash_destroy() call

Re: [ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

2016-04-11 Thread Russell Bryant
On Mon, Apr 11, 2016 at 9:47 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > Russell Bryant <russ...@ovn.org> wrote on 04/11/2016 08:40:34 AM: > > > From: Russell Bryant <russ...@ovn.org> > > To: Na Zhu <na...@cn.ibm.com> > > Cc: ovs dev <dev@openvs

Re: [ovs-dev] [PATCH v3 1/1] ovn: Add column enabled to table Logical_Router

2016-04-11 Thread Russell Bryant
lete all the flows > relevant to the logical router from table Logical_Flow. > > Signed-off-by: Na Zhu <na...@cn.ibm.com> I'm unable to apply this patch. It looks to be because it was sent using your IBM mail client. Can you try sending

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Russell Bryant
On Thu, Apr 7, 2016 at 3:52 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 04/07/2016 10:46:45 AM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Date: 04/07/2016 10:

Re: [ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Russell Bryant
or may be I can take a stab ? > Thanks much. > Yes, that issue was the motivation behind this feature. Han Zhou is working on the OpenStack plugin side of this. https://bugs.launchpad.net/networking-ovn/+bug/1560817 -- Russell Bryant ___ dev mail

[ovs-dev] [PATCH v2 2/3] expr: Add address set support.

2016-04-07 Thread Russell Bryant
) A future patch will expose the ability to define address sets for use. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/lflow.c | 2 +- ovn/lib/actions.c | 2 +- ovn/lib/expr.c | 139 ++--- ovn/lib/

[ovs-dev] [PATCH v2 3/3] ovn: Add address_set() support for ACLs.

2016-04-07 Thread Russell Bryant
recreate the above example, you would first create an address set: $ ovn-nbctl create Address_Set name=set1 addresses=10.0.0.5,10.0.0.25,10.0.0.50 Then you can refer to this address set by name in an ACL match: outport == "lp1" && ip4.src == address_set(set1) Signed-off

[ovs-dev] [PATCH v2 0/3] OVN address sets.

2016-04-07 Thread Russell Bryant
v1->v2: - rebase - add docs that I forgot to include in v1. Russell Bryant (3): ovn-controller: Add missing shash_destroy(). expr: Add address set support. ovn: Add address_set() support for ACLs. ovn/controller/lflow.c| 156 +- ovn/

[ovs-dev] [PATCH v2 1/3] ovn-controller: Add missing shash_destroy().

2016-04-07 Thread Russell Bryant
expr_symtab_destroy() destroys the contents of the symtab shash, but not the shash itself. Add a missing shash_destroy() call in lflow_destroy(). Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/lflow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/controller/l

[ovs-dev] [PATCH v3 2/2] ovn: Add software l2 gateway.

2016-04-07 Thread Russell Bryant
gets bound to a chassis while a localnet port does not. This binding is not done by ovn-controller. It is left as an administrative function. In the case of OpenStack, the Neutron plugin will do this. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c

[ovs-dev] [PATCH v3 1/2] ovn-controller: Warn if system-id is missing.

2016-04-07 Thread Russell Bryant
If 'system-id' is missing from the Open_vSwitch database, ovn-controller will not work. Log a warning if that happens to make it clear that configuration is incomplete. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/ovn-controller.c | 9 - 1 file chan

Re: [ovs-dev] [PATCH v2] ovn: Add software l2 gateway.

2016-04-06 Thread Russell Bryant
On Wed, Apr 6, 2016 at 5:43 PM, Ramu Ramamurthy <ramu.ramamur...@gmail.com> wrote: > On Mon, Apr 4, 2016 at 5:58 AM, Russell Bryant <russ...@ovn.org> wrote: > > This patch implements one approach to using ovn-controller to implement > > a software l2 gateway between lo

Re: [ovs-dev] [PATCHv2] checkpatch: Don't enforce char limit on tests.

2016-04-06 Thread Russell Bryant
ese. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> @@ -99,14 +105,23 @@ def ovs_checkpatch_parse(text): > co_authors = [] > parse = 0 > current_file = '' > +previous_file = '' > scissors = re.c

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Limit line length to under 80 columns.

2016-04-06 Thread Russell Bryant
On Mon, Mar 28, 2016 at 11:35 PM, Justin Pettit <jpet...@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- > ovn/northd/ovn-northd.c | 34 +++--- > 1 file changed, 19 insertions(+), 15 deletions(-) > Acked-by: Russ

Re: [ovs-dev] [PATCH 2/3] dpctl.man: Fix bolding for flush-conntrack command.

2016-04-06 Thread Russell Bryant
On Mon, Mar 28, 2016 at 11:35 PM, Justin Pettit <jpet...@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- > lib/dpctl.man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Russell Bryant <russ..

Re: [ovs-dev] [PATCH 3/3] ovs-dpctl: Document conntrack "zone" arguments in help output.

2016-04-06 Thread Russell Bryant
On Mon, Mar 28, 2016 at 11:35 PM, Justin Pettit <jpet...@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- > utilities/ovs-dpctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Russell Bryant <russ...

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-06 Thread Russell Bryant
On Tue, Apr 5, 2016 at 5:24 PM, Russell Bryant <russ...@ovn.org> wrote: > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP > addresses

Re: [ovs-dev] [PATCH v2] ovn: Add software l2 gateway.

2016-04-06 Thread Russell Bryant
On Wed, Apr 6, 2016 at 10:49 AM, Han Zhou <zhou...@gmail.com> wrote: > > > On Wednesday, April 6, 2016, Russell Bryant <russ...@ovn.org> wrote: > >> >> >> On Wed, Apr 6, 2016 at 3:10 AM, Han Zhou <zhou...@gmail.com> wrote: >> >>> >

Re: [ovs-dev] [PATCH v2] ovn: Add software l2 gateway.

2016-04-06 Thread Russell Bryant
On Wed, Apr 6, 2016 at 3:10 AM, Han Zhou <zhou...@gmail.com> wrote: > > On Mon, Apr 4, 2016 at 5:58 AM, Russell Bryant <russ...@ovn.org> wrote: > > - Each localnet logical port is implemented as a > pair of > > - patch ports, one in the integ

Re: [ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-06 Thread Russell Bryant
On Tue, Apr 5, 2016 at 10:03 PM, Han Zhou <zhou...@gmail.com> wrote: > > > On Tue, Apr 5, 2016 at 2:24 PM, Russell Bryant <russ...@ovn.org> wrote: > >> +/* Return true if the address sets match, false otherwise. */ > > +static bool > > +addre

[ovs-dev] [PATCH 2/3] expr: Add address set support.

2016-04-05 Thread Russell Bryant
) A future patch will expose the ability to define address sets for use. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/lflow.c | 2 +- ovn/lib/actions.c | 2 +- ovn/lib/expr.c | 139 ++--- ovn/lib/

[ovs-dev] [PATCH 1/3] ovn-controller: Add missing shash_destroy().

2016-04-05 Thread Russell Bryant
expr_symtab_destroy() destroys the contents of the symtab shash, but not the shash itself. Add a missing shash_destroy() call in lflow_destroy(). Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/lflow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovn/controller/l

[ovs-dev] [PATCH 3/3] ovn: Add address_set() support for ACLs.

2016-04-05 Thread Russell Bryant
recreate the above example, you would first create an address set: $ ovn-nbctl create Address_Set name=set1 addresses=10.0.0.5,10.0.0.25,10.0.0.50 Then you can refer to this address set by name in an ACL match: outport == "lp1" && ip4.src == address_set(set1) Signed-off

Re: [ovs-dev] [PATCH] checkpatch: Don't enforce char limit on tests.

2016-04-05 Thread Russell Bryant
ese. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> Some thoughts below ... --- > utilities/checkpatch.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/utilities/checkpatch.py b/utilities/

Re: [ovs-dev] [PATCH v2 1/1] ovn: Add column enabled to table Logical_Router

2016-04-05 Thread Russell Bryant
ical_Router" db="OVN_Northbound"/> rows in the db="OVN_Northbound"/> database that do not have table="Logical_Router" db="OVN_Northbound"/> set to false This should be line wrapped. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/1] ovn: Add column enabled to table Logical_Router

2016-04-05 Thread Russell Bryant
0644 > --- a/ovn/ovn-nb.ovsschema > +++ b/ovn/ovn-nb.ovsschema > @@ -1,7 +1,7 @@ > { > "name": "OVN_Northbound", > "version": "2.0.2", > -"cksum": "4289495412 4436", > +"cksum": "1227843805 4513", > "tables": { > "Logical_Switch": { > "columns": { > You should update the schema version, as well. I would make it "2.1.0". -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Is there any release plan about networking-ovn

2016-04-05 Thread Russell Bryant
sts.openstack.org/pipermail/openstack-dev/2016-April/091289.html http://releases.openstack.org/newton/schedule.html -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1 RFC] ovn: Support native dhcp using'continuations'

2016-04-04 Thread Russell Bryant
DHCP_OPT_TYPE_UINT16); > > +dhcp_opt_expr_symtab_add_field(_opt_symtab, "lease_time", 51, > > + DHCP_OPT_TYPE_UINT32); > > + dhcp_opt_expr_symtab_add_field(_opt_symtab, "server_id", 54, > > +

[ovs-dev] [PATCH v2] ovn: Add software l2 gateway.

2016-04-04 Thread Russell Bryant
gets bound to a chassis while a localnet port does not. This binding is not done by ovn-controller. It is left as an administrative function. In the case of OpenStack, the Neutron plugin will do this. Signed-off-by: Russell Bryant <russ...@ovn.org> --- v1->v2: - Rebase an

[ovs-dev] [PATCH v4 2/2] ovn: Apply ACL changes to existing connections.

2016-04-01 Thread Russell Bryant
d179-4915-9eb2-f53426ae16dd" && ip4 && tcp && tcp.dst == 22)), action=(ct_commit(ct_label=0); next;) table=1( ls_out_acl), priority= 2001, match=((!ct.est || (ct.est && ct_label[0] == 1)) && (outport == "0a7409c8-d179-4915-9eb2-f53426ae16dd" &

[ovs-dev] [PATCH v4 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-04-01 Thread Russell Bryant
at looks like: actions=ct(commit,zone=NXM_NX_REG5[0..15],exec(set_field:0x1->ct_mark)) Similarly, setting ct_label results in: actions=ct(commit,zone=NXM_NX_REG5[0..15],exec(set_field:0x1->ct_label)) A future commit will make use of this feature. Signed-off-by: Russell Bryant <

[ovs-dev] [PATCH v4 0/2] ovn: Apply ACL changes to existing connections.

2016-04-01 Thread Russell Bryant
ct_commit() logical flow action. - Simplified ct_commit() logical flow action additions as suggested by Ben. - Lots of doc cleanup as suggested by Justin. Russell Bryant (2): ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action. ovn: Apply ACL changes to existing connections. ovn/lib/

Re: [ovs-dev] [PATCH v3 3/3] ovn: Apply ACL changes to existing connections.

2016-04-01 Thread Russell Bryant
On Tue, Mar 29, 2016 at 7:26 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Mar 21, 2016, at 7:54 AM, Russell Bryant <russ...@ovn.org> wrote: > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 2cc9c34..c8cca54 10064

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-04-01 Thread Russell Bryant
this is indeed supported. > Joe has a couple of patches on the list. I checked with on IRC and it sounds like there's still an issue he's working through. Right now I'm planning on holding off on adding that unless those fixes are completed before I post this next revision. -- Russell Bryant _

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-04-01 Thread Russell Bryant
On Wed, Mar 23, 2016 at 4:48 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Mar 21, 2016 at 10:54:58AM -0400, Russell Bryant wrote: > > Update the "ct_commit;" logical flow action to optionally take > > one or two parameters, setting the value of "ct_mark&quo

Re: [ovs-dev] [PATCH v3 1/3] ovn: Update ACL flow docs.

2016-04-01 Thread Russell Bryant
On Wed, Mar 23, 2016 at 4:30 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, Mar 21, 2016 at 10:54:57AM -0400, Russell Bryant wrote: > > Apply some minor updates to the description of flows related to ACLs. > > > > Signed-off-by: Russell Bryant <russ...@ovn.org

Re: [ovs-dev] [PATCH] Fix bug in ovn-ctl argument order

2016-04-01 Thread Russell Bryant
bug in ovn-ctl argument order > > > Sent by: "dev" <dev-boun...@openvswitch.org <javascript:;>> > > > > > > Its the same for me. > > > > > > > > > > > > On Fri, Apr 1, 2016 at 9:03 PM, Russell Bryant <russ...@ovn.org

Re: [ovs-dev] [PATCH] Fix bug in ovn-ctl argument order

2016-04-01 Thread Russell Bryant
This patch made it to patchwork, but not my inbox. Ryan pinged me about it on IRC. I just applied it to master. https://patchwork.ozlabs.org/patch/604889/ -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman

Re: [ovs-dev] [RFC 2/2] ovn: Add minimal software l2 gateway.

2016-04-01 Thread Russell Bryant
On Tue, Mar 29, 2016 at 9:47 PM, Russell Bryant <russ...@ovn.org> wrote: > This patch implements one approach to using ovn-controller to implement > a software l2 gateway between logical and physical networks. > > A new logical port type called "gateway" is introduc

Re: [ovs-dev] [PATCH] util: Remove va_copy() implementation.

2016-03-31 Thread Russell Bryant
-off-by: Ben Pfaff <b...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/4] docs: OVSDB replication design document

2016-03-31 Thread Russell Bryant
ion for 2 nodes instead of at least 3. We're already using at least 3 nodes for HA reasons in all of the environments that I care about for my use cases since we need 3 for other active-active solutions. Do you have a requirement for a 2-node solution? Could you expand on your use case? -- Russ

Re: [ovs-dev] [PATCH v4 0/4] Support native dhcp in ovn controller

2016-03-31 Thread Russell Bryant
Russel for the comments. > > Since most of the dhcp options are common to all the ports of ​a virtual > > network, I was thinking may be it's good to add a new column - > > 'dhcp_options' in Logical_Switch table. This can be used to store all the > > dhcp options

Re: [ovs-dev] [RFC 2/2] ovn: Add minimal software l2 gateway.

2016-03-31 Thread Russell Bryant
On Thu, Mar 31, 2016 at 4:14 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Mar 29, 2016 at 06:47:43PM -0700, Russell Bryant wrote: > > This patch implements one approach to using ovn-controller to implement > > a software l2 gateway between logical and physical networks.

[ovs-dev] missing OVN meeting today

2016-03-31 Thread Russell Bryant
L2 gateway. I posted an alternative implementation of the current milestone that I'd like feedback on. - I still have "address sets" on my plate, but haven't made much progress due to working on other things in the meantime. I still intend to try to knock it out "soon".

Re: [ovs-dev] [PATCH] ovsdb: Improve error message from ovsdb_log_open() open failure.

2016-03-30 Thread Russell Bryant
ILE: create failed (File exists) > which makes more sense. > > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- > ovsdb/log.c | 2 +- > tests/ovsdb-log.at| 2 +- > tests/ovsdb-server.at | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >

Re: [ovs-dev] [PATCH 1/2] ovn: Minor refactoring.

2016-03-30 Thread Russell Bryant
On Wed, Mar 30, 2016 at 8:08 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Mar 29, 2016 at 06:47:42PM -0700, Russell Bryant wrote: > > This commit applies a minor restructuring of this code to put the > > localnet port specific code in its own block. This is mostly to ma

Re: [ovs-dev] [PATCH 1/1] Rationalize ovn-ctl arguments.

2016-03-30 Thread Russell Bryant
On Wed, Mar 30, 2016 at 8:15 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Mar 30, 2016 at 07:56:51PM -0400, Russell Bryant wrote: > > On Wed, Mar 30, 2016 at 2:40 PM, Ben Pfaff <b...@ovn.org> wrote: > > > I'm starting to get really disturbed that ssl isn't the

Re: [ovs-dev] [PATCH 1/1] Rationalize ovn-ctl arguments.

2016-03-30 Thread Russell Bryant
ent that has a value something like > "ptcp:6641" by default and let the caller override the whole thing to > something else. > > I'm starting to get really disturbed that ssl isn't the default here. > We need to add SSL config to these tables. -- Russell Bryant

Re: [ovs-dev] Bit-level setting with ct()

2016-03-30 Thread Russell Bryant
tion only show > setting the whole field through OpenFlow, but I think the code supports > bit-level manipulation. Does that seem correct to you? > > Seems like it was broken. I sent a couple of patches. > In that case, that's why I hadn't added support for it to t

[ovs-dev] [RFC 0/2] ovn: Add minimal software l2 gateway.

2016-03-29 Thread Russell Bryant
of change required to do so. The real code changes here are really quite small. A new port type called "gateway" is introduced that works *very* close to the existing localnet ports. I'm interested in feedback on this alternative approach. Thanks, Russell Bryant (2): ovn: Minor refactor

[ovs-dev] [RFC 2/2] ovn: Add minimal software l2 gateway.

2016-03-29 Thread Russell Bryant
makes OVN use the physical network as the transport between hypervisors instead of tunnels. A gateway port still uses tunnels between all hypervisors, and packets only go to/from the specified physical network as needed via the chassis the gateway port is bound to. Signed-off-by: Russell Br

[ovs-dev] [PATCH 1/2] ovn: Minor refactoring.

2016-03-29 Thread Russell Bryant
This commit applies a minor restructuring of this code to put the localnet port specific code in its own block. This is mostly to make a future patch easier to read. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/patch.c | 44 ++---

Re: [ovs-dev] [PATCH v3 2/3] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

2016-03-29 Thread Russell Bryant
On Tue, Mar 29, 2016 at 5:00 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Mar 28, 2016, at 2:33 PM, Russell Bryant <russ...@ovn.org> wrote: > > > > > > Yeah, no tests. I honestly wasn't sure how to test it since we can't > use ct() in the tes

<    2   3   4   5   6   7   8   9   10   11   >