o shortening the period between branch creation and release to
> account for the shorter development cycle.
>
> This patch also adjusts the release cycle target dates to indicate
> February as the target release month instead of March.
On Fri, Oct 07, 2016 at 09:00:13AM -0700, Ben Pfaff wrote:
> Also, it is not necessary to specify that the name must be unique because
> the schema documentation generator does that for us.
>
> Reported-by: Kevin Lin
> Reported-at: http://openvswitch.org/pipermail/dev/2016-Octo
Thanks a lot. I have only a few style fixes for this. May I have a
Signed-off-by?
Thanks,
Ben.
On Thu, Oct 06, 2016 at 04:22:19PM -0700, Ethan Rahn wrote:
> Third time is the charm :) Sent via git send-email this time around.
> Thanks for your patience and sorry for the trouble.
>
On Wed, Nov 02, 2016 at 09:28:44AM -0700, Ben Pfaff wrote:
> On Thu, Oct 06, 2016 at 03:53:12AM -0700, Gurucharan Shetty wrote:
> > OVN currently supports multiple gateway routers (residing on
> > different chassis) connected to the same logical topology.
> >
> > When
a bit. For e.g., if we have a source IP network based rule added,
> to decide a particular gateway router as a next hop, we should add rules at
> a higher priority for all the connected routes to make sure that east-west
> traffic is not effected in the policy based routing table itself.
et delivered does not have any tags in it.
>
> Reported-by: Dustin Spinhirne
> Signed-off-by: Gurucharan Shetty
Sorry about the delay in review. (It's too bad we didn't get this into
2.6.1, but there's always 2.6.2.)
Acked-by: Ben Pfaff
On Wed, Nov 02, 2016 at 08:38:29PM +0530, Babu Shanmugam wrote:
> When a Logical_Switch's qos_rule does not have a match set, the rule should
> apply for all the logical ports in that switch.
>
> Signed-off-by: Babu Shanmugam
I don't think this is really a bug fix, since the documentation for th
On Thu, Oct 27, 2016 at 09:45:42PM +, Alin Serdean wrote:
> Skip symlinks checks on Windows.
>
> Signed-off-by: Alin Gabriel Serdean
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Nov 01, 2016 at 08:26:06PM -0700, Ben Pfaff wrote:
> +/* Replace original file by the temporary file.
> + *
> + * We support two strategies:
> + *
> + * - The preferred strategy is to rename the temporary file over the
> + * original
lesser one was that it had more duplicate code than needed and extra
#ifdefs made it harder than necessary to test the "Windows" approach on
Unix-like systems. I've fixed that too.
So, here's my proposed version of the patch. What do you think?
Thanks,
Ben.
--8<--
On Tue, Nov 01, 2016 at 03:44:13PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Nov 01, 2016 at 03:44:12PM -0700, Justin Pettit wrote:
> Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Oct 27, 2016 at 08:33:35PM +, Alin Serdean wrote:
> This patch adds the offline compacting (ovsdb-tool compact) to be run on
> Windows.
>
> On Windows we are missing "--run" so in return we start ovsdb-server,
> run the ovsdb-client dump command and after issue a command to the
> ovsdb
On Fri, Oct 21, 2016 at 07:00:22PM -0500, Flavio Fernandes wrote:
> Include the ovn-trace binary and it's man page in ovn-common package
>
> Fixes: 4acd1e87a8bf ("ovn-trace: New utility.")
> Fixes: f448e5a4bb1f ("rhel: Include ovn-trace in ovn-common package")
> Signed-off-by: Flavio Fernandes
T
On Fri, Oct 21, 2016 at 01:36:36PM -0700, Darrell Ball wrote:
> The first patch fixes arping from vtep-gw physical ports
> and the code change was done by Ramu Ramamurthy.
>
> The second patch adds additional comments regarding arp responders
> in ovn. This is intended to aid in understanding and
On Tue, Nov 01, 2016 at 04:19:59PM -0500, Flavio Fernandes wrote:
> Avoid leak due to missing ds_destroy in build_acl for non-stateful
> drop action.
>
> Found via inspection. I do not know that this fixes a common leak.
>
> Signed-off-by: Flavio Fernandes
Thanks! Applied to master and branch
On Tue, Oct 25, 2016 at 04:31:15PM -0400, Lance Richardson wrote:
> > From: "Lance Richardson"
> > To: dev@openvswitch.org
> > Sent: Tuesday, October 25, 2016 12:38:49 PM
> > Subject: [ovs-dev] [PATCH 2/2] ovn-southbound: implement read-only
> > connection support
> >
> > Add a connection table
On Tue, Oct 25, 2016 at 12:38:48PM -0400, Lance Richardson wrote:
> Adds a new "read_only" column for remote connections.
>
> Operations that would alter the state of the database are not
> permitted on connections for which the "read_only" column is set
> to "true".
>
> Signed-off-by: Lance Rich
On Mon, Oct 31, 2016 at 05:23:25PM -0700, Joe Stringer wrote:
> On 31 October 2016 at 14:33, Ben Pfaff wrote:
> > On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote:
> >> On 31 October 2016 at 13:23, Ben Pfaff wrote:
> >> > Some datapaths do not sup
On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote:
> On 31 October 2016 at 13:23, Ben Pfaff wrote:
> > Some datapaths do not support the ct action, and others support only a
> > subset of its features. Until now, it has been difficult to tell why a
> > parti
I can't get any of the versions of this patch to apply. Maybe you
should just send it as a Github pull request.
On Thu, Oct 27, 2016 at 03:21:49PM +, Waizel, Ariel wrote:
> OK I tried again - I think the tabs are OK, but not sure about the extra new
> lines... if there's a problem I'll try o
onntrack capability
and user may be unaware of the stateful feature of OVS.
Signed-off-by: Han Zhou
Signed-off-by: Ben Pfaff
---
FAQ.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/FAQ.rst b/FAQ.rst
index de7aaf7..4ee4c2b 100644
--- a/FAQ.rst
+++ b/FAQ.rst
@@ -886,7 +8
/2016-October/023060.html
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 7374ccc..3a9f74a 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -4152,10 +4152,13
if you want to wait to apply it before releasing.
>
> Just to confirm, this is the patch labeled "ifnotifier: do not wake up when
> there is no db connection", correct?
>
> Ben, would you be able to review it?
Done.
___
dev
On Tue, Oct 25, 2016 at 03:44:43PM -0200, Thadeu Lima de Souza Cascardo wrote:
> When bridge uses the interface notifier, it wakes up until a reconfiguration
> takes place. However, if there is no connection or a lock contention to the
> database, the check for reconfiguration will not take place.
Do you have a planned use for it? I'm more interested in infrastructure
improvements when there's a use case.
On Wed, Oct 12, 2016 at 04:33:21PM +0300, Ilya Maximets wrote:
> Hi, Ben.
>
> So, what about this patch? It's still not in mail-list, I guess,
> and still ap
The put_dhcp_opts(v6) logical action didn't really work because ovn-trace
didn't handle DHCP options. This fixes the problem.
This also makes the put_dhcp_opts(v6) logical provide useful tracing output
showing what's happening and the assumptions.
Signed-off-by: Ben Pfaff
---
The put_dhcp_opts(v6) logical action didn't really work because ovn-trace
didn't handle DHCP options. This fixes the problem.
This also makes the put_dhcp_opts(v6) logical provide useful tracing output
showing what's happening and the assumptions.
Signed-off-by: Ben Pfaff
---
Also adjust the indentation of the option explanations so that they line up
better.
Signed-off-by: Ben Pfaff
---
ovn/utilities/ovn-trace.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c
index 3d62cf8
The order of src and dst was swapped both in assignment and reference,
which meant that the result worked OK but was really confusing to try to
extend or modify.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b
Adding ovn-trace calls makes failures easier to understand and diagnose.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 96 +---
1 file changed, 60 insertions(+), 36 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 1d782a3
These actions looked up the MAC binding but failed to update eth.dst with
the result.
Signed-off-by: Ben Pfaff
---
ovn/utilities/ovn-trace.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c
index 94321cf..261013b
When ovn-trace is running in daemon mode (with --detach), a trace command
received via unixctl (e.g. "ovs-appctl -t ovn-trace trace ...") should not
cause ovn-trace to exit, but it did. This fixes the problem.
Signed-off-by: Ben Pfaff
---
ovn/utilities/ovn-trace.c | 4 ++--
1 file
On Sat, Oct 22, 2016 at 12:33:13AM +, Mohamed Ibrahem wrote:
> hello guys,
> i have a 4 port switch and the model as follows:
> port 1>> client
> port 2 ,3 and 4 are servers"python -m SimpleHTTPServer 80&"
> i wanna do load balancing with the servers as the virtual IP = 10.0.0.5 and
> virtual
I'll miss the OVN meeting next week because I'll be in Barcelona. Hope
to see some of you there, especially at the OVN party on Tuesday night
(email me if you don't already have invitation).
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org
On Fri, Oct 21, 2016 at 04:38:43PM -0400, Lance Richardson wrote:
> > From: "Ben Pfaff"
> > To: "Russell Bryant"
> > Cc: "ovs dev"
> > Sent: Friday, October 21, 2016 4:33:33 PM
> > Subject: Re: [ovs-dev] ovn: Improving southbound d
On Thu, Oct 13, 2016 at 05:34:22PM +0530, Numan Siddique wrote:
> ovn-controller will translate the "extract_dns_packet" ovn action to
> "controller action with pause flag set.
> For the flows in the table "ls_in_l7_match", ovn-controller will NOT
> translate it into any OF Flow, instead it will
On Fri, Oct 21, 2016 at 04:10:58PM -0400, Russell Bryant wrote:
> On Thu, Oct 20, 2016 at 5:52 PM, Han Zhou wrote:
>
> >
> > On Thu, Oct 20, 2016 at 11:51 AM, Russell Bryant wrote:
> > >
> > > On Thu, Oct 20, 2016 at 1:47 PM, Ben Pfaff wrote:
> > &g
On Thu, Oct 13, 2016 at 07:32:53PM +0530, Numan Siddique wrote:
> We may have to add one more item in the task breakdown list. Please see
> below
>
>
> On Wed, Oct 12, 2016 at 11:21 PM, Russell Bryant wrote:
>
> > Hello, I'm back to looking at southbound database security concerns in
> > OVN.
On Tue, Oct 18, 2016 at 05:16:39PM -0400, Lance Richardson wrote:
> > From: "Ben Pfaff"
> > To: "Lance Richardson"
> > Cc: dev@openvswitch.org, az...@ovn.org, nusid...@redhat.com,
> > bscha...@redhat.com, jpet...@ovn.org, russ...@ovn.org
> > Sen
On Thu, Oct 20, 2016 at 07:53:37AM -0400, Russell Bryant wrote:
> Thanks for taking a look and for the "git am -3" tip. I'll proceed with
> what you've already posted for now.
"git am -3" is like magic. I don't know why it isn't the default.
___
dev ma
On Wed, Oct 19, 2016 at 01:42:50PM -0700, Jarno Rajahalme wrote:
>
> > On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote:
> >
> > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy
> > wrote:
> >> Aligning the 'keys' array seems to have positive performance impact.
> >>
> >> Signed-off-by: Bha
On Tue, Oct 11, 2016 at 12:33:22PM -0700, Andy Zhou wrote:
> Without this fix, the added test will core dump.
>
> Signed-off-by: Andy Zhou
Thanks!
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
On Mon, Oct 17, 2016 at 01:44:03PM -0700, Andy Zhou wrote:
> On Wed, Oct 5, 2016 at 8:16 PM, Ben Pfaff wrote:
>
> > Some upcoming tests will add extra trickiness to the IDL internal graph.
> > This worries me, because the IDL doesn't have any checks for its graph
> &
On Wed, Oct 19, 2016 at 01:32:57PM -0200, Thadeu Lima de Souza Cascardo wrote:
> The missing include was needed for struct in6_addr.
>
> Otherwise, this build failure would occur.
>
> In file included from ovn/lib/actions.c:23:
> ovn/lib/ovn-dhcp.h:163:21: error: field has incomplete type 'struct
On Tue, Oct 18, 2016 at 09:01:11PM +0100, Stephen Fincane wrote:
> On Tue, 2016-10-18 at 12:36 -0700, Ben Pfaff wrote:
> > > + .. note::
> > > + Some legacy documents may exist in other formats. When time
> > allows, these
> > > + should be converted to
On Sat, Oct 08, 2016 at 02:18:00PM +0100, Stephen Finucane wrote:
> We have one for coding and could do with one for docs.
>
> Signed-off-by: Stephen Finucane
...
> +- Use reStructuredText (reST) for all documentation.
> +
> + Sphinx extensions can be used, but only for documentation in the
>
> Signed-off-by: YAMAMOTO Takashi
Good idea.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Oct 18, 2016 at 09:25:25PM +0900, YAMAMOTO Takashi wrote:
> It seems like a non-portable bash extension.
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman
t different
contents."
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Did you read the documentation?
On Tue, Oct 18, 2016 at 09:06:37AM +, zhangyali (D) wrote:
> Thanks, Ben. But another question is which version has supported ECN? Now, I
> have 2.4 version installed, does this version is ok? Or where I could find
> the correct version? Thanks.
>
ne could, for example, add a command-line
option corresponding to each configuration column, with some kind of
convention such as the option affects the remote specified in the most
recent --remote option. There are other possibilities too, of course.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Oct 14, 2016 at 01:11:07PM -0700, Andy Zhou wrote:
> On Fri, Oct 14, 2016 at 11:12 AM, Ben Pfaff wrote:
>
> > The commit that this fixes is from 2009.
> >
> > Reported-by: Kai-Wei Fan
> > Fixes: 9467fe624698 ("Add SSL support to "stream" libr
No, we wouldn't normally add or remove a feature in a release that has
already been made.
If you need this in OVS 2.5, then you can apply the commit locally, with
"git cherry-pick" or similar.
On Mon, Oct 17, 2016 at 06:40:58AM +, Muthukrishnan Thangasamy wrote:
> Dear Be
On Mon, Oct 17, 2016 at 08:22:50AM +, zhangyali (D) wrote:
> I plan to construct a test bed with ovs, but now I encountered a
> problem about if the latest ovs support for ECN (Explicit Congestion
> Notification). Hope I could get your help. Thanks in advance.
OVS can match and set the ECN bit
On Mon, Oct 17, 2016 at 09:14:33AM -0400, Russell Bryant wrote:
> Can we do a 2.6.1 release in the near future? The latest Python commit is
> needed for OpenStack.
I'd support that.
Justin usually makes the releases, and he's traveling on vacation this
week, so we may not hear from him for a whi
The commit that this fixes is from 2009.
Reported-by: Kai-Wei Fan
Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.")
Signed-off-by: Ben Pfaff
---
lib/stream-ssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/stream-ssl.c b/li
On Thu, Oct 13, 2016 at 03:08:46PM -0400, Lance Richardson wrote:
> Doing 'make check TESTSUITEFLAGS="1876-1881"' executes these test
> cases:
> 1876: ovsdb-server/read-only ptcp connection ok
> 1877: ovsdb-server/read-only punix connection ok
> 1878: ovsdb-server/rea
a huge amount of work.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
.
VMware-BZ: 1710701
Signed-off-by: Pravin B Shelar
Acked-by: Ansis Atteka
On Thu, Oct 13, 2016 at 06:06:10AM +, Muthukrishnan Thangasamy wrote:
> Dear Ben ,
>
>
> Thank you for your response.
>
>
> Could you please throw some light on ,any specific r
> > IMO if the functional aspects of these patches work (i.e. the 'dist-docs'
> > target generates sane HTML for all rST files) and we haven't lost any of
> > the raw information then any stylistic issues I may have introduced can be
> > fixed in follow up
On Tue, Oct 04, 2016 at 06:22:22PM -0700, Daniele Di Proietto wrote:
> It is customary to have the vlog module name similar to the filename.
> Plus a following commit will introduce a 'dpdk' module.
>
> Signed-off-by: Daniele Di Proietto
> No functional change.
>
> Signed-off-by: Daniele Di Proietto
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Oct 04, 2016 at 06:22:20PM -0700, Daniele Di Proietto wrote:
> If rte_eal_init() fails, we do not register the DPDK netdev classes,
> therefore it's impossible to reach the classes construct functions.
>
> Signed-off-by: Daniele Di Proietto
Ac
_mutex' in
> dpif-netdev.
>
> Signed-off-by: Daniele Di Proietto
I don't really understand the commit message for that DPDK commit, but
if you're interpreting it correctly then I agree that this is correct
and an improvement.
Acked-by: Ben Pfaff
On Tue, Oct 04, 2016 at 06:22:18PM -0700, Daniele Di Proietto wrote:
> We're in the slowpath. I find it easier to allocate and free memory,
> than to handle snprintf() error condition.
>
> Signed-off-by: Daniele Di Proietto
Ac
gt; the slowpath.
> * We shouldn't abort if we're out of hugepage memory.
> * We should gracefully handle out of memory conditions.
>
> Signed-off-by: Daniele Di Proietto
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Oct 04, 2016 at 06:22:16PM -0700, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
r errors? But that doesn't seem to mesh with the assignment
"error = EOPNOTSUPP;" earlier in netdev_dpdk_set_qos(). But maybe I'm
not familiar enough with how DPDK reports errors.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
off-by: Daniele Di Proietto
I'm glad to see Aaron's ack here.
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
: Daniele Di Proietto
Here's a suggested additional incremental to fold in. Completely
untested.
Acked-by: Ben Pfaff
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 15250dc..6af3ee3 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -504,15 +504,10 @@ dpdk_mp_cre
On Tue, Oct 04, 2016 at 06:22:12PM -0700, Daniele Di Proietto wrote:
> Looks like we forgot to add the copyright headers to netdev-dpdk.h.
> Looking at the contribution history of the file, this commit adds the
> header with Nicira copyright.
>
> Signed-off-by: Daniele Di Proietto
On Tue, Sep 27, 2016 at 04:13:11PM -0300, Thadeu Lima de Souza Cascardo wrote:
> Signed-off-by: Thadeu Lima de Souza Cascardo
Applied to master, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
cu() has failed.
> * During reconfiguration we destroy every thread.
I'd recommend making the comment on dp_netdev_get_pmd() clearer, by
mentioning that it can always return NULL, even with NON_PMD_CORE_ID as
an argument.
Acked-by: Ben Pfaff
_
On Wed, Oct 12, 2016 at 12:00:00AM -0700, Andy Zhou wrote:
> On Wed, Oct 5, 2016 at 8:11 PM, Ben Pfaff wrote:
>
> > At an early point in OVS development, OVS was built with fixed default
> > directories for pidfiles and sockets. This meant that it was necessary to
> > u
On Wed, Oct 12, 2016 at 10:42:36AM -0700, Ben Pfaff wrote:
> On Tue, Oct 11, 2016 at 04:58:26PM -0700, Andy Zhou wrote:
> > On Wed, Oct 5, 2016 at 6:28 PM, Ben Pfaff wrote:
> >
> > > When I ran "make check-valgrind -j10" and the testsuite needed to be
> >
On Tue, Oct 11, 2016 at 04:58:26PM -0700, Andy Zhou wrote:
> On Wed, Oct 5, 2016 at 6:28 PM, Ben Pfaff wrote:
>
> > When I ran "make check-valgrind -j10" and the testsuite needed to be
> > rebuilt, two copies of it were rebuilt in parallel and sometimes they
> &g
anybody has already started and working on this do please let me
> know, to avoid duplication of work.
This was implemented in 2014.
commit 2a6f78e0fae96b07b5f328ee071652f4a525b16f
Author: Ben Pfaff
Date: Wed Feb 26 11:12:57 2014 -0800
ofproto: Send port status message for port-mods,
On Tue, Oct 11, 2016 at 04:27:40PM -0700, Andy Zhou wrote:
> On Fri, Oct 7, 2016 at 10:04 AM, Ben Pfaff wrote:
>
> > Also vertical tabs, whatever those are.
> >
> > Signed-off-by: Ben Pfaff
> >
>
> Acked-by: Andy Zhou
Thanks, I
On Tue, Oct 11, 2016 at 07:50:20AM +, Zongkai LI wrote:
> This patch fixes wrong table ID in comments for logical router ingress
> table IP Routing, ARP Resolution and ARP request.
>
> Signed-off-by: Zongkai LI
Applied, thanks!
___
dev mailing list
On Mon, Oct 10, 2016 at 04:52:07PM -0700, Andy Zhou wrote:
> On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
>
> > It's pretty unlikely that a human would write expressions like these, but
> > they can come up in machine-generated expressions and it seems best to
On Mon, Oct 10, 2016 at 11:38:21AM -0700, Jarno Rajahalme wrote:
>
> > On Oct 7, 2016, at 5:54 PM, Justin Pettit wrote:
> >
> >
> >> On Oct 7, 2016, at 5:41 PM, Jarno Rajahalme wrote:
> >>
> >> xxreg2 and xxreg3 had the same NXM_NX_* names as xxreg0 and xxreg1,
> >> correspondingly.
> >>
> >
On Sat, Oct 08, 2016 at 07:27:17AM -0300, Thadeu Lima de Souza Cascardo wrote:
> Clean the source directory before building, otherwise, build might fail if it
> has been configured already.
>
> Only do it if there is a Makefile present, as suggested by Ben Pfaff.
>
> Signed-o
On Fri, Oct 07, 2016 at 02:39:00PM -0700, Andy Zhou wrote:
> On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote:
>
> > This should make it that much easier to track down the code that emitted
> > a particular flow.
> >
> > Signed-off-by: Ben Pfaff
> >
>
&
On Fri, Oct 07, 2016 at 02:41:22PM -0700, Andy Zhou wrote:
> On Fri, Oct 7, 2016 at 9:23 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Andy Zhou
Thanks, I applied this to master.
___
dev mailing list
dev@op
On Fri, Oct 07, 2016 at 02:37:29PM -0700, Andy Zhou wrote:
> On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote:
>
> > Future commits will add a user.
> >
> > Signed-off-by: Ben Pfaff
> >
>
> Acked-by: Andy Zhou
>
> This is the first time I encoun
Also vertical tabs, whatever those are.
Signed-off-by: Ben Pfaff
---
ovn/lib/lex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn/lib/lex.c b/ovn/lib/lex.c
index a05edfa..7eee3b6 100644
--- a/ovn/lib/lex.c
+++ b/ovn/lib/lex.c
@@ -589,7 +589,7 @@ next:
token
Future commits will add a user.
Signed-off-by: Ben Pfaff
---
include/openvswitch/hmap.h | 10 +-
lib/smap.h | 26 +-
2 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/include/openvswitch/hmap.h b/include/openvswitch/hmap.h
index
This should make it that much easier to track down the code that emitted
a particular flow.
Signed-off-by: Ben Pfaff
---
ovn/northd/ovn-northd.c | 40 +++-
ovn/ovn-sb.xml| 5 +
ovn/utilities/ovn-trace.8.xml | 7 ---
ovn
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 4dfb077..38b5af9 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -1259,6 +1259,9 @@ ovn-nbctl ls-add lsw0
ovn-sbctl chassis-add hv0 geneve 127.0.0.1
for i in 1 2 3
Also, it is not necessary to specify that the name must be unique because
the schema documentation generator does that for us.
Reported-by: Kevin Lin
Reported-at: http://openvswitch.org/pipermail/dev/2016-October/080386.html
Signed-off-by: Ben Pfaff
---
AUTHORS| 1 +
ovn/ovn-nb.xml | 3
On Thu, Oct 06, 2016 at 04:19:59PM -0700, Justin Pettit wrote:
>
> > On Oct 5, 2016, at 6:27 PM, Ben Pfaff wrote:
> >
> > ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp.
> >
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Ju
On Fri, Oct 07, 2016 at 07:27:54AM -0700, Guru Shetty wrote:
> On 5 October 2016 at 18:26, Ben Pfaff wrote:
>
> > It can take a way for dynamic addresses to propagate through ovn-northd,
> > so wait for it to happen.
> >
> > Signed-off-by: Ben Pfaff
On Fri, Oct 07, 2016 at 07:24:29AM -0700, Guru Shetty wrote:
> On 5 October 2016 at 18:26, Ben Pfaff wrote:
>
> > The test assumed that ovn-northd could delete the MAC_Binding rows
> > instantly, but it may take a while.
> >
> > Signed-off-by: Ben Pfaff
It's pretty unlikely that a human would write expressions like these, but
they can come up in machine-generated expressions and it seems best to
simplify them in an efficient way.
Signed-off-by: Ben Pfaff
---
ovn/lib/expr.c | 41 ++---
tests/ovn.at
The test added by this commit is very specific to the particular problem,
whereas a more general test would be better. A later commit adds the
general test.
Signed-off-by: Ben Pfaff
---
ovn/lib/expr.c | 11 ++-
tests/ovn.at | 2 ++
2 files changed, 12 insertions(+), 1 deletion
The test didn't check for x == 0/0 or x != 0/0 cases, and thus they were
buggy.
Also, add "expression" as a keyword for tests that only had "expressions"
(plural).
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 28 +---
tests/test-ovn.c | 10 ++
ommit fixes this and related problems.
The test added by this commit is very specific to the particular problem,
whereas a more general test would be better. A later commit adds the
general test.
Signed-off-by: Ben Pfaff
---
ovn/lib/expr.c | 15 ++-
tests/ovn.at | 8
2
On Thu, Oct 06, 2016 at 02:56:44PM -0700, Kevin Lin wrote:
> I’m a developer under Ethan Jackson on Quilt. We’re using address sets in our
> ACL match strings,
> but they don’t seem to parse properly for names with hypens:
>
> error parsing match "ip4.src == $foo-bar": Syntax error at `$foo' expe
On Thu, Oct 06, 2016 at 05:52:33PM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Thu, Oct 06, 2016 at 01:51:08PM -0700, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > NEWS | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > dif
1 - 100 of 19135 matches
Mail list logo
