Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2016-01-11 Thread Ben Pfaff
On Mon, Dec 21, 2015 at 07:57:16PM +0530, Numan Siddique wrote: > Instead add only if > - the port is up or > - if port type is router > > Signed-off-by: Numan Siddique Following the discussion, I applied this to master. I updated ovn-northd(8) to describe the new behavior.

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Han Zhou
On Mon, Dec 21, 2015 at 1:59 PM, Ben Pfaff wrote: > On Mon, Dec 21, 2015 at 03:03:42PM -0500, Russell Bryant wrote: > > On 12/21/2015 02:52 PM, Ben Pfaff wrote: > > > On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote: > > >> On 12/21/2015 09:55 AM, Numan Siddique wrote: > > >>> On 12

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Ben Pfaff
On Mon, Dec 21, 2015 at 03:03:42PM -0500, Russell Bryant wrote: > On 12/21/2015 02:52 PM, Ben Pfaff wrote: > > On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote: > >> On 12/21/2015 09:55 AM, Numan Siddique wrote: > >>> On 12/21/2015 08:13 PM, Russell Bryant wrote: > On 12/21/2015

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Russell Bryant
On 12/21/2015 02:52 PM, Ben Pfaff wrote: > On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote: >> On 12/21/2015 09:55 AM, Numan Siddique wrote: >>> On 12/21/2015 08:13 PM, Russell Bryant wrote: On 12/21/2015 09:27 AM, Numan Siddique wrote: What problem are you addressing here?

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Ben Pfaff
On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote: > On 12/21/2015 09:55 AM, Numan Siddique wrote: > > On 12/21/2015 08:13 PM, Russell Bryant wrote: > >> On 12/21/2015 09:27 AM, Numan Siddique wrote: > >> What problem are you addressing here? It seems we would want the flows > >> crea

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Russell Bryant
On 12/21/2015 09:55 AM, Numan Siddique wrote: > On 12/21/2015 08:13 PM, Russell Bryant wrote: >> On 12/21/2015 09:27 AM, Numan Siddique wrote: >> What problem are you addressing here? It seems we would want the flows >> created, even when the port is not up yet. Otherwise, when the port >> does c

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Numan Siddique
On 12/21/2015 08:13 PM, Russell Bryant wrote: > On 12/21/2015 09:27 AM, Numan Siddique wrote: >> Instead add only if >> - the port is up or >> - if port type is router >> >> Signed-off-by: Numan Siddique >> --- >> ovn/northd/ovn-northd.c | 15 +++ >> 1 file changed, 15 insertions(

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Russell Bryant
On 12/21/2015 09:27 AM, Numan Siddique wrote: > Instead add only if > - the port is up or > - if port type is router > > Signed-off-by: Numan Siddique > --- > ovn/northd/ovn-northd.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/ovn/northd/ovn-northd.c b/ovn/nort

[ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Numan Siddique
Instead add only if - the port is up or - if port type is router Signed-off-by: Numan Siddique --- ovn/northd/ovn-northd.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 270b116..3d4ce78 100644 --- a/ovn/northd/ovn