Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-10 Thread Kyle Mestery (kmestery)
On Oct 10, 2012, at 11:47 AM, Ben Pfaff wrote: > On Wed, Oct 10, 2012 at 03:19:47PM +, Kyle Mestery (kmestery) wrote: >> On Oct 4, 2012, at 12:56 PM, Ben Pfaff wrote: >>> Thanks, Ralf. I will add >>> Signed-off-by: Ralf Spenneberg >>> to the commit log. >>> >> Hi Ben: >> >> Are you

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-10 Thread Ben Pfaff
On Wed, Oct 10, 2012 at 03:19:47PM +, Kyle Mestery (kmestery) wrote: > On Oct 4, 2012, at 12:56 PM, Ben Pfaff wrote: > > Thanks, Ralf. I will add > >Signed-off-by: Ralf Spenneberg > > to the commit log. > > > Hi Ben: > > Are you waiting for my feedback on this patch? Just curious a

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-10 Thread Kyle Mestery (kmestery)
On Oct 4, 2012, at 12:56 PM, Ben Pfaff wrote: > Thanks, Ralf. I will add >Signed-off-by: Ralf Spenneberg > to the commit log. > Hi Ben: Are you waiting for my feedback on this patch? Just curious as to it's state and if you see anything else you would like me to address. Thanks, Kyle

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-04 Thread Ben Pfaff
Thanks, Ralf. I will add Signed-off-by: Ralf Spenneberg to the commit log. On Thu, Oct 04, 2012 at 07:40:55AM +0200, Ralf Spenneberg wrote: > Hi, > > sorry for the delay. Yesterday was a national holiday in Germany. Yes I sure > sign off this work. > > Kind regards, > > Ralf > Am Die

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-03 Thread Ralf Spenneberg
Hi, sorry for the delay. Yesterday was a national holiday in Germany. Yes I sure sign off this work. Kind regards, Ralf Am Dienstag, 2. Oktober 2012, 12:30:00 schrieb Ben Pfaff: > Ralf, I understand that much of this is based on your work. Are you > willing to give us a > Signed-off-by

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Ben Pfaff
On Tue, Oct 02, 2012 at 08:10:45PM +, Kyle Mestery (kmestery) wrote: > On Oct 2, 2012, at 2:30 PM, Ben Pfaff wrote: > > Ralf, I understand that much of this is based on your work. Are you > > willing to give us a > >Signed-off-by: Ralf Spenneberg > > or other appropriate sign-off? By

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Kyle Mestery (kmestery)
On Oct 2, 2012, at 2:30 PM, Ben Pfaff wrote: > Ralf, I understand that much of this is based on your work. Are you > willing to give us a >Signed-off-by: Ralf Spenneberg > or other appropriate sign-off? By doing this, you are agreeing to the > Developer's Certificate of Origin (see below

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Ben Pfaff
Ralf, I understand that much of this is based on your work. Are you willing to give us a Signed-off-by: Ralf Spenneberg or other appropriate sign-off? By doing this, you are agreeing to the Developer's Certificate of Origin (see below for more details). (Maybe Kyle already asked you pri

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Kyle Mestery (kmestery)
On Oct 2, 2012, at 1:41 PM, Alexey I. Froloff wrote: > On Tue, Oct 02, 2012 at 02:31:55PM -0400, Kyle Mestery wrote: >> Add RPM specfiles for building OVS for Fedora Linux. This >> allows users of the upstream project the ability to >> generate RPMs for their Open vSwitch needs. > Why don't you jus

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Kyle Mestery (kmestery)
On Oct 2, 2012, at 1:41 PM, Alexey I. Froloff wrote: > On Tue, Oct 02, 2012 at 02:31:55PM -0400, Kyle Mestery wrote: >> Add RPM specfiles for building OVS for Fedora Linux. This >> allows users of the upstream project the ability to >> generate RPMs for their Open vSwitch needs. > Why don't you jus

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Alexey I. Froloff
On Tue, Oct 02, 2012 at 02:31:55PM -0400, Kyle Mestery wrote: > Add RPM specfiles for building OVS for Fedora Linux. This > allows users of the upstream project the ability to > generate RPMs for their Open vSwitch needs. Why don't you just add "%if 0%{?fedora}" to RHEL spec instead, as specified i

[ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Kyle Mestery
Add RPM specfiles for building OVS for Fedora Linux. This allows users of the upstream project the ability to generate RPMs for their Open vSwitch needs. Signed-off-by: Kyle Mestery V2: - Addressed Ben's comments. - Moved from init.d to systemd, per the official Fedora RPMs. - Some minor cleanup

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-02 Thread Kyle Mestery (kmestery)
On Oct 1, 2012, at 11:31 PM, Ben Pfaff wrote: > On Mon, Oct 01, 2012 at 05:20:32PM -0400, Kyle Mestery wrote: >> Add RPM specfiles for building OVS for Fedora Linux. This >> allows users of the upstream project the ability to >> generate RPMs for their Open vSwitch needs. >> >> Signed-off-by: Ky

Re: [ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-01 Thread Ben Pfaff
On Mon, Oct 01, 2012 at 05:20:32PM -0400, Kyle Mestery wrote: > Add RPM specfiles for building OVS for Fedora Linux. This > allows users of the upstream project the ability to > generate RPMs for their Open vSwitch needs. > > Signed-off-by: Kyle Mestery Thanks. I have only a few comments. The

[ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux

2012-10-01 Thread Kyle Mestery
Add RPM specfiles for building OVS for Fedora Linux. This allows users of the upstream project the ability to generate RPMs for their Open vSwitch needs. Signed-off-by: Kyle Mestery --- INSTALL.Fedora | 53 + rhel/.gitignore | 2 + rhel/autom