Re: [ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-07-01 Thread Jesse Gross
On Tue, Jul 1, 2014 at 12:26 PM, Pravin Shelar wrote: > On Tue, Jul 1, 2014 at 12:22 PM, Jesse Gross wrote: >> On Tue, Jul 1, 2014 at 11:33 AM, Pritesh Kothari (pritkoth) >> wrote: >>> >>> On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote: >>> why not just check for HAVE_U64_STATS_FETCH_BEG

Re: [ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-07-01 Thread Pravin Shelar
On Tue, Jul 1, 2014 at 12:22 PM, Jesse Gross wrote: > On Tue, Jul 1, 2014 at 11:33 AM, Pritesh Kothari (pritkoth) > wrote: >> >> On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote: >> >>> why not just check for HAVE_U64_STATS_FETCH_BEGIN_IRQ? >> >> because of this which was added in 3.13, i guess:

Re: [ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-07-01 Thread Jesse Gross
On Tue, Jul 1, 2014 at 11:33 AM, Pritesh Kothari (pritkoth) wrote: > > On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote: > >> why not just check for HAVE_U64_STATS_FETCH_BEGIN_IRQ? > > because of this which was added in 3.13, i guess: > > -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0) > - > -#i

Re: [ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-07-01 Thread Pritesh Kothari (pritkoth)
On Jul 1, 2014, at 11:18 AM, Pravin Shelar wrote: > why not just check for HAVE_U64_STATS_FETCH_BEGIN_IRQ? because of this which was added in 3.13, i guess: -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0) - -#if BITS_PER_LONG == 32 && defined(CONFIG_SMP) -# define u64_stats_init(syncp) seqco

Re: [ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-07-01 Thread Pravin Shelar
On Mon, Jun 30, 2014 at 6:01 PM, Jesse Gross wrote: > The upstream u64_stats API has been changed to remove the _bh() > versions and switch all consumers to use IRQ safe variants instead. > This was done to be safe for netpoll generated packets, which can > occur in hard IRQ context. From a safety

Re: [ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-07-01 Thread Pritesh Kothari (pritkoth)
Acked-by: Pritesh Kothari On Jun 30, 2014, at 6:01 PM, Jesse Gross wrote: > The upstream u64_stats API has been changed to remove the _bh() > versions and switch all consumers to use IRQ safe variants instead. > This was done to be safe for netpoll generated packets, which can > occur in hard I

[ovs-dev] [PATCH] datapath: Change u64_stats_* to use _irq instead of _bh().

2014-06-30 Thread Jesse Gross
The upstream u64_stats API has been changed to remove the _bh() versions and switch all consumers to use IRQ safe variants instead. This was done to be safe for netpoll generated packets, which can occur in hard IRQ context. From a safety perspective, this doesn't directly affect OVS since it doesn