[ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Ben Pfaff
Found by inspection. Signed-off-by: Ben Pfaff --- datapath/flow_netlink.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index 5a1a487..5ee3150 100644 --- a/datapath/flow_netlink.c +++ b/datapath/flow_netlink.c @@ -1,

Re: [ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Jesse Gross
On Mon, Jun 30, 2014 at 1:37 PM, Ben Pfaff wrote: > Found by inspection. > > Signed-off-by: Ben Pfaff Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Pritesh Kothari (pritkoth)
LGTM but give error on master: error: patch failed: datapath/flow_netlink.c:524 error: datapath/flow_netlink.c: patch does not apply Regards, Pritesh On Jun 30, 2014, at 1:37 PM, Ben Pfaff wrote: > Found by inspection. > > Signed-off-by: Ben Pfaff > --- > datapath/flow_netlink.c |5 +++--

Re: [ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Ben Pfaff
On Mon, Jun 30, 2014 at 01:45:06PM -0700, Jesse Gross wrote: > On Mon, Jun 30, 2014 at 1:37 PM, Ben Pfaff wrote: > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Jesse Gross Thanks, applied to master. ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Ben Pfaff
That's odd. Jesse, did this apply for you? On Mon, Jun 30, 2014 at 08:47:08PM +, Pritesh Kothari (pritkoth) wrote: > LGTM but give error on master: > error: patch failed: datapath/flow_netlink.c:524 > error: datapath/flow_netlink.c: patch does not apply > > Regards, > Pritesh > > On Jun 30,

Re: [ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Jesse Gross
Yes, it worked fine for me (using git am). On Mon, Jun 30, 2014 at 1:52 PM, Ben Pfaff wrote: > That's odd. Jesse, did this apply for you? > > On Mon, Jun 30, 2014 at 08:47:08PM +, Pritesh Kothari (pritkoth) wrote: >> LGTM but give error on master: >> error: patch failed: datapath/flow_netlin

Re: [ovs-dev] [PATCH] datapath: Fix error handling for Geneve options in ipv4_tun_to_nlattr().

2014-06-30 Thread Pritesh Kothari (pritkoth)
weird, git am still give me same error, but removing headers and applying diff using git apply works, anyways thanks. LGTM. Regards, Pritesh On Jun 30, 2014, at 1:56 PM, Jesse Gross wrote: > Yes, it worked fine for me (using git am). > > On Mon, Jun 30, 2014 at 1:52 PM, Ben Pfaff wrote: >> T