Re: [ovs-dev] [PATCH] datapath: Remove pkt_key from OVS_CB.

2014-09-20 Thread Pravin Shelar
On Thu, Sep 18, 2014 at 11:31 PM, Andy Zhou az...@nicira.com wrote: look good in general. a few small comments in line. Acked-by: Andy Zhou az...@nicira.com On Wed, Sep 17, 2014 at 6:58 PM, Pravin B Shelar pshe...@nicira.com wrote: OVS keeps pointer to packet key in skb-cb, but the packet

Re: [ovs-dev] [PATCH] datapath: Remove pkt_key from OVS_CB.

2014-09-19 Thread Andy Zhou
look good in general. a few small comments in line. Acked-by: Andy Zhou az...@nicira.com On Wed, Sep 17, 2014 at 6:58 PM, Pravin B Shelar pshe...@nicira.com wrote: OVS keeps pointer to packet key in skb-cb, but the packet key is store on stack. This could make code bit tricky. So it is better

[ovs-dev] [PATCH] datapath: Remove pkt_key from OVS_CB.

2014-09-17 Thread Pravin B Shelar
OVS keeps pointer to packet key in skb-cb, but the packet key is store on stack. This could make code bit tricky. So it is better to get rid of the pointer. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- datapath/actions.c| 294 +++---