[ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

2016-08-31 Thread Nithin Raju
Since the Geneve changes, the key->l2.offset will no longer be 0 when the tunnel key is valid within the OVS flow key. key->l2.offset would be determined by the amount of tunnel options. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/DpInternal.h | 9 ++--- datapath-windows/ovsext/Fl

Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

2016-08-31 Thread Sairam Venugopal
Thanks for fixing this. Acked-by: Sairam Venugopal On 8/31/16, 3:33 AM, "Nithin Raju" wrote: >Since the Geneve changes, the key->l2.offset will no longer be 0 when >the tunnel key is valid within the OVS flow key. key->l2.offset would >be determined by the amount of tunnel options. > >Signed-

Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

2016-08-31 Thread Yin Lin
Hi Nithin, Instead of removing the assertion, can you change it to: ASSERT(!key->tunKey.dst || offset == OvsGetFlowL2Offset(&key->tunKey)); I fixed it for OvsLookupFlow but somehow overlooked OvsHashFlow in my Geneve patch. Best regards, Yin Lin On Wed, Aug 31, 2016 at 3:33 AM, Nithin Raju wr

Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

2016-08-31 Thread Nithin Raju
Ok. Thanks for the review. -Original Message- From: dev on behalf of Yin Lin Date: Wednesday, August 31, 2016 at 5:05 PM To: Nithin Raju Cc: "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c >Hi Nithin, > >