Re: [ovs-dev] [PATCH] datapath-windows: update CodingStyle

2016-09-12 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 9/11/16, 10:56 PM, "Nithin Raju" wrote: >Signed-off-by: Nithin Raju >--- > datapath-windows/CodingStyle | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/datapath-windows/CodingStyle

[ovs-dev] [PATCH] datapath-windows: update CodingStyle

2016-09-11 Thread Nithin Raju
Signed-off-by: Nithin Raju --- datapath-windows/CodingStyle | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath-windows/CodingStyle b/datapath-windows/CodingStyle index 3550cdb..40873e8 100644 --- a/datapath-windows/CodingStyle +++ b/datapath-windows/CodingStyle @@

[ovs-dev] [PATCH] datapath-windows: update CodingStyle guideline for variable names

2014-09-09 Thread Nithin Raju
During a review, it seemed that some of the conventions were not clear. Fixing them in this patch. Signed-off-by: Nithin Raju nit...@vmware.com --- datapath-windows/CodingStyle | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/datapath-windows/CodingStyle

Re: [ovs-dev] [PATCH] datapath-windows: Update CodingStyle

2014-08-06 Thread Samuel Ghinet
Hello again, I would also suggest, in order to improve clarity. For instance, say if there is a function we need to add, that searches the list of Hyper-V Nics in a list. And this list is supposed to be previously locked / synchronized by the caller. The windows kernel style, as we had seen in

Re: [ovs-dev] [PATCH] datapath-windows: Update CodingStyle

2014-08-06 Thread Samuel Ghinet
Update the file CodingStyle: add more Windows-style rules. Also, other rules will make code more clear. Windows Kernel style rules: o) Type names (structs, enums), constants, symbols, macros. o) Braces o) Code annotations o) Function suffix: Unsafe o) Switch Cases Code clarity rules: o) OVS_

[ovs-dev] [PATCH] datapath-windows: Update CodingStyle

2014-08-05 Thread Samuel Ghinet
Update the file CodingStyle: add more Windows-style rules. Also, other rules will make code more clear. Windows Kernel style rules: o) Type names (structs, enums), constants, symbols, macros. o) Braces o) Code annotations o) Function suffix: Unsafe o) Switch Cases Code clarity rules: o) OVS_