Re: [ovs-dev] [PATCH] dpctl: Fix jump through wild pointer in "dpctl/help".

2015-11-03 Thread Ben Pfaff
On Tue, Oct 20, 2015 at 10:55:37PM +, Daniele Di Proietto wrote: > > On 17/10/2015 14:24, "Ben Pfaff" wrote: > > >dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure > >it passed to the handler, which meant that dpctl_help() could see a > >nonnull >

Re: [ovs-dev] [PATCH] dpctl: Fix jump through wild pointer in "dpctl/help".

2015-10-20 Thread Daniele Di Proietto
On 17/10/2015 14:24, "Ben Pfaff" wrote: >dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure >it passed to the handler, which meant that dpctl_help() could see a >nonnull >(indeterminate) 'usage' pointer and jump through it, causes a crash. >This commit

[ovs-dev] [PATCH] dpctl: Fix jump through wild pointer in "dpctl/help".

2015-10-17 Thread Ben Pfaff
dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure it passed to the handler, which meant that dpctl_help() could see a nonnull (indeterminate) 'usage' pointer and jump through it, causes a crash. This commit fixes the crash by fully initializing the structure. The