Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-08-05 Thread Jesse Gross
On Wednesday, August 5, 2015, Jarno Rajahalme wrote: > > > On Aug 3, 2015, at 6:04 PM, Jesse Gross > > wrote: > > On Mon, Aug 3, 2015 at 3:45 PM, Jarno Rajahalme > wrote: > >>> static inline uint32_t > >>> diff --git a/lib/flow.c b/lib/flow.c > >>> index 352e9b8..d3d25e4 100644 > >>> --- a/lib/fl

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-08-04 Thread Jesse Gross
On Tuesday, August 4, 2015, Traynor, Kevin wrote: > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org ] On Behalf > Of Jesse Gross > > Sent: Thursday, July 30, 2015 4:10 AM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [PATCH 2/2] dpif-netdev: Translate Geneve

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-07-29 Thread Jesse Gross
On Tue, Jul 14, 2015 at 12:40 PM, Ben Pfaff wrote: > On Tue, Jul 07, 2015 at 10:30:05PM -0700, Jesse Gross wrote: > Here's a comment for struct tun_metadata with a little more detail, to > try to make sure I understand it correctly: > > /* Tunnel option data, plus metadata to aid in their interpre

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 07, 2015 at 10:30:05PM -0700, Jesse Gross wrote: > The kernel implementation of Geneve options stores the TLV option > data in the flow exactly as received, without any further parsing. > This is then translated to known options for the purposes of matching > on flow setup (which will t

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-07-10 Thread Jesse Gross
On Fri, Jul 10, 2015 at 11:09 AM, Jarno Rajahalme wrote: >> On Jul 7, 2015, at 10:30 PM, Jesse Gross wrote: >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >> index b53d52a..50763bc 100644 >> --- a/lib/dpif-netdev.c >> +++ b/lib/dpif-netdev.c >> +static void >> +xlate_geneve_attr(const stru

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-07-10 Thread Jarno Rajahalme
Jesse, This is no proper review, but I have two questions below. Jarno > On Jul 7, 2015, at 10:30 PM, Jesse Gross wrote: > > The kernel implementation of Geneve options stores the TLV option > data in the flow exactly as received, without any further parsing. > This is then translated to kno

[ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-07-07 Thread Jesse Gross
The kernel implementation of Geneve options stores the TLV option data in the flow exactly as received, without any further parsing. This is then translated to known options for the purposes of matching on flow setup (which will then install a datapath flow in the form the kernel is expecting). Th