Re: [ovs-dev] [PATCH] lib/list: Add LIST_FOR_EACH_POP.

2015-04-06 Thread Jarno Rajahalme
On Apr 3, 2015, at 4:51 PM, Russell Bryant rbry...@redhat.com wrote: On 04/03/2015 06:55 PM, Jarno Rajahalme wrote: Makes popping each member of the list a bit easier. Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com Nice improvement! The changes look good to me. I think one

Re: [ovs-dev] [PATCH] lib/list: Add LIST_FOR_EACH_POP.

2015-04-05 Thread Ben Pfaff
On Fri, Apr 03, 2015 at 03:55:43PM -0700, Jarno Rajahalme wrote: Makes popping each member of the list a bit easier. Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com diff --git a/lib/list.h b/lib/list.h index b40bbef..bca5d5c 100644 --- a/lib/list.h +++ b/lib/list.h @@ -73,6 +73,12

[ovs-dev] [PATCH] lib/list: Add LIST_FOR_EACH_POP.

2015-04-03 Thread Jarno Rajahalme
Makes popping each member of the list a bit easier. Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com --- lib/dp-packet.c |5 ++--- lib/list.h |6 ++ lib/lldp/lldpd-structs.c |5 ++--- lib/lldp/lldpd.c |5 ++---

Re: [ovs-dev] [PATCH] lib/list: Add LIST_FOR_EACH_POP.

2015-04-03 Thread Russell Bryant
On 04/03/2015 06:55 PM, Jarno Rajahalme wrote: Makes popping each member of the list a bit easier. Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com Nice improvement! The changes look good to me. I think one bonus improvement would be to add a test case to tests/test-list.c. Acked-by: