Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-13 Thread Traynor, Kevin
> -Original Message- > From: Loftus, Ciara > Sent: Tuesday, May 10, 2016 10:22 AM > To: Traynor, Kevin > Cc: dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD > > > On 21/04/2016 13:20, Ciara Loftus wrote: > > > DPDK

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-13 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu > Matilainen > Sent: Tuesday, May 10, 2016 2:51 PM > To: Daniele Di Proietto ; Loftus, Ciara > > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHos

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Panu Matilainen
On 04/30/2016 03:23 AM, Daniele Di Proietto wrote: I see that vhost-cuse is still handled separately. Is it possible to use the vhost pmd also for vhost-cuse? Otherwise we still basically have to handle differently three cases: NIC PMD, vhost user pmd, vhost cuse. Maybe it's time to remove vhos

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Ilya Maximets
On 10.05.2016 12:38, Loftus, Ciara wrote: >> >> On 10.05.2016 11:31, Ilya Maximets wrote: >>> On 03.05.2016 14:28, ciara.loftus at intel.com (Loftus, Ciara) wrote: > This patch seem to remove a lot of txq remapping functions (like > netdev_dpdk_remap_txqs).Ã, How does it handle the case o

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Loftus, Ciara
> > On 10.05.2016 11:31, Ilya Maximets wrote: > > On 03.05.2016 14:28, ciara.loftus at intel.com (Loftus, Ciara) wrote: > >>> This patch seem to remove a lot of txq remapping functions (like > >>> netdev_dpdk_remap_txqs).Ã, How does it handle the case of a > disabled txq in > >>> the guest kerne

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Loftus, Ciara
> On 21/04/2016 13:20, Ciara Loftus wrote: > > DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports > > to be controlled by the librte_ether API, like physical 'dpdk' ports. > > The commit integrates this functionality into OVS, and refactors some > > of the existing vhost code su

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-10 Thread Ilya Maximets
CC:mail-list. Sorry. On 10.05.2016 11:31, Ilya Maximets wrote: > On 03.05.2016 14:28, ciara.loftus at intel.com (Loftus, Ciara) wrote: >>> This patch seem to remove a lot of txq remapping functions (like >>> netdev_dpdk_remap_txqs). How does it handle the case of a disabled txq >>> in >>> the

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-05-03 Thread Loftus, Ciara
> > Hi Ciara, > thanks for doing this.  I really think this has the potential to clean up the > netdev-dpdk code. Thanks for your feedback Daniele. Comments inline, v2 soon. > The clang thread safety analyzer reports some warnings: > >   CC   lib/netdev-dpdk.lo > ../lib/netdev-dpdk.c:882:1:

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-04-29 Thread Daniele Di Proietto
Hi Ciara, thanks for doing this. I really think this has the potential to clean up the netdev-dpdk code. The clang thread safety analyzer reports some warnings: CC lib/netdev-dpdk.lo ../lib/netdev-dpdk.c:882:1: error: mutex 'dpdk_mutex' is not held on every path through here [-Werror,-W

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-04-28 Thread Traynor, Kevin
On 21/04/2016 13:20, Ciara Loftus wrote: DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports to be controlled by the librte_ether API, like physical 'dpdk' ports. The commit integrates this functionality into OVS, and refactors some of the existing vhost code such that it is vh

[ovs-dev] [PATCH] netdev-dpdk: Add vHost User PMD

2016-04-21 Thread Ciara Loftus
DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports to be controlled by the librte_ether API, like physical 'dpdk' ports. The commit integrates this functionality into OVS, and refactors some of the existing vhost code such that it is vhost-cuse specific. Similarly, there is now