Re: [ovs-dev] [PATCH] netdev-dpdk: Fix crash when changing the vhost-user port.

Thanks for the patch and the review! Pushed to master, branch-2.5 and branch-2.4 On 22/03/2016 16:27, "Traynor, Kevin" wrote: >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Tuesday, March 22, 2016 12:42 PM >> To:

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix crash when changing the vhost-user port.

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Tuesday, March 22, 2016 12:42 PM > To: dev@openvswitch.org; Daniele Di Proietto > Cc: Dyasly Sergey ; Ben Pfaff ; Flavio > Leitner

[ovs-dev] [PATCH] netdev-dpdk: Fix crash when changing the vhost-user port.

According to netdev-provider API: 'The "destruct" function is not allowed to fail.' netdev-dpdk breaks this restriction for vhost-user ports. This leads to SIGABRT or SIGSEGV in dpdk_watchdog thread because 'dealloc' will be called anyway indifferently to result of 'destruct'. For