Re: [ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-19 Thread Loftus, Ciara
> > ~RTE_VHOST_USER_CLIENT means that every other bit is set to one, which > affects other flags. > I think the current code is ok:  it's not wrokg to assume that the newly > initialized structure has every member set to 0. > If you feel strongly about it, I think it would be better to set the sin

Re: [ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-18 Thread Daniele Di Proietto
~RTE_VHOST_USER_CLIENT means that every other bit is set to one, which affects other flags. I think the current code is ok: it's not wrokg to assume that the newly initialized structure has every member set to 0. If you feel strongly about it, I think it would be better to set the single bit in

Re: [ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-18 Thread Loftus, Ciara
> > rte_vhost_driver_register accepts a 'mode' flag which sets server(0) or > client(1) mode. vHost devices are registered in 'server' mode (0) when > initially created. Before this patch the flags provided to this > function were the device's 'vhost_driver_flags' which hadn't been set > yet when

[ovs-dev] [PATCH] netdev-dpdk: Provide explicit flag to rte_vhost_driver_register

2016-08-18 Thread Ciara Loftus
rte_vhost_driver_register accepts a 'mode' flag which sets server(0) or client(1) mode. vHost devices are registered in 'server' mode (0) when initially created. Before this patch the flags provided to this function were the device's 'vhost_driver_flags' which hadn't been set yet when the register