Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

> >Hi Mark, > >RFC 2863 standard describes in "Interface Numbering" chapter >(https://tools.ietf.org/html/rfc2863#page-10) that if there's possibility to >reuse ifindex >after reinitialization then it should be reused. [MK] Very interesting - thanks for the link. And in our case it's

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Reusing an ifIndex from time to time is no problem from the sFlow standard point of view either. In fact we used a hash approach in the host-sflow project to assign index numbers to containers (by open-hashing the container UUID into a range of possible index numbers):

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Hi Mark, RFC 2863 standard describes in "Interface Numbering" chapter (https://tools.ietf.org/html/rfc2863#page-10) that if there's possibility to reuse ifindex after reinitialization then it should be reused. And in our case it's definitely possible. I also agree with you that limitation to

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

> >Hi Mark, > >Replies inline prefixed with [PL]. > >Thanks, >Przemek > >-Original Message- >From: Kavanagh, Mark B >Sent: Thursday, May 5, 2016 2:19 PM >To: Lal, PrzemyslawX ; dev@openvswitch.org >Subject: RE: [PATCH] netdev-dpdk: add sflow support for

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Hi Mark, Replies inline prefixed with [PL]. Thanks, Przemek -Original Message- From: Kavanagh, Mark B Sent: Thursday, May 5, 2016 2:19 PM To: Lal, PrzemyslawX ; dev@openvswitch.org Subject: RE: [PATCH] netdev-dpdk: add sflow support for vhost-user ports Hi

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

> >On Thu, May 05, 2016 at 12:18:52PM +, Kavanagh, Mark B wrote: >> >+if ((ret = netdev_dpdk_lookup_vhost_id(dev)) >= 0) { >> >+ifindex = VHOST_ID_TO_IFINDEX(ret); >> >+} else { >> >+ifindex = 0; >> >> I don't think that 0 is an appropriate value to

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

On Thu, May 05, 2016 at 12:18:52PM +, Kavanagh, Mark B wrote: > >+if ((ret = netdev_dpdk_lookup_vhost_id(dev)) >= 0) { > >+ifindex = VHOST_ID_TO_IFINDEX(ret); > >+} else { > >+ifindex = 0; > > I don't think that 0 is an appropriate value to return here,

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Hi Przemek, Some additional comments/queries inline. Thanks again, Mark > >This patch adds sFlow support for DPDK vHost-user interfaces by assigning >ifindex value. Values of ifindexes for vHost-user interfaces start with 2000 >to avoid overlapping with kernel datapath interfaces. > >Patch also

[ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

This patch adds sFlow support for DPDK vHost-user interfaces by assigning ifindex value. Values of ifindexes for vHost-user interfaces start with 2000 to avoid overlapping with kernel datapath interfaces. Patch also fixes issue with 'dpdk0' interface being ignored by sFlow agent, because of

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Hi Mark, Good points, I corrected all of them (hopefully) and resubmitted the patch. Thanks, Przemek -Original Message- From: Kavanagh, Mark B Sent: Wednesday, May 4, 2016 4:43 PM To: Lal, PrzemyslawX ; dev@openvswitch.org Subject: RE: [PATCH] netdev-dpdk:

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Hi Przemek, Apologies for the churn, but some additional points occurred to me - please refer to comments in netdev_dpdk_get_ifindex. Thanks, Mark > >This patch adds sFlow support for DPDK vHost-user interfaces by assigning >ifindex value. Values of ifindexes for vHost-user interfaces start

[ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

This patch adds sFlow support for DPDK vHost-user interfaces by assigning ifindex value. Values of ifindexes for vHost-user interfaces start with 2000 to avoid overlapping with kernel datapath interfaces. Patch also fixes issue with 'dpdk0' interface being ignored by sFlow agent, because of

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

, PrzemyslawX <przemyslawx@intel.com> Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports Hi Przemek, You're right, dpdk eth ports were supported, but there was a possibility that their indexes could overlap with kernel interfaces,

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

dpdk: add sflow support for dpdk ports"? Thanks, Przemek -Original Message- From: Kavanagh, Mark B Sent: Wednesday, May 4, 2016 12:23 PM To: Lal, PrzemyslawX <przemyslawx@intel.com>; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Lal, PrzemyslawX <przemyslawx....@intel.com>; dev@openvswitch.org >Subject: RE: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user >ports > >Hi Przemek, > >A few review comments inline. > >Also, the patch/commit name suggests that sFlow suppor

Re: [ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

Hi Przemek, A few review comments inline. Also, the patch/commit name suggests that sFlow support is only added for vhost-user ports, but it's also added for dpdk_eth ports, right? Cheers, Mark > >This patch adds sFlow support for DPDK vHost-user interfaces by assigning >ifindex value. Values

[ovs-dev] [PATCH] netdev-dpdk: add sflow support for vhost-user ports

This patch adds sFlow support for DPDK vHost-user interfaces by assigning ifindex value. Values of ifindexes for vHost-user interfaces start with 2000 to avoid overlapping with kernel datapath interfaces. Patch also fixes issue with 'dpdk0' interface being ignored by sFlow agent, because of