[ovs-dev] [PATCH] netlink-socket: return correct error code when connect fails

2016-02-15 Thread Thadeu Lima de Souza Cascardo
When connect and other calls fail after get_socket_rcvbuf, the return code would be the rcvbuf size, not errno from the last call. Signed-off-by: Thadeu Lima de Souza Cascardo --- lib/netlink-socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c

Re: [ovs-dev] [PATCH] netlink-socket: return correct error code when connect fails

2016-02-15 Thread Simon Horman
Hi, On Mon, Feb 15, 2016 at 03:13:30PM -0200, Thadeu Lima de Souza Cascardo wrote: > When connect and other calls fail after get_socket_rcvbuf, the return code > would > be the rcvbuf size, not errno from the last call. > > Signed-off-by: Thadeu Lima de Souza Cascardo This seems correct to me

Re: [ovs-dev] [PATCH] netlink-socket: return correct error code when connect fails

2016-02-16 Thread Thadeu Lima de Souza Cascardo
On Tue, Feb 16, 2016 at 11:32:19AM +0900, Simon Horman wrote: > Hi, > > On Mon, Feb 15, 2016 at 03:13:30PM -0200, Thadeu Lima de Souza Cascardo wrote: > > When connect and other calls fail after get_socket_rcvbuf, the return code > > would > > be the rcvbuf size, not errno from the last call. > >

Re: [ovs-dev] [PATCH] netlink-socket: return correct error code when connect fails

2016-02-16 Thread Ben Pfaff
On Tue, Feb 16, 2016 at 11:32:19AM +0900, Simon Horman wrote: > Hi, > > On Mon, Feb 15, 2016 at 03:13:30PM -0200, Thadeu Lima de Souza Cascardo wrote: > > When connect and other calls fail after get_socket_rcvbuf, the return code > > would > > be the rcvbuf size, not errno from the last call. > >