Re: [ovs-dev] [PATCH] nx-match: Fix distribution of hash function for NXM/OXM headers.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 11:21:51AM -0700, Jesse Gross wrote: > On Wed, Jun 24, 2015 at 11:17 AM, Ben Pfaff wrote: > > NXM/OXM headers as represented in this file are 64-bit long and the low > > bits are essentially constant (almost always 0) so using hash_int(), > > which takes an uint32_t, is goi

Re: [ovs-dev] [PATCH] nx-match: Fix distribution of hash function for NXM/OXM headers.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 11:17 AM, Ben Pfaff wrote: > NXM/OXM headers as represented in this file are 64-bit long and the low > bits are essentially constant (almost always 0) so using hash_int(), > which takes an uint32_t, is going to be a useless hash function. This > commit fixes the problem. >

[ovs-dev] [PATCH] nx-match: Fix distribution of hash function for NXM/OXM headers.

2015-06-24 Thread Ben Pfaff
NXM/OXM headers as represented in this file are 64-bit long and the low bits are essentially constant (almost always 0) so using hash_int(), which takes an uint32_t, is going to be a useless hash function. This commit fixes the problem. Found by inspection. CC: Jesse Gross Signed-off-by: Ben Pf