Re: [ovs-dev] [PATCH] ofproto/bond: simplify rebalancing logic

2015-09-22 Thread Andy Zhou
On Fri, Sep 18, 2015 at 3:32 PM, Andy Zhou wrote: >> >> It seems reasonable at first glance, but I wonder whether you went >> through the history of this logic to make sure that we're not regressing >> on any of the improvements we've made over time? > > This algorithm did not change much. As far

Re: [ovs-dev] [PATCH] ofproto/bond: simplify rebalancing logic

2015-09-18 Thread Andy Zhou
> > It seems reasonable at first glance, but I wonder whether you went > through the history of this logic to make sure that we're not regressing > on any of the improvements we've made over time? This algorithm did not change much. As far as I can tell, It has been the same since 2.0. I believe t

Re: [ovs-dev] [PATCH] ofproto/bond: simplify rebalancing logic

2015-09-18 Thread Ben Pfaff
On Tue, Sep 15, 2015 at 02:09:59PM -0700, Andy Zhou wrote: > The current bond relancing logic is more complicated than necessary. > When considering a bucket for rebalancing, we just need to make sure > post rebalancing traffic will be closer to the ideal traffic split > than before. This patch imp

[ovs-dev] [PATCH] ofproto/bond: simplify rebalancing logic

2015-09-15 Thread Andy Zhou
The current bond relancing logic is more complicated than necessary. When considering a bucket for rebalancing, we just need to make sure post rebalancing traffic will be closer to the ideal traffic split than before. This patch implements the simplification. There is a bug is current algorithm th