Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix UFID usage with flow_modify.

2016-05-17 Thread Joe Stringer
On 14 May 2016 at 21:41, Ben Pfaff wrote: > On Fri, May 13, 2016 at 02:17:12PM -0700, Joe Stringer wrote: >> As per the delete_op_init{,__}() functions, the UFID should only be >> passed down if ukey->ufid_present is set. Otherwise it is possible to >> request a flow modification only using a UFID

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix UFID usage with flow_modify.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 02:17:12PM -0700, Joe Stringer wrote: > As per the delete_op_init{,__}() functions, the UFID should only be > passed down if ukey->ufid_present is set. Otherwise it is possible to > request a flow modification only using a UFID in a datapath that doesn't > support UFID, whic

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix UFID usage with flow_modify.

2016-05-13 Thread Joe Stringer
As per the delete_op_init{,__}() functions, the UFID should only be passed down if ukey->ufid_present is set. Otherwise it is possible to request a flow modification only using a UFID in a datapath that doesn't support UFID, which will fail. Fixes: 43b2f131a229 ("ofproto: Allow in-place modificati