Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread William Tu
thank you. I submit patch v2 here: https://patchwork.ozlabs.org/patch/622297/ On Sat, May 14, 2016 at 11:46 AM, Ben Pfaff wrote: > On Fri, May 13, 2016 at 11:30:14PM -0700, William Tu wrote: > > Hi Ryan, > > > > Thanks for the feedback. > > > > > --- a/ovn/utilities/ovn-sbctl.c >

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 11:30:14PM -0700, William Tu wrote: > Hi Ryan, > > Thanks for the feedback. > > > --- a/ovn/utilities/ovn-sbctl.c > > > +++ b/ovn/utilities/ovn-sbctl.c > > > @@ -973,6 +973,7 @@ do_sbctl(const char *args, struct ctl_command > > > *commands, size_t n_commands, > > >

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread William Tu
Hi Ryan, Thanks for the feedback. > --- a/ovn/utilities/ovn-sbctl.c > > +++ b/ovn/utilities/ovn-sbctl.c > > @@ -973,6 +973,7 @@ do_sbctl(const char *args, struct ctl_command > > *commands, size_t n_commands, > > free(commands); > > ovsdb_idl_txn_destroy(txn); > >

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-13 Thread Ryan Moats
"dev" <dev-boun...@openvswitch.org> wrote on 05/13/2016 05:26:10 PM: > From: William Tu <u9012...@gmail.com> > To: dev@openvswitch.org > Date: 05/13/2016 05:26 PM > Subject: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind. > Sent b

[ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-13 Thread William Tu
Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV. ds_put_char__ (dynamic-string.c:82) ds_put_char (dynamic-string.h:88) process_escape_args (process.c:103) main (ovn-nbctl.c:92) Another leak shown at ovn-sbctl.c with similar pattern. Signed-off-by: William Tu