[ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-26 Thread Wei Shen
Fixed a minor bug that would print out a confusing warning about core mask, "ovs_numa|WARN|Invalid cpu mask: x", when dpdl-lcore-mask has 0x prefix, e.g. 0x123, which is the convention used in INSTALL.DPDK.md. --- lib/ovs-numa.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/ovs-numa.

Re: [ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-27 Thread Daniele Di Proietto
Thanks for the patch. We never accepted the 0x prefix for pmd-cpu-mask, but I guess there's no harm in doing it and it might make user's life easier. We always use braces, even for single statement, please read CodingStyle.md https://github.com/openvswitch/ovs/blob/master/CodingStyle.md#statemen

Re: [ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-27 Thread Shen, Wei1
etto Date: Wednesday, July 27, 2016 at 2:28 PM To: Wei1 Shen Cc: "dev@openvswitch.org" Subject: Re: [ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix Thanks for the patch. We never accepted the 0x prefix for pmd-cpu-mask, but I guess there's no harm in doing it and it might ma

Re: [ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-29 Thread Daniele Di Proietto
yling reminder… I haven’t gone through those in much > detail. Let me send another patch that complies with those. > > > > -- > > Best, > > Wei Shen. > > > > *From: *Daniele Di Proietto > *Date: *Wednesday, July 27, 2016 at 2:28 PM > *To: *Wei1 Shen &