Re: [ovs-dev] [PATCH] ovsdb-idl: Style and comment improvements for conditional replication.

2016-08-15 Thread Ben Pfaff
On Mon, Aug 15, 2016 at 04:05:39PM -0400, Flaviof wrote: > On Sun, Aug 14, 2016 at 12:52 AM, Ben Pfaff wrote: > > > The conditional replication code had hardly any comments. This adds some. > > > > This commit also fixes a number of style problems, factors out some code > > into a helper functio

Re: [ovs-dev] [PATCH] ovsdb-idl: Style and comment improvements for conditional replication.

2016-08-15 Thread Flaviof
On Sun, Aug 14, 2016 at 12:52 AM, Ben Pfaff wrote: > The conditional replication code had hardly any comments. This adds some. > > This commit also fixes a number of style problems, factors out some code > into a helper function, and moves some struct declarations from a public > header, that we

[ovs-dev] [PATCH] ovsdb-idl: Style and comment improvements for conditional replication.

2016-08-13 Thread Ben Pfaff
The conditional replication code had hardly any comments. This adds some. This commit also fixes a number of style problems, factors out some code into a helper function, and moves some struct declarations from a public header, that were not used by client code, into more private locations. Sign