Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On Tue, May 17, 2016 at 11:28:38AM -0700, Joe Stringer wrote: > On 17 May 2016 at 07:44, Ben Pfaff wrote: > > The ofport member should be an ofp_port_t, since it represents an OpenFlow > > port number. > > > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation >

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On 17 May 2016 at 07:44, Ben Pfaff wrote: > The ofport member should be an ofp_port_t, since it represents an OpenFlow > port number. > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation > sometimes after restart.") > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

Darrell, Ben, Thanks for the fix, The warning was introduced by my patch "send GARP on localnet" In the future, I will run my changes through sparse (and possibly clang) to detect such problems prior to sharing a patch. ovn/controller/pinctrl.c:609:39: warning: incorrect type in assignment

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On Tue, May 17, 2016 at 08:12:43AM -0700, Darrell Ball wrote: > On Tue, May 17, 2016 at 7:44 AM, Ben Pfaff wrote: > > > The ofport member should be an ofp_port_t, since it represents an OpenFlow > > port number. > > > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and

Re: [ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

On Tue, May 17, 2016 at 7:44 AM, Ben Pfaff wrote: > The ofport member should be an ofp_port_t, since it represents an OpenFlow > port number. > > Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation > sometimes after restart.") > Is this rather related to "ovn:

[ovs-dev] [PATCH] pinctrl: Fix "sparse" warning.

The ofport member should be an ofp_port_t, since it represents an OpenFlow port number. Fixes: 9baaabfff3c7 ("ovn: Fix localnet ports deletion and recreation sometimes after restart.") Signed-off-by: Ben Pfaff --- ovn/controller/pinctrl.c | 5 +++-- 1 file changed, 3