[ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
Testcase 1311, 1312: Boolean-distinct queries on scalars, reports leak below: xmalloc (util.c:112) do_query_distinct (test-ovsdb.c:1208) ovs_cmdl_run_command (command-line.c:121) main (test-ovsdb.c:72) Signed-off-by: William Tu --- tests/test-ovsdb.c | 1 + 1 file changed, 1 inse

[ovs-dev] [PATCH] test-ovsdb: Fix memory leak reported by valgrind.

2016-02-09 Thread William Tu
Testcase 1314: UUID-distinct queries on scalars. Call stacks: allocate_row (row.c:37) ovsdb_row_clone (row.c:67) do_query_distinct (test-ovsdb.c:1232) ovs_cmdl_run_command (command-line.c:121) main (test-ovsdb.c:72) Signed-off-by: William Tu --- tests/test-ovsdb.c | 4 1

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread Ben Pfaff
On Fri, Jan 22, 2016 at 08:29:27AM -0800, William Tu wrote: > Testcase 1311, 1312: Boolean-distinct queries on scalars, reports leak > below: > xmalloc (util.c:112) > do_query_distinct (test-ovsdb.c:1208) > ovs_cmdl_run_command (command-line.c:121) > main (test-ovsdb.c:72) > > Sign

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
I think so, too. However, valgrind does not report any leak related to 'classes'. So I don't have much confidence. On Fri, Jan 22, 2016 at 8:39 AM, Ben Pfaff wrote: > On Fri, Jan 22, 2016 at 08:29:27AM -0800, William Tu wrote: > > Testcase 1311, 1312: Boolean-distinct queries on scalars, reports

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread Ben Pfaff
I'd go ahead and free it. If we're wrong, valgrind will tell us about the invalid free. On Fri, Jan 22, 2016 at 08:45:28AM -0800, William Tu wrote: > I think so, too. > However, valgrind does not report any leak related to 'classes'. So I don't > have much confidence. > > On Fri, Jan 22, 2016 at

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
thanks, I will resubmit the patch. On Fri, Jan 22, 2016 at 9:31 AM, Ben Pfaff wrote: > I'd go ahead and free it. If we're wrong, valgrind will tell us about > the invalid free. > > On Fri, Jan 22, 2016 at 08:45:28AM -0800, William Tu wrote: > > I think so, too. > > However, valgrind does not re

Re: [ovs-dev] [PATCH] test-ovsdb: Fix memory leak reported by valgrind.

2016-02-10 Thread Ben Pfaff
On Tue, Feb 09, 2016 at 02:15:13PM -0800, William Tu wrote: > Testcase 1314: UUID-distinct queries on scalars. > Call stacks: > allocate_row (row.c:37) > ovsdb_row_clone (row.c:67) > do_query_distinct (test-ovsdb.c:1232) > ovs_cmdl_run_command (command-line.c:121) > main (test-o