[ovs-dev] [PATCH 04/14] Use ip_parse() and ipv6_parse() and variants in more places.

2015-12-08 Thread Ben Pfaff
This saves some code and improves clarity, in my opinion. Some of these changes just change an inet_pton() call into a similar ip_parse() or ipv6_parse() call. In those cases the benefit is better type safety, since inet_pton()'s output parameter is type "void *". Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH 04/14] Use ip_parse() and ipv6_parse() and variants in more places.

2015-12-09 Thread Justin Pettit
> On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > -gw6 = in6addr_any; > +gw6 = in6addr_exact; Did you mean to change this from "any" to "exact"? This is a nice improvement. Other than the above comment: Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH 04/14] Use ip_parse() and ipv6_parse() and variants in more places.

2015-12-15 Thread Ben Pfaff
On Wed, Dec 09, 2015 at 04:44:51PM -0800, Justin Pettit wrote: > > > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > > > > > -gw6 = in6addr_any; > > +gw6 = in6addr_exact; > > Did you mean to change this from "any" to "exact"? No. Thank you for pointing that out. I've ch