Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Ben Pfaff
On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote: Thanks for review, On 29 May 2015 at 13:22, Ben Pfaff b...@nicira.com wrote: On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com The code in scan_u128() looks

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Ben Pfaff
On Tue, Jun 02, 2015 at 10:13:06AM -0700, Joe Stringer wrote: For UFID, I sent a patch to reuse UUID for UFID: http://openvswitch.org/pipermail/dev/2015-June/055890.html OK, I'll go look at it now. I'm currently thinking that for 128-bit maskable bitfields like conn_label, I'll have

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-06 Thread Jarno Rajahalme
On Jun 6, 2015, at 2:13 PM, Ben Pfaff b...@nicira.com wrote: On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote: Thanks for review, On 29 May 2015 at 13:22, Ben Pfaff b...@nicira.com wrote: On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote: Signed-off-by: Joe

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-06-02 Thread Joe Stringer
For UFID, I sent a patch to reuse UUID for UFID: http://openvswitch.org/pipermail/dev/2015-June/055890.html I'm currently thinking that for 128-bit maskable bitfields like conn_label, I'll have something similar to this original patch, which will represent the value as

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-05-29 Thread Joe Stringer
Thanks for review, On 29 May 2015 at 13:22, Ben Pfaff b...@nicira.com wrote: On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com The code in scan_u128() looks wrong to me: I don't see anything that makes the second call to

Re: [ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-05-29 Thread Ben Pfaff
On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com The code in scan_u128() looks wrong to me: I don't see anything that makes the second call to ovs_scan(), to get the mask, skip past the value, e.g. by passing s + n to the second

[ovs-dev] [PATCH 1/3] odp-util: Refactor ovs_u128 handling functions.

2015-04-13 Thread Joe Stringer
Signed-off-by: Joe Stringer joestrin...@nicira.com --- include/openvswitch/types.h |7 -- lib/odp-util.c | 50 +++ lib/util.h | 17 +++ tests/test-hash.c | 10 - 4 files changed, 62