On Sat, Jun 06, 2015 at 02:19:03PM -0700, Jarno Rajahalme wrote:
>
> > On Jun 6, 2015, at 2:13 PM, Ben Pfaff wrote:
> >
> > On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote:
> >> Thanks for review,
> >>
> >> On 29 May 2015 at 13:22, Ben Pfaff wrote:
> >>> On Mon, Apr 13, 2015 at 05
> On Jun 6, 2015, at 2:13 PM, Ben Pfaff wrote:
>
> On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote:
>> Thanks for review,
>>
>> On 29 May 2015 at 13:22, Ben Pfaff wrote:
>>> On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote:
Signed-off-by: Joe Stringer
>>>
>>> Th
On Tue, Jun 02, 2015 at 10:13:06AM -0700, Joe Stringer wrote:
> For UFID, I sent a patch to reuse UUID for UFID:
> http://openvswitch.org/pipermail/dev/2015-June/055890.html
OK, I'll go look at it now.
> I'm currently thinking that for 128-bit maskable bitfields like
> conn_label, I'll have somet
On Fri, May 29, 2015 at 03:09:05PM -0700, Joe Stringer wrote:
> Thanks for review,
>
> On 29 May 2015 at 13:22, Ben Pfaff wrote:
> > On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote:
> >> Signed-off-by: Joe Stringer
> >
> > The code in scan_u128() looks wrong to me: I don't see anyth
For UFID, I sent a patch to reuse UUID for UFID:
http://openvswitch.org/pipermail/dev/2015-June/055890.html
I'm currently thinking that for 128-bit maskable bitfields like
conn_label, I'll have something similar to this original patch, which
will represent the value as "conn_label=0xf00bar/0xc
Thanks for review,
On 29 May 2015 at 13:22, Ben Pfaff wrote:
> On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>
> The code in scan_u128() looks wrong to me: I don't see anything that
> makes the second call to ovs_scan(), to get the mask, skip past t
On Mon, Apr 13, 2015 at 05:56:15PM -0700, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
The code in scan_u128() looks wrong to me: I don't see anything that
makes the second call to ovs_scan(), to get the mask, skip past the
value, e.g. by passing s + n to the second ovs_scan() or by advancin
Signed-off-by: Joe Stringer
---
include/openvswitch/types.h |7 --
lib/odp-util.c | 50 +++
lib/util.h | 17 +++
tests/test-hash.c | 10 -
4 files changed, 62 insertions(+), 22 deleti
