Re: [ovs-dev] [PATCH 1/4] ofp-parse: Fix typo in consistency check.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 10:18:26PM -0700, Joe Stringer wrote: > This check in parse_ofp_str__() attempted to detect inconsistencies > between matches and actions, or inconsistencies within the actions. In > this case, ofpacts_check() would effectively zero the "usable_protocols" > and return 0 (ie,

[ovs-dev] [PATCH 1/4] ofp-parse: Fix typo in consistency check.

2015-07-15 Thread Joe Stringer
This check in parse_ofp_str__() attempted to detect inconsistencies between matches and actions, or inconsistencies within the actions. In this case, ofpacts_check() would effectively zero the "usable_protocols" and return 0 (ie, OK). However, when checking the return parameter, it checks the point