On Apr 19, 2014, at 9:51 PM, Kmindg G wrote:
> On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme
> wrote:
>>
>> static struct cls_match *
>> cls_match_alloc(struct cls_rule *rule)
>> {
>> -struct cls_match *cls_match = xmalloc(sizeof *cls_match);
>> +int count = count_1bits(rule->match
Series pushed!
Thanks for the review, Ethan!
Jarno
On Apr 29, 2014, at 2:35 PM, Ethan Jackson wrote:
> Meh I changed my mind again. Just merge the series instead of holding
> back, I'll make my tweaks on top of master.
>
> Ethan
>
> On Tue, Apr 29, 2014 at 2:34 PM, Ethan Jackson wrote:
>
Meh I changed my mind again. Just merge the series instead of holding
back, I'll make my tweaks on top of master.
Ethan
On Tue, Apr 29, 2014 at 2:34 PM, Ethan Jackson wrote:
>> The almost equivalent function miniflow_equal_flow_in_minimask() does not
>> require the miniflow and minimask to hav
> The almost equivalent function miniflow_equal_flow_in_minimask() does not
> require the miniflow and minimask to have the same map, and it is slower for
> it. However, it is only used by the test-classifier.c, so one option to
> reduce the confusion would be to move it there. What do you think
On Apr 28, 2014, at 7:07 PM, Ethan Jackson wrote:
> The comment of miniflow_and_mask_matches_flow() need to be reworded.
>
> Do we really need that function? Is it really that much faster?
> Having two functions which do the exact same thing is a bit confusing.
The almost equivalent function
The comment of miniflow_and_mask_matches_flow() need to be reworded.
Do we really need that function? Is it really that much faster?
Having two functions which do the exact same thing is a bit confusing.
So I suppose the only reason for a non zero inline_values array is for
those callers who can
On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme wrote:
> Change the classifier to allocate variable sized miniflows and
> minimasks in cls_match and cls_subtable, respectively. Do not
> duplicate the mask in cls_rule any more.
>
> miniflow_clone and miniflow_move can now take variably sized mini
Change the classifier to allocate variable sized miniflows and
minimasks in cls_match and cls_subtable, respectively. Do not
duplicate the mask in cls_rule any more.
miniflow_clone and miniflow_move can now take variably sized miniflows
as source. The destination is assumed to be regularly sized
