Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-03-05 Thread Daniele Venturino
I'm not sure, but if a user enabled one of them with *ovs-vsctl set Bridge br0 stp_enable/rstp_enable=true* and then the other one with *ovs-vsctl set Bridge br0 rstp_enable/stp_enable=true* this last command has no effects. See: static void bridge_configure_rstp(struct bridge *br) {

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-03-05 Thread Ben Pfaff
On Wed, Feb 25, 2015 at 04:00:36PM +0100, Daniele Venturino wrote: +STP and RSTP are mutually exclusive. If both are enabled, RSTP +will be used. I think this might not be true. If it has not been changed, when STP or RSTP is enabled it should not be possible

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-03-05 Thread Ben Pfaff
Thanks for confirming. I sent out a patch to make behavior better resemble what ovs-vswitchd does in other similar situations. Will you look at it? It is here: http://openvswitch.org/pipermail/dev/2015-March/052049.html On Thu, Mar 05, 2015 at 07:06:02PM +0100, Daniele Venturino wrote:

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-25 Thread Daniele Venturino
Hi, +STP and RSTP are mutually exclusive. If both are enabled, RSTP +will be used. I think this might not be true. If it has not been changed, when STP or RSTP is enabled it should not be possible to enable the other one on the same bridge. This is done in

[ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Ben Pfaff
A fair number of columns had been overlooked. This documents them. The patch is smaller than it appears because this rearranges the STP and RSTP documentation to group configuration, status, and statistics together in the documentation for clarity. Signed-off-by: Ben Pfaff b...@nicira.com ---

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Gurucharan Shetty
On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff b...@nicira.com wrote: A fair number of columns had been overlooked. This documents them. The patch is smaller than it appears because this rearranges the STP and RSTP documentation to group configuration, status, and statistics together in the

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Ben Pfaff
I decided to apply this, but I'd still like to improve the documentation further if possible, so when you get a chance please review the RSTP documentation in vswitch.xml. On Thu, Feb 19, 2015 at 09:48:15AM -0800, Jarno Rajahalme wrote: I?ll look in to this, Jarno On Feb 19, 2015, at

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Ben Pfaff
On Thu, Feb 19, 2015 at 04:00:43AM -0800, Gurucharan Shetty wrote: On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff b...@nicira.com wrote: A fair number of columns had been overlooked. This documents them. The patch is smaller than it appears because this rearranges the STP and RSTP

Re: [ovs-dev] [PATCH 2/8] vswitch: Document columns that had been previously overlooked.

2015-02-19 Thread Jarno Rajahalme
I’ll look in to this, Jarno On Feb 19, 2015, at 9:22 AM, Ben Pfaff b...@nicira.com wrote: On Thu, Feb 19, 2015 at 04:00:43AM -0800, Gurucharan Shetty wrote: On Thu, Feb 19, 2015 at 12:12 AM, Ben Pfaff b...@nicira.com wrote: A fair number of columns had been overlooked. This documents