Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

2016-02-23 Thread Ilya Maximets
Thanks for review. Comments inline. On 23.02.2016 05:33, Daniele Di Proietto wrote: >> Reassignment of all rx queues done to achieve fair distribution. >> @@ -2401,11 +2405,20 @@ static int >> dpif_netdev_pmd_set(struct dpif *dpif, const char *cmask) >> { >> struct dp_netdev *dp =

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

2016-02-22 Thread Daniele Di Proietto
Thanks for the patch I have a few comments inline On 08/02/2016 07:30, "Ilya Maximets" wrote: >Since 5f2ccb1c0d3b ("dpif: Allow adding ukeys for same flow by >different pmds.") there is the possibility to reassign queues among >pmd threads without restarting them and

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

2016-02-18 Thread Flavio Leitner
On Mon, 08 Feb 2016 18:30:31 +0300 Ilya Maximets wrote: > Since 5f2ccb1c0d3b ("dpif: Allow adding ukeys for same flow by > different pmds.") there is the possibility to reassign queues among > pmd threads without restarting them and deleting the megaflow cache. > > So,

[ovs-dev] [PATCH 3/3] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

2016-02-08 Thread Ilya Maximets
Since 5f2ccb1c0d3b ("dpif: Allow adding ukeys for same flow by different pmds.") there is the possibility to reassign queues among pmd threads without restarting them and deleting the megaflow cache. So, reconfiguration can be performed without destroying of PMD threads if pmd-cpu-mask not