Re: [ovs-dev] [PATCH 4/5] system-macros: Create ADD_BR variant.

2015-08-10 Thread Joe Stringer
This is an attempt at getting better consistency. ADD_VLAN, ADD_NATIVE_TUNNEL, etc. all work as separate commands in the test. Having ADD_BR act differently is more difficult for the reader to parse. Thanks for the review. On 10 August 2015 at 11:45, Daniele Di Proietto wrote: > My idea was to u

Re: [ovs-dev] [PATCH 4/5] system-macros: Create ADD_BR variant.

2015-08-10 Thread Daniele Di Proietto
My idea was to use ADD_BR inside the OVS_TRAFFIC_VSWITCHD_START() parameters, but I'm fine with this approach too. Acked-by: Daniele Di Proietto On 08/08/2015 00:28, "Joe Stringer" wrote: >This patch splits ADD_BR into two commands, so they can be used from >different contexts: > >ADD_BR(...)

[ovs-dev] [PATCH 4/5] system-macros: Create ADD_BR variant.

2015-08-07 Thread Joe Stringer
This patch splits ADD_BR into two commands, so they can be used from different contexts: ADD_BR(...) is a standalone command to add a bridge to OVS, and allows additional ovs-vsctl arguments to be passed. It uses _ADD_BR(). _ADD_BR(...) is the implementation-specific ovs-vsctl arguments to set up