Re: [ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-11 Thread Russell Bryant
On 12/10/2015 09:22 PM, Justin Pettit wrote: > >> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: >> >> The previous code processed the input file line by line, but I think >> it looks a little more straight forward to just process the whole file >> at once. >> >> This patch also explicitly c

Re: [ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: > > The previous code processed the input file line by line, but I think > it looks a little more straight forward to just process the whole file > at once. > > This patch also explicitly closes the file after reading its contents. > > Sign

[ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-10 Thread Russell Bryant
The previous code processed the input file line by line, but I think it looks a little more straight forward to just process the whole file at once. This patch also explicitly closes the file after reading its contents. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 12 +--- 1