Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-25 Thread Yin Lin
Hi Sai, After looking at your follow up patches, I feel it's better to rename OVS_MCAST_EVENT_ENTRIES as OVS_MCAST_EVENT_TYPE, and rename OVS_MCAST_EVENT_ENTRIES_MAX as OVS_MCAST_EVENT_TYPES_MAX. At first glance, event_entries_max seems to suggest the maximum number of events in a queue, which is

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-25 Thread Sairam Venugopal
anks, >Alin. > >> -Mesaj original- >> De la: Sairam Venugopal [mailto:vsai...@vmware.com] >> Trimis: Friday, July 22, 2016 11:15 PM >> Către: Alin Serdean <aserd...@cloudbasesolutions.com>; >> dev@openvswitch.org >> Subiect: Re: [ovs-d

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-22 Thread Alin Serdean
rdean <aserd...@cloudbasesolutions.com>; > dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast > conntrack events > > Yes, I wanted to keep it similar to the VPORT events: > > enum { > OVS_EVENT_CONNECT = ((uint32_t)0x1 << 0), >

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-22 Thread Sairam Venugopal
utions.com> wrote: >Looks good just one question inlined. > > > >> -Mesaj original- > >> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > >> Venugopal > >> Trimis: Thursday, July 14, 2016 2:39 AM > >> Către: dev

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-22 Thread Alin Serdean
Looks good just one question inlined. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 5/9] datapath-windows: De

[ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-13 Thread Sairam Venugopal
Define new Conntrack events (new and delete) and add support for subscribing to these events. Parse out OVS_NL_ATTR_MCAST_GRP and store it as part of OVS_EVENT_SUBSCRIBE structure. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Datapath.c | 21