Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-08 Thread Joe Stringer
On 8 July 2015 at 17:10, Ben Pfaff wrote: > On Wed, Jul 08, 2015 at 01:12:26PM -0700, Joe Stringer wrote: >> On 7 July 2015 at 21:42, Ben Pfaff wrote: >> > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: >> >> On 6 July 2015 at 22:20, Ben Pfaff wrote: >> >> > When process_upcall()

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-08 Thread Ben Pfaff
On Wed, Jul 08, 2015 at 01:12:26PM -0700, Joe Stringer wrote: > On 7 July 2015 at 21:42, Ben Pfaff wrote: > > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: > >> On 6 July 2015 at 22:20, Ben Pfaff wrote: > >> > When process_upcall() passes a miss upcall to upcall_xlate(), the new >

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-08 Thread Joe Stringer
On 7 July 2015 at 21:42, Ben Pfaff wrote: > On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: >> On 6 July 2015 at 22:20, Ben Pfaff wrote: >> > When process_upcall() passes a miss upcall to upcall_xlate(), the new >> > ukey's dump_seq member is initialized from the current dump_seq.

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-07 Thread Ben Pfaff
On Tue, Jul 07, 2015 at 08:13:58PM -0700, Joe Stringer wrote: > On 6 July 2015 at 22:20, Ben Pfaff wrote: > > When process_upcall() passes a miss upcall to upcall_xlate(), the new > > ukey's dump_seq member is initialized from the current dump_seq. Later, > > when udpif_revalidator() calls revali

Re: [ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-07 Thread Joe Stringer
On 6 July 2015 at 22:20, Ben Pfaff wrote: > When process_upcall() passes a miss upcall to upcall_xlate(), the new > ukey's dump_seq member is initialized from the current dump_seq. Later, > when udpif_revalidator() calls revalidate(), any dumped flow for which > ukey->dump_seq equals the current

[ovs-dev] [PATCH RFC] ofproto-dpif-upcall: Increment dump_seq before instead of after dump.

2015-07-06 Thread Ben Pfaff
When process_upcall() passes a miss upcall to upcall_xlate(), the new ukey's dump_seq member is initialized from the current dump_seq. Later, when udpif_revalidator() calls revalidate(), any dumped flow for which ukey->dump_seq equals the current dump_seq is skipped. However, until now the curren