Shelar
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH RFC 2/2] openvswitch: Userspace tunneling.
On Oct 13, 2014, at 2:32 PM, Pravin Shelar pshe...@nicira.com wrote:
+case OVS_ACTION_ATTR_TUNNEL_PUSH:
+if (*depth MAX_RECIRC_DEPTH) {
+struct dpif_packet *tnl_pkt
@openvswitch.org
Subject: Re: [ovs-dev] [PATCH RFC 2/2] openvswitch: Userspace tunneling.
On Oct 13, 2014, at 2:32 PM, Pravin Shelar pshe...@nicira.com wrote:
+case OVS_ACTION_ATTR_TUNNEL_PUSH:
+if (*depth MAX_RECIRC_DEPTH) {
+struct dpif_packet *tnl_pkt[NETDEV_MAX_RX_BATCH
On Thu, Oct 9, 2014 at 2:53 PM, Jarno Rajahalme jrajaha...@nicira.com wrote:
Pravin,
Please find my comments below. I did not snip any code to make it easier for
you to keep into context while reading this review.
Thanks for detailed review.
Jarno
On Oct 3, 2014, at 8:24 PM, Pravin B
On Oct 13, 2014, at 2:32 PM, Pravin Shelar pshe...@nicira.com wrote:
+case OVS_ACTION_ATTR_TUNNEL_PUSH:
+if (*depth MAX_RECIRC_DEPTH) {
+struct dpif_packet *tnl_pkt[NETDEV_MAX_RX_BATCH];
+int err;
+
+if (may_steal) {
+
Pravin,
Please find my comments below. I did not snip any code to make it easier for
you to keep into context while reading this review.
Jarno
On Oct 3, 2014, at 8:24 PM, Pravin B Shelar pshe...@nicira.com wrote:
Following patch adds support for userspace tunneling. Tunneling
needs three
Some more comments:
(snip)
+}
+
+static void
+tnl_port_unref(struct cls_rule *cr)
+{
+if (cr) {
+struct tunnel_ports *p;
+
+p = tnl_port_cast(cr);
+if (ovs_refcount_unref_relaxed(p-ref_cnt) == 1) {
+ classifier_remove(cls, cr);
You must also free
Following patch adds support for userspace tunneling. Tunneling
needs three more component first is routing table which is configured by
user and second is ARP cache which build automatically by snooping arp.
And third is tunnel protocol table which list all listening protocols
which is populated
