Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
On 28 August 2015 at 10:51, Joe Stringer wrote: > On 28 August 2015 at 09:41, Daniele Di Proietto > wrote: > > I've tested it and it appears to correctly keep all the stats. > > > > Two comments inline, otherwise: > > > > Acked-by: Daniele Di Proietto > > That could even be... dare I say it...

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
Thx a lot for the quick review, On 28 August 2015 at 09:41, Daniele Di Proietto wrote: > I've tested it and it appears to correctly keep all the stats. > > Two comments inline, otherwise: > > Acked-by: Daniele Di Proietto > > Thanks for fixing this Alex! > > On 28/08/2015 06:25, "Alex Wang" wr

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread ALeX Wang
Thanks, fixed the typo and adopted your suggested change,~ On 28 August 2015 at 09:18, Jarno Rajahalme wrote: > > > On Aug 27, 2015, at 10:25 PM, Alex Wang wrote: > > > > When dpdk configuration changes, all pmd threads are recreated > > and rx queues of each port are reloaded. After this proc

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Daniele Di Proietto
On 28/08/2015 18:51, "Joe Stringer" wrote: >On 28 August 2015 at 09:41, Daniele Di Proietto >wrote: >> I've tested it and it appears to correctly keep all the stats. >> >> Two comments inline, otherwise: >> >> Acked-by: Daniele Di Proietto > >That could even be... dare I say it... "Tested-by:

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Joe Stringer
On 28 August 2015 at 09:41, Daniele Di Proietto wrote: > I've tested it and it appears to correctly keep all the stats. > > Two comments inline, otherwise: > > Acked-by: Daniele Di Proietto That could even be... dare I say it... "Tested-by: ..." :-) In general this patch seems fine. I'm not en

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Daniele Di Proietto
I've tested it and it appears to correctly keep all the stats. Two comments inline, otherwise: Acked-by: Daniele Di Proietto Thanks for fixing this Alex! On 28/08/2015 06:25, "Alex Wang" wrote: >When dpdk configuration changes, all pmd threads are recreated >and rx queues of each port are re

Re: [ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-28 Thread Jarno Rajahalme
> On Aug 27, 2015, at 10:25 PM, Alex Wang wrote: > > When dpdk configuration changes, all pmd threads are recreated > and rx queues of each port are reloaded. After this process, > rx queue could be mapped to a different pmd thread other than > the one before reconfiguration. However, this is

[ovs-dev] [PATCH V2 2/2] dpif-netdev: Purge all ukeys when reconfigure pmd.

2015-08-27 Thread Alex Wang
When dpdk configuration changes, all pmd threads are recreated and rx queues of each port are reloaded. After this process, rx queue could be mapped to a different pmd thread other than the one before reconfiguration. However, this is totally transparent to ofproto layer modules. So, if the ofpr