[ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-01 Thread Simon Horman
* Set skb protocol based on contents of packet. I have observed this is necessary to get actual protocol of a packet when it is injected into an internal device e.g. by libnet in which case skb protocol will be set to ETH_ALL. * Set the mac_len which has been observed to not be set up correc

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-02 Thread pravin shelar
On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman wrote: > * Set skb protocol based on contents of packet. I have observed this is > necessary to get actual protocol of a packet when it is injected into an > internal device e.g. by libnet in which case skb protocol will be set to > ETH_ALL. > >

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-06 Thread Simon Horman
On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: > On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman > wrote: > > * Set skb protocol based on contents of packet. I have observed this is > > necessary to get actual protocol of a packet when it is injected into an > > internal device e

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-07 Thread pravin shelar
On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman wrote: > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman >> wrote: >> > * Set skb protocol based on contents of packet. I have observed this is >> > necessary to get actual protocol of a

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-16 Thread Simon Horman
On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote: > On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman > wrote: > > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: > >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman > >> wrote: > >> > * Set skb protocol based on contents of

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-18 Thread pravin shelar
On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman wrote: > On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote: >> On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman >> wrote: >> > On Thu, Jun 02, 2016 at 03:01:47PM -0700, pravin shelar wrote: >> >> On Wed, Jun 1, 2016 at 11:24 PM, Simon Horman

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-20 Thread Simon Horman
[Cc Jiri Benc] On Sat, Jun 18, 2016 at 06:38:54PM -0700, pravin shelar wrote: > On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman > wrote: > > On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote: > >> On Mon, Jun 6, 2016 at 8:08 PM, Simon Horman > >> wrote: > >> > On Thu, Jun 02, 2016 at

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-21 Thread pravin shelar
On Mon, Jun 20, 2016 at 7:25 PM, Simon Horman wrote: > [Cc Jiri Benc] > > On Sat, Jun 18, 2016 at 06:38:54PM -0700, pravin shelar wrote: >> On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman >> wrote: >> > On Tue, Jun 07, 2016 at 03:45:27PM -0700, pravin shelar wrote: >> >> On Mon, Jun 6, 2016 at 8:0

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-22 Thread Simon Horman
On Tue, Jun 21, 2016 at 09:30:17AM -0700, pravin shelar wrote: > On Mon, Jun 20, 2016 at 7:25 PM, Simon Horman > wrote: > > [Cc Jiri Benc] > > > > On Sat, Jun 18, 2016 at 06:38:54PM -0700, pravin shelar wrote: > >> On Thu, Jun 16, 2016 at 10:53 PM, Simon Horman > >> wrote: > >> > On Tue, Jun 07,

Re: [ovs-dev] [PATCH net-next v10 2/5] openvswitch: set skb protocol and mac_len when receiving on internal device

2016-06-27 Thread Jiri Benc
On Thu, 23 Jun 2016 11:04:38 +0900, Simon Horman wrote: > I think you are right as IIRC the call to skb_reset_mac_header was > added for this use-case. Its unfortunate that we can't use it in > internal_dev_xmit() because of loosing track of MPLS as you mentioned > earlier. But it does seem that se