Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-07 Thread Jesse Gross
On Mon, May 4, 2015 at 3:58 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 552e748..84cb835 100644 --- a/datapath/linux/compat/gso.c +++ b/datapath/linux/compat/gso.c [...] /* Strictly this is not needed and will be

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-07 Thread Pravin Shelar
On Thu, May 7, 2015 at 4:28 PM, Jesse Gross je...@nicira.com wrote: On Mon, May 4, 2015 at 3:58 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 552e748..84cb835 100644 --- a/datapath/linux/compat/gso.c +++

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-04 Thread Jesse Gross
On Fri, May 1, 2015 at 7:00 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 552e748..f8a70d0 100644 --- a/datapath/linux/compat/gso.c +++ b/datapath/linux/compat/gso.c @@ -219,6 +219,9 @@ static struct sk_buff

[ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-04 Thread Pravin B Shelar
OVS correctly define skb_gso_segment() to handle MPLS and VLAN segmentation correctly. But OVS also uses __skb_gso_segment() in some cases. Following patch defines compat __skb_gso_segment() to handle all segmentation cases. Signed-off-by: Pravin B Shelar pshe...@nicira.com ---

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-04 Thread Jesse Gross
On Mon, May 4, 2015 at 12:48 PM, Pravin Shelar pshe...@nicira.com wrote: On Mon, May 4, 2015 at 11:26 AM, Jesse Gross je...@nicira.com wrote: What was the change that bumps up the backport requirement from 3.16 to 3.19? MPLS offload is supported on 3.19 or newer. OK, I remember - you made

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-04 Thread Pravin Shelar
On Mon, May 4, 2015 at 1:25 PM, Jesse Gross je...@nicira.com wrote: On Mon, May 4, 2015 at 12:48 PM, Pravin Shelar pshe...@nicira.com wrote: On Mon, May 4, 2015 at 11:26 AM, Jesse Gross je...@nicira.com wrote: What was the change that bumps up the backport requirement from 3.16 to 3.19?

Re: [ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-04 Thread Pravin Shelar
On Mon, May 4, 2015 at 11:26 AM, Jesse Gross je...@nicira.com wrote: On Fri, May 1, 2015 at 7:00 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 552e748..f8a70d0 100644 --- a/datapath/linux/compat/gso.c +++

[ovs-dev] [PATCH v2] datapath: define compat __skb_gso_segment()

2015-05-01 Thread Pravin B Shelar
OVS correctly define skb_gso_segment() to handle MPLS and VLAN segmentation correctly. But OVS also uses __skb_gso_segment() in some cases. Following patch defines compat __skb_gso_segment() to handle all segmentation cases. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- Fixed