[ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-25 Thread Sairam Venugopal
Update OvsLookupFlow() to include flowKey->RecircId when computing hash. Use the right source port Id for checking if a packet is received or transmitted. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Actions.c | 2 +- datapath-windows/ovsext/Flow.c| 3 +++ 2 files changed, 4

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-28 Thread Alin Serdean
Comments inlined. Thanks, Alin. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Friday, March 25, 2016 8:07 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v2] datapath-windows: Update Recircul

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-28 Thread Sairam Venugopal
numele Sairam > >> Venugopal > >> Trimis: Friday, March 25, 2016 8:07 PM > >> Către: dev@openvswitch.org > >> Subiect: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to > >> use the right parameters > >> > >

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-29 Thread Nithin Raju
t;dev@openvswitch.org" Subject: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters >Update OvsLookupFlow() to include flowKey->RecircId when computing hash. >Use the right source port Id for checking if a packet is received or >transmi

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-29 Thread Alin Serdean
Comments inlined. Thanks, Alin. > -Mesaj original- > This comparison determines the value for ŒisRecv¹ parameter. ŒisRecv¹ > determines whether the OOB data should be interpreted as receive data or > send data. So, the existing code is checking for: > srcPortNo == switchContext->virtualExt

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-29 Thread Sairam Venugopal
Hi Alin, I have sent out a newer series of patches with the changes. These are necessary to fix the master and test out Connection Tracking patch. We can circle back and cleanup Flow.c to use KeyLen and align it by 8, after ensuring that things are working properly. Thanks, Sairam On 3/29/16, 9

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-29 Thread Alin Serdean
thin Raju > ; dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation > to use the right parameters > > Hi Alin, > > I have sent out a newer series of patches with the changes. These are > necessary to fix the master and test out Connec

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-31 Thread Sairam Venugopal
vswitch.org >> Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation >> to use the right parameters >> >> Hi Alin, >> >> I have sent out a newer series of patches with the changes. These are >> necessary to fix the master and test out Co

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-31 Thread Alin Serdean
> >> De la: Sairam Venugopal [mailto:vsai...@vmware.com] > >> Trimis: Wednesday, March 30, 2016 3:53 AM > >> Către: Alin Serdean ; Nithin Raju > >> ; dev@openvswitch.org > >> Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Update > >> Recirculat

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Recirculation to use the right parameters

2016-03-31 Thread Sairam Venugopal
more things I don't like. >> > >> >Alin. >> >> -Mesaj original- >> >> De la: Sairam Venugopal [mailto:vsai...@vmware.com] >> >> Trimis: Wednesday, March 30, 2016 3:53 AM >> >> Către: Alin Serdean ; Nithin Raju >> &g