Re: [ovs-dev] [PATCH v2] ipfix: Bug fix for not sending template packets on 32-bit OS

2016-06-14 Thread Ben Pfaff
On Tue, Jun 14, 2016 at 11:09:45AM +0800, Benli Ye wrote: > 'last_template_set_time' in truct dpif_ipfix_exporter is declared > as time_t and time_t is long int type. If we initialize > 'last_template_set_time' as TIME_MIN, whose value is -2147483648 > on 32-bit OS and -2^63 on 64-bit OS. There

Re: [ovs-dev] [PATCH v2] ipfix: Bug fix for not sending template packets on 32-bit OS

2016-06-14 Thread William Tu
Looks good to me. Acked-by: William Tu On Mon, Jun 13, 2016 at 8:09 PM, Benli Ye wrote: > 'last_template_set_time' in truct dpif_ipfix_exporter is declared > as time_t and time_t is long int type. If we initialize > 'last_template_set_time' as TIME_MIN,

[ovs-dev] [PATCH v2] ipfix: Bug fix for not sending template packets on 32-bit OS

2016-06-13 Thread Benli Ye
'last_template_set_time' in truct dpif_ipfix_exporter is declared as time_t and time_t is long int type. If we initialize 'last_template_set_time' as TIME_MIN, whose value is -2147483648 on 32-bit OS and -2^63 on 64-bit OS. There will be a problem on 32-bit OS when comparing