On Thu, Sep 4, 2014 at 8:42 AM, Jarno Rajahalme wrote:
> Small nits below, otherwise looks good to me (even though I’m not versed in
> MSVC),
>
> Signed-off-by: Jarno Rajahalme
>
> On Sep 3, 2014, at 1:08 PM, Gurucharan Shetty wrote:
>> +
>> +/* 64 bit writes are atomic on i586 if 64 bit align
> However, you should probably keep the version in your patch if you
> know that the alignment check can be computed at compile-time and/or
> there is some documentation that MSVC will not align 64-bit units on
> at 4-byte alignment.
https://urldefense.proofpoint.com/v1/url?u=http://msdn.micros
On Thu, Sep 04, 2014 at 08:42:44AM -0700, Jarno Rajahalme wrote:
> Small nits below, otherwise looks good to me (even though I?m not versed in
> MSVC),
>
> Signed-off-by: Jarno Rajahalme
>
> On Sep 3, 2014, at 1:08 PM, Gurucharan Shetty wrote:
> >
> > +/* 64 bit writes are atomic on i586 if 64
Small nits below, otherwise looks good to me (even though I’m not versed in
MSVC),
Signed-off-by: Jarno Rajahalme
On Sep 3, 2014, at 1:08 PM, Gurucharan Shetty wrote:
> Before this change (i.e., with pthread locks for atomics on Windows),
> the benchmark for cmap and hmap was as follows:
>
>
Before this change (i.e., with pthread locks for atomics on Windows),
the benchmark for cmap and hmap was as follows:
$ ./tests/ovstest.exe test-cmap benchmark 1000 3 1
Benchmarking with n=1000, 3 threads, 1.00% mutations:
cmap insert: 61070 ms
cmap iterate: 2750 ms
cmap search: 14238 m
