Re: [ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 Thread Joe Stringer
On 9 September 2015 at 15:38, Ben Pfaff wrote: > On Wed, Sep 09, 2015 at 03:36:56PM -0700, Joe Stringer wrote: >> On 2 September 2015 at 16:43, Ben Pfaff wrote: >> > dnl set up sFlow logging >> > -dnl ON_EXIT([kill `cat test-sflow.pid`]) >> > AT_CHECK([ovstest test-sflow --log-file --detach --n

Re: [ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 Thread Ben Pfaff
On Wed, Sep 09, 2015 at 03:36:56PM -0700, Joe Stringer wrote: > On 2 September 2015 at 16:43, Ben Pfaff wrote: > > dnl set up sFlow logging > > -dnl ON_EXIT([kill `cat test-sflow.pid`]) > > AT_CHECK([ovstest test-sflow --log-file --detach --no-chdir --pidfile > > 0:127.0.0.1 > sflow.log], [0],

Re: [ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 Thread Joe Stringer
On 2 September 2015 at 16:43, Ben Pfaff wrote: > dnl set up sFlow logging > -dnl ON_EXIT([kill `cat test-sflow.pid`]) > AT_CHECK([ovstest test-sflow --log-file --detach --no-chdir --pidfile > 0:127.0.0.1 > sflow.log], [0], [], [ignore]) > AT_CAPTURE_FILE([sflow.log]) > SFLOW_PORT=`parse_liste

Re: [ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 Thread Ben Pfaff
Thanks Andy, applied to master. On Tue, Sep 08, 2015 at 05:14:24PM -0700, Andy Zhou wrote: > Acked-by: Andy Zhou > > On Wed, Sep 2, 2015 at 4:43 PM, Ben Pfaff wrote: > > A shell function doesn't need quoted and unquoted variants and it > > integrates naturally with other shell code. > > > > Sig

Re: [ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-08 Thread Andy Zhou
Acked-by: Andy Zhou On Wed, Sep 2, 2015 at 4:43 PM, Ben Pfaff wrote: > A shell function doesn't need quoted and unquoted variants and it > integrates naturally with other shell code. > > Signed-off-by: Ben Pfaff > --- > tests/ofproto-dpif.at | 61 >

[ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-02 Thread Ben Pfaff
A shell function doesn't need quoted and unquoted variants and it integrates naturally with other shell code. Signed-off-by: Ben Pfaff --- tests/ofproto-dpif.at | 61 --- tests/ofproto-macros.at | 4 +-- tests/ofproto.at | 6 ++