[ovs-dev] [PATCH v2 1/5] netdev-dpdk: Refactor dpdk_queue_flush().

2014-06-26 Thread Ryan Wilson
This patch refactors dpdk_queue_flush() to reuse code in dpdk_queue_pkts(). Signed-off-by: Ryan Wilson --- lib/netdev-dpdk.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 72add87..084e8cd

Re: [ovs-dev] [PATCH v2 1/5] netdev-dpdk: Refactor dpdk_queue_flush().

2014-06-30 Thread Daniele Di Proietto
I don’t know if we want to keep the inline attribute here (like Pravin said for commit 4/5). Otherwise LGTM Daniele On Jun 26, 2014, at 6:16 PM, Ryan Wilson wrote: > This patch refactors dpdk_queue_flush() to reuse code in > dpdk_queue_pkts(). > > Signed-off-by: Ryan Wilson > --- > lib/netd

Re: [ovs-dev] [PATCH v2 1/5] netdev-dpdk: Refactor dpdk_queue_flush().

2014-06-30 Thread Ryan Wilson 76511
I'll add the inline to both dpdk_queue_flush() and dpdk_queue_flush__() and repost this patch. Cheers, Ryan On 6/30/14 9:52 AM, "Daniele Di Proietto" wrote: >I don¹t know if we want to keep the inline attribute here (like Pravin >said for commit 4/5). > >Otherwise LGTM > >Daniele > >On Jun 26,

Re: [ovs-dev] [PATCH v2 1/5] netdev-dpdk: Refactor dpdk_queue_flush().

2014-06-30 Thread Pravin Shelar
On Mon, Jun 30, 2014 at 10:53 AM, Ryan Wilson 76511 wrote: > I'll add the inline to both dpdk_queue_flush() and dpdk_queue_flush__() > and repost this patch. > Actually I did it and pushed the patch. I also added unlikely in flush function. Thanks, Pravin. > Cheers, > > Ryan > > On 6/30/14 9:52