Re: [ovs-dev] [PATCH v2 2/5] netdev-dpdk: Set current timestamp when flushing TX queue.

2014-06-30 Thread Daniele Di Proietto
On Jun 30, 2014, at 11:08 AM, Pravin Shelar wrote: > On Mon, Jun 30, 2014 at 9:56 AM, Daniele Di Proietto > wrote: >> I was happier with the previous approach, i.e. setting the timestamp on the >> first queued packet. >> Maybe there are issues I don’t see, can you elaborate a little? >> > >

Re: [ovs-dev] [PATCH v2 2/5] netdev-dpdk: Set current timestamp when flushing TX queue.

2014-06-30 Thread Pravin Shelar
On Mon, Jun 30, 2014 at 9:56 AM, Daniele Di Proietto wrote: > I was happier with the previous approach, i.e. setting the timestamp on the > first queued packet. > Maybe there are issues I don’t see, can you elaborate a little? > tsc is set conditionally when count is one, but the count might not

Re: [ovs-dev] [PATCH v2 2/5] netdev-dpdk: Set current timestamp when flushing TX queue.

2014-06-30 Thread Daniele Di Proietto
I was happier with the previous approach, i.e. setting the timestamp on the first queued packet. Maybe there are issues I don’t see, can you elaborate a little? Thanks, Daniele On Jun 26, 2014, at 6:16 PM, Ryan Wilson wrote: > The current timestamp should be set every time the queue is flushe

[ovs-dev] [PATCH v2 2/5] netdev-dpdk: Set current timestamp when flushing TX queue.

2014-06-26 Thread Ryan Wilson
The current timestamp should be set every time the queue is flushed. Thus, if DRAIN_TSC timer cycles have passed since the last timestamp, the send queue should be flushed again. Signed-off-by: Ryan Wilson --- lib/netdev-dpdk.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) di